| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fixes improper database name when creating a new rails app with a '.'
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| | |
application. EG: `rails new something.awesome.com`
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since the default in Rails 4.0 is to run in 'threadsafe' mode we need
to eager load all of the paths in `autoload_paths` so we alias
`eager_load_paths` to it. This may have unintended consequences if
you have added 'lib' to `autoload_paths` such as loading unneeded
code or code intended only for development and/or test environments.
If this applies to your application you should thoroughly check what
is being eager loaded.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 43e14f8ff203c21646f733d35bdde4e68da70a3b, reversing
changes made to bb17a0f085aba40a1952612f6c98b2a5804a1152.
Conflicts:
railties/lib/rails/generators/rails/app/templates/config/application.rb
railties/lib/rails/generators/rails/app/templates/config/initializers/locale.rb
Reason: setting the Time.zone in an after_initialize block can become a
problem for people upgrading, since it's not going to be available when
config/initializers run, and people might be relying on it.
An example that I noticed was with the Chronic gem, for date/time parsing.
It requires us to configure the time class to be Time.zone, and doing
that in an initializer no longer worked with these changes, so reverting
is the safer path for now.
|
| |
| |
| |
| | |
`require 'rubygems'` is already required in Ruby 1.9 or later.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Adding Back Rails::Engine::Railties#engines
Conflicts:
railties/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | | |
Removing it breaks functionality with gems such as Thinking Sphinx.
This restores it with a deprecation warning. Closes #8551
|
| | | |
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| | |
Allows custom rake tasks to be defined using:
SourceAnnotationExtractor.enumerate 'TODO|FIXME', dirs: %w(app lib), tag: true
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Deprecate #update_attributes in favor of `#update`.
ORMs that implement `Generators::ActiveModel#update_attributes` should change
to `#update`. Scaffold controller generators should change calls like:
@orm_instance.update_attributes(...)
to:
@orm_instance.update(...)
This goes along with the addition of `ActiveRecord::Base#update`,
introduced in cb2bd4aa619d9329c42aaf6d9f8eacc616ce53f4.
|
|\ \
| | |
| | | |
Controller scaffold codestyle
|
| | | |
|
| | | |
|
|/ / |
|
| |
| |
| |
| | |
API. The default scaffold will now just create HTML if the user actively opts out of jbuilder
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
guides/source/getting_started.md
|
| | | |
|
| | |
| | |
| | |
| | | |
It is semantically correct than relative path.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Don't require 'turn' from rails/test_help
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If 'turn' is in the Gemfile with `:require => nil`, Rails should
respect that.
This supports the case where 'turn' may or may not be required
depending on different developers' preference or environment. E.g., you
require turn for local testing, but not on your CI server by putting
this in `test/test_helper.rb`:
require 'turn' if ENV['TURN']
|
| | | |
| | | |
| | | |
| | | | |
actions.rb:34: warning: instance variable @in_group not initialized
|
| | | | |
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These warnings were actually a bug in Ruby 2.0, the accessors should not
be raising such warnings, they are only meant for ivars.
-
Revert "fix warnings in Ruby 2.0"
This reverts commit 26702a6d3461f4a1c75165030b96886514ecb877.
-
Revert "Merge pull request #8282 from arunagw/warning_removed_for_ruby2"
This reverts commit f63d6544e45e78cda29c0c56fbdf3d9e1f405340, reversing
changes made to 3a890681fad8218305585036abed6d7463a44e41.
|
| | | |
|
| | |
| | |
| | |
| | | |
Executable scripts are versioned code like the rest of your app. To generate a stub for a bundled gem: 'bundle binstubs unicorn' and 'git add bin/unicorn'
|
|\ \ \
| | | |
| | | | |
refactor the naming within plugin new generator
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Having a method called `full?`, which checks on :full and :mountable
is very confusing. I renamed `full?` to `engine?` and created a `full?`
method that only checks the `:full` option
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Avoid swallowing all exceptions that might happen when requiring
debugger, just catch a LoadError if it cannot be loaded.
Check for more background:
https://github.com/rails/rails/commit/28fd867c9bc790636d37a28f288791cd0089a6fd#commitcomment-2386952
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It feels more consistent to have this class called "HtmlTableFormatter",
and to have it here with the routes inspector and console formatter,
since it's used for both routing error exceptions and the rails info
page.
|
|\ \ \ \
| | | | |
| | | | | |
Delegate to :class rather than 'self.class'
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
should read more about the consequences than just toggling a boolean to make best use of it
|
| | | | |
| | | | |
| | | | |
| | | | | |
config/initializers to take effect
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* a controller that destroying Weblogs might be WeblogsController
* a controller that indexing Posts might be PostsController
* Post.all returns a Relation
* modernize Model.inspect results
|
| | | | | |
|
|/ / / / |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This is very rarely changed and does not deserve to be in application.rb
|