| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| |/
|/| |
modify to `error` also abort when specify fail fast option
|
| | |
|
|/
|
|
| |
`app_templates_dir` is unused since dc53fe9.
|
| |
|
|\
| |
| | |
generate mailer views in Rails API
|
| |
| |
| |
| |
| | |
View files is necessary to send mail, it should be generated even Rails API.
Fixes #23617
|
| |
| |
| |
| |
| | |
This is a follow-up to ea70c29 to bring back the assertion error
location information provided by minitest.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 0db310586ac3e15be95d2ef27ff40cfa24c05c10.
Closes #23686.
Conflicts:
railties/test/application/test_runner_test.rb
It's possible that the `result.location` returned by minitest is outside
the test file itself. For example in the case of mocha. This resulted in
bad rerun snipptets:
```
bin/rails test app/models/deliveries/delivery.rb:103
```
Let's always use the first line of the failed test-case in our rerun
snippet. We can display the line number of the assertion error elsewhere.
|
|\ \
| | |
| | | |
mark as #:nodoc: [ci skip]
|
| | |
| | |
| | | |
can’t be instantiate directly or may be no need for doc.
|
|\ \ \
| |/ /
|/| | |
remove `active_support.test_order` from environment file
|
| | |
| | |
| | |
| | |
| | | |
The default test order has been changed to `:random` in 5f777e4b5ee2e3e8e6fd0e2a208ec2a4d25a960d.
Therefore, it is no more need to be specified in the environment file.
|
|\ \ \
| |/ /
|/| | |
Inject Rails related configuration through Railtie
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize,
thereby coupling ourselves to Rails.
Instead add `app/channels` to Rails' app paths and assign the existent files
to `channel_paths`.
Users can still append to those load paths with `<<` and `push` in `config/application.rb`.
This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails
and root definitions in the tests.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
s/config\/production/config\/environments\/production/
[ci skip]
|
| |/
|/|
| |
| |
| |
| | |
- Fixed related documentation and usage all around
Fixes #23561
|
|\ \
| | |
| | | |
Set database poolsize via rails_max_threads
|
| |/ |
|
|\ \
| | |
| | | |
set association name to generated fixtures if attribute is reference
|
| |/
| |
| |
| |
| |
| |
| | |
It has been changed to require `belongs_to` by default in Rails 5.
Therefore in order to pass the controller test, have association of set to fixtures.
Fixes #23384
|
| | |
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
| |
Previous commit accidentally broke mixing line filters with string -n filter.
Fix by checking if it is a string and returning it.
We also need to ensure the -n filter carry forward into any other composite filters.
Fix by letting the named filter be extractable, so we'll keep this for the next runnable's
run.
|
|
|
|
|
|
|
|
| |
on sprockets environment
- Remove jquery-rails if --skip-sprockets is true
Fixes #23431
|
|\
| |
| | |
Pass api only option to rails rails:update task to update only based on api Apps
|
| |
| |
| |
| | |
Fixes #23470
|
| |
| |
| |
| | |
All grown up and shit!
|
| |
| |
| |
| | |
So no need to have it on by default in the Gemfile.
|
| |
| |
| |
| | |
So it can properly show stats for an app with 1,000,000+ LOC
|
| |
| |
| |
| |
| |
| | |
This reverts commit 293bd95c3e77275193130bc14c986348aae8b0e2.
This broke the header :<
|
|\ \
| | |
| | | |
Active Record supports MySQL >= 5.0
|
| | |
| | |
| | |
| | |
| | | |
Currently some features uses `information_schema` (e.g. foreign key
support). `information_schema` introduced since MySQL 5.0.
|
|\ \ \
| |/ /
|/| | |
Fix line filters running tests from multiple runnables.
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`derive_regexp` was written with the assumption that we were run from a
blank slate — that if the filter didn't match we might as well return it
because it was nil.
This isn't the case because minitest calls `run` on every runnable. Which
is any subclass of Minitest::Runnable, such as ActiveSupport::TestCase,
ActionDispatch::IntegrationTest as well as any inheriting from those.
Thus after the first `run` we'd have put in a composite filter in
`options[:filter]` making the next `run` create a linked list when it
failed to match the regexp and put the composite filter as the head.
Every runnable would accumulate more and more of the same filters,
which effectively acted like an expanding whitelist and we ran tests
from other runnables.
Clog the accumulation by returning nil if there's no filter to derive
a regexp from.
Note: we pass a seed in the tests because Minitest shuffles the runnables
to ensure the whitelist is expanded enough that the failure is triggered.
|
|/
|
|
|
|
|
|
| |
Previously Safari would try to load these files when you visit
localhost:3000. That created two exceptions in the log. It also caused
the exception notifier to send them out.
In response to #23427
|
|\
| |
| | |
update supported version of PostgreSQL in docs [ci skip]
|
| |
| |
| |
| | |
Follow up to #23434
|
|/
|
|
|
| |
For other task has become to use the rails command at doc and test,
I think that routes task also it is better to use the rails command.
|
|
|
|
|
|
| |
Generated engines should call `protect_from_forgery`. If this method
isn't called, then the Engine could be susceptible to XSS attacks.
Thanks @tomekr for reporting this to us!
|
| |
|
| |
|
|
|
|
|
|
| |
Solves personal insanity, since I was down in these files.
(Please don't submit PRs like this.)
|
|\
| |
| | |
Add options for rake routes task
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add two options: `-c` and `-g`.
`-g` option returns the urls name, verb and path fields that match the pattern.
`-c` option returns the urls for specific controller.
Fixes #18902, and Fixes #20420
[Anton Davydov & Vipul A M]
|
|\ \
| |/
|/| |
Address remaining known issues in Interlock
|
| |
| |
| |
| |
| |
| | |
We mostly care about `reload_classes_only_on_change=true`, because
that's the default... and there, we definitely need to wait for the lock
when necessary.
|
|\ \
| | |
| | | |
Add Default Puma Config
|