aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib
Commit message (Collapse)AuthorAgeFilesLines
* Only output Server logs in Developmentschneems2013-09-221-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now when you start a server via `rails s`, the logger gets extended so that it logs to the file system and also to stdout. This extension behavior is not "intelligent" and if the default logger is already set to output to stdout, then the contents will be received twice. To capture logs in accordance with http://www.12factor.net/logs some platforms require the logs to be sent to standard out. If a logger is set to stdout, and the server is started using `rails server` instead of another method (i.e. `thin start` etc.) then the app will produce double logs. This PR fixes the issue by only extending the logger to standard out in the development environment. So that in production you don't get double logs like this: ``` ActionView::Template::Error (wrong number of arguments (5 for 4)): 1: <% lang_index = 0 %> 2: <div class="row"> 3: <ul class="nav nav-tabs nav-stacked span2" data-tabs="tabs" id="repo-tabs"> 4: <% repos.group_by(&:language).each do |lang, repos| %> 5: <% unless lang == nil %> 6: <li><a href="#<%= "#{lang.parameterize}#{lang.hash}" %>" data-toggle="tab"><%= lang %></a></li> 7: <% end -%> app/views/shared/_repos.html.erb:4:in `_app_views_shared__repos_html_erb___1685450633638247395_70300668607000' app/views/pages/index.html.erb:13:in `_app_views_pages_index_html_erb__2084723628308867770_70300687584880' ActionView::Template::Error (wrong number of arguments (5 for 4)): 1: <% lang_index = 0 %> 2: <div class="row"> 3: <ul class="nav nav-tabs nav-stacked span2" data-tabs="tabs" id="repo-tabs"> 4: <% repos.group_by(&:language).each do |lang, repos| %> 5: <% unless lang == nil %> 6: <li><a href="#<%= "#{lang.parameterize}#{lang.hash}" %>" data-toggle="tab"><%= lang %></a></li> 7: <% end -%> app/views/shared/_repos.html.erb:4:in `_app_views_shared__repos_html_erb___1685450633638247395_70300668607000' app/views/pages/index.html.erb:13:in `_app_views_pages_index_html_erb__2084723628308867770_70300687584880' ``` ATP Railties. Opened against master in favor of #10999
* Don't require using application_name before optionsPiotr Sarnacki2013-09-133-12/+12
| | | | | | | | | | | | Before this commit options for `rails new` and `rails plugin new` had to be passed in a strict order, trying to execute a following command: rails new -J path/to/app resulted in an error. This commit fixes the situation and allows to pass path to app anywhere after `new`
* Merge pull request #12216 from suginoy/a-anRafael Mendonça França2013-09-131-1/+1
|\ | | | | Fix typos: the indefinite articles(a -> an).
| * Fix typos: the indefinite articles(a -> an)SUGINO Yasuhiro2013-09-131-1/+1
| |
* | Missing destroy commandAkira Matsuda & Yukiko Kawamoto2013-09-131-0/+4
| |
* | Revert "Add meta tag with charset information to application layout."Aaron Patterson2013-09-111-1/+0
| | | | | | | | This reverts commit ba0407337e93c4ef55cef3472143f62e8a984a64.
* | Add meta tag with charset information to application layout.Steve Klabnik2013-09-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, our default HTML would validate properly, but would generate a warning: it doesn't declare a character encoding. According to [the spec][encoding-spec], if you don't specify an encoding, a 7 step algorithm happens, with a toooon of sub-steps. Or, we could just actually specify it. Since everything else in Rails assumes UTF-8, we should make sure pages are served with that encoding too. This meta tag is the simplest way to accomplish this. More resources: * http://blog.whatwg.org/the-road-to-html-5-character-encoding * http://www.w3.org/International/tutorials/tutorial-char-enc/ * http://validator.w3.org/ [encoding-spec]: http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#determining-the-character-encoding
* | Use Ruby 2.0 caller_locations instead of caller if availableAkira Matsuda2013-09-101-2/+7
| | | | | | | | | | | | | | | | | | * we no more have to manipulate the each caller strings by ourselves using caller_locations * caller_locations runs slightly faster, and creates less objects than good old caller Benchmark (loading an Engine 1000 times): caller: 262.89 ms caller_locations: 186.068 ms
* | grab executable from rubygemsArun Agrawal2013-09-091-1/+1
| |
* | Fixed API task fileArun Agrawal2013-09-091-7/+5
|/ | | | | | 1. As we have vendor in AV only 2. No more vendor in AC 3. No vendor folder in AR
* Merge pull request #12097 from kassio/remove-unused-delegate-on-railtieJosé Valim2013-08-311-2/+0
|\ | | | | Remove unused delegate
| * Remove unused delegateKassio Borges2013-08-311-2/+0
| | | | | | | | Related with commit 4a2a504
* | Merge pull request #11912 from jonkessler/respond-to-signature-fixesRafael Mendonça França2013-08-311-1/+1
|\ \ | |/ |/| Update Rails::Railtie::Configuration and ActionDispatch::Response#respond_to? to accept include_private argument
| * update Rails::Railtie::Configuration and ↵Jon Kessler2013-08-161-1/+1
| | | | | | | | ActionDispatch::Response#respond_to? to accept include_private argument
* | Using indent method to refactor controller generator.wangjohn2013-08-311-3/+3
| | | | | | | | [John J. Wang & Prathamesh Sonpatki]
* | Refactoring Generators::Base.wangjohn2013-08-281-14/+17
| | | | | | | | | | | | | | The defaults hash isn't used unless the +class_options+ hash has a particular key, so we don't need to compute it unless this is true. Also moving some code for extracting a module into its own method.
* | Comply with current umask when generating new app:Thibault Jouan2013-08-271-1/+1
| | | | | | | | | | | | | | | | | | | | When creating a new application using the default rails generator (`rails new my_app`), it will apply some permissions bypassing the current process umask. The `bin' directory and any files inside it will always be set a mode of 0755. This change removes the current umask bits from the mode applied by the generator on the `bin' directory and its content.
* | Add --skip-action-view to app generatorŁukasz Strzałkowski2013-08-253-2/+6
| |
* | Include AV railtie when we're not loading full rails stackŁukasz Strzałkowski2013-08-251-0/+1
| |
* | Add loading 'action_view' as part of rails/allŁukasz Strzałkowski2013-08-251-0/+1
| |
* | Fix typo in file path, should include extension.Semyon Perepelitsa2013-08-231-1/+1
| |
* | Fix the indentation on the from template of the scaffold generatorRafael Mendonça França2013-08-191-3/+3
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-08-173-13/+10
|\ \ | |/ |/| | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md
| * Revert "Merge branch 'master' of github.com:rails/docrails"Vijay Dev2013-08-173-13/+10
| | | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake.
| * Revert "Removing obsolete html tags in favor of markdown code block"Avner Cohen2013-08-062-51/+51
| | | | | | | | This reverts commit 157dc275da0ad38635337b7c1d96de656d91de8e.
| * Removing obsolete html tags in favor of markdown code block.Avner Cohen2013-08-062-51/+51
| |
* | Adding LESS to rake notesJosh Crowder2013-08-151-1/+1
| |
* | Generate namespaced routes correctly for generators. Fix for #11532Prathamesh Sonpatki2013-08-141-1/+35
| |
* | "Naked" rescue clauses only catch StandardError subclasses.thedarkone2013-08-061-1/+1
| | | | | | | | Similar to #11497.
* | Use the right instrumentation nameRafael Mendonça França2013-08-051-2/+2
| | | | | | | | | | | | | | | | | | The pattern is event.component Closes #11769 Conflicts: railties/CHANGELOG.md
* | Merge pull request #11665 from mshytikov/fix-config-log_levelRafael Mendonça França2013-08-041-1/+2
|\ \ | | | | | | Rails.logger should have level specified by config.log_level.
| * | Rails.logger should have level specified by config.log_level. Max Shytikov2013-07-301-1/+2
| | | | | | | | | Fix bug when log level of Rails.logger (which was set via config.logger) does not match the config.log_level.
* | | Added action_view in Rails::InfoArun Agrawal2013-08-021-1/+1
| | |
* | | Merge pull request #11601 from TylerRick/dont_permanently_silence_all_warningsRafael Mendonça França2013-07-301-2/+0
|\ \ \ | |/ / |/| | Remove $VERBOSE = nil from tasks.rb
| * | Remove $VERBOSE = nil from tasks.rbTyler Rick2013-07-251-2/+0
| | | | | | | | | | | | | | | | | | Permanently setting $VERBOSE to nil causes unwanted side effects (warnings generated by app code are silenced when triggered by a rake task but visible otherwise). silence_warnings {} would be safer to use here since it resets $VERBOSE back to what it was when the block finishes.
* | | Changed stylesheet load order in the stylesheet manifest generator.Pawel Janiak2013-07-282-6/+10
| |/ |/|
* | Removed excluding vendor from API doc [ci skip]Arun Agrawal2013-07-261-6/+3
| | | | | | | | These folder not exists in system
* | Excluding action_view/vendor in API [ci skip]Arun Agrawal2013-07-261-1/+2
|/
* grab executable from rubygemsAaron Patterson2013-07-251-1/+1
|
* Use Ruby 2.0 caller_locations instead of caller if availableAkira Matsuda2013-07-251-2/+7
| | | | | | | | | * we no more have to manipulate the each caller strings by ourselves using caller_locations * caller_locations runs slightly faster, and creates less objects than good old caller Benchmark (loading an Engine 1000 times): caller: 262.89 ms caller_locations: 186.068 ms
* Use GeneratedAttribute#column_name if #reference? scaffold_generator in ↵Zachary Scott2013-07-231-0/+5
| | | | _form view [Fixes #11573]
* Revert "Match Dev/Prod parity for Index Page"Piotr Sarnacki2013-07-222-4/+2
| | | | | | | | Showing welcome page in production can expose information, which should not be visible on production if people don't override the default root route. This reverts commit b0caea29c2da9f4c8bb958019813482da297067d.
* Merge pull request #11514 from schneems/schneems/dev-prod-parity-indexPiotr Sarnacki2013-07-222-2/+4
|\ | | | | Match Dev/Prod parity for Index Page
| * Match Dev/Prod parity for Index Pageschneems2013-07-202-2/+4
| | | | | | | | | | | | | | With Rails 4 the default index page was moved from a static file `index.html` inside the `public/` folder to an internal controller/view inside of the railties gem. This was to allow use of erb in the default index page and to remove the requirement that new apps must delete a static file to make their index pages work. While this was a good change, the functionality was unexpected to developers who wish to get their apps running in production ASAP. They will create a new app `rails new my app`, start a server to verify it works, then immediately deploy the app to verify that it can start working in production. Unfortunately locally they see a page when they visit `localhost:3000` when they visit their production app they get an error page. We initially anticipated this problem in the original pull request, but did not properly anticipate the severity or quantity of people who would like this functionality. Having a default index page serves as an excellent litmus test for a passed deploy on default apps, and it is very unexpected to have a page work locally, but not on production. This change makes the default index page available in production if the developer has not over-written it by defining their own `root` path inside of routes.
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-07-211-0/+6
|\ \
| * | use the appropriate RDoc code markupDamien Mathieu2013-07-181-2/+2
| | | | | | | | | | | | Thanks @fxn
| * | document the Rails::ConsoleMethods#helper and #controller methodsDamien Mathieu2013-07-181-0/+6
| | | | | | | | | | | | Closes rails/rails#11362
* | | Removed information about creating database[ci skip]Prathamesh Sonpatki2013-07-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - As default index page is no longer in public folder, rails hits the welcome controller in railties for index action - If the database is not created or username and password are incorrect in database.yml, those errors are first shown before index action succeeds - welcome#index succeeds iff the database is created with correct details in database.yml - So this information about creating database is not required in the index template
* | | bcrypt-ruby stable is 3.1Burkhard Vogel-Kreykenbohm2013-07-171-1/+1
| |/ |/|
* | Fixed USAGE file for generator [ci skip]Arun Agrawal2013-07-161-1/+1
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 17:28:26 +0000