aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Preparing for 6.0.0.beta2 releaseRafael Mendonça França2019-02-251-1/+1
| | | |
* | | | Depend on bootsnap 1.4.1Rafael Mendonça França2019-02-251-1/+1
| | | | | | | | | | | | | | | | This is needed to fix #35278.
* | | | simplifies Rails.autoloaders.logger=Xavier Noria2019-02-211-2/+1
| | | | | | | | | | | | | | | | Possible thanks to Zeitwerk 1.3.0.
* | | | Define Rails.autoloaders.logger=Xavier Noria2019-02-211-0/+5
| | | |
* | | | Explains a detail re eager loading [ci skip]Xavier Noria2019-02-201-0/+3
| | | |
* | | | Auto correct rubocop offensesYoshiyuki Hirano2019-02-171-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Offenses: railties/lib/rails/autoloaders.rb:1:1: C: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Rails ^ actionmailer/test/base_test.rb:917:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. actionmailer/test/base_test.rb:917:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. actionmailer/test/base_test.rb:917:5: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ actionmailer/test/base_test.rb:918:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. events = [] ^^^^ actionmailer/test/base_test.rb:930:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. actionmailer/test/base_test.rb:930:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
* | | | Replace autoloader accessors with Rails.autoloaders.{main,once}Xavier Noria2019-02-143-18/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails.autoloader and Rails.once_autoloader was just tentative API good enough for a first patch. Rails.autoloader is singular and does not convey in its name that there is another autoloader. That might be confusing, for example if you set a logger and miss traces. On the other hand, the name `once_autoloader` is very close to being horrible. Rails.autoloaders.main and Rails.autoloaders.once read better for my taste, and have a nice symmetry. Also, both "main" and "once" are four letters long, short and same length. They are tagged as "rails.main" and "rails.once", respectively. References #35235.
* | | | Merge pull request #35249 from Edouard-chin/ec-config-for-hash-in-arrauRafael Mendonça França2019-02-141-4/+18
|\ \ \ \ | | | | | | | | | | | | | | | Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:
| * | | | Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:Edouard CHIN2019-02-141-4/+18
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If you have hashes inside array, the hashes were getting initialized as regular HWIA wereas we want them to be NonSymbolAccessDeprecatedHash in order to trigger a deprecation warning when keys are accessed with string. This patch fixes that by overwriting the `[]=` to to the same as what HWIA does (with the difference that we don't call `convert_key` to not trigger a deprecation when setting value). I also took the liberty to extract `hash.nested_under_indifferent_access`, into a separate method to allow subclasses to return whatever they want. Inheriting HWIA is not common, but I think it's useful for cases like this one where we want to preprocess reading and writing values in the hash (for deprecation purposes or other reasons).
* / / / Let Zeitwerk be a dependency of Active SupportXavier Noria2019-02-132-4/+6
|/ / / | | | | | | | | | | | | Zeitwerk is a strong dependency, planned to replace AS::Dependencies. A line in the generated Gemfile does not convey this as much.
* | | Zeitwerk integrationXavier Noria2019-02-125-9/+64
| | |
* | | Merge pull request #35198 from paracycle/uk-change-config-for-behaviourGannon McGibbon2019-02-111-2/+36
|\ \ \ | | | | | | | | Allow deprecated non-symbol access to nested `config_for` hashes
| * | | Allow deprecated non-symbol access to nested `config_for` hashesUfuk Kayserilioglu2019-02-111-2/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A change to `Rails::Application.config_for` in https://github.com/rails/rails/pull/33815 and https://github.com/rails/rails/pull/33882 has altered the behaviour of the returned object in a breaking manner. Before that change, nested hashes returned from `config_for` could be accessed using non-symbol keys. After the change, all keys are recursively symbolized so non-symbol access fails to read the expected values. This is a breaking change for any app that might be relying on the nested hashes returned from `config_for` calls, and thus should be deprecated before being removed from the codebase. This commit introduces a temporary `NonSymbolAccessDeprecatedHash` class that recursively wraps any nested hashes inside the `OrderedOptions` object returned from `config_for` and issues a deprecation notice when a non-symbol based access is performed. This way, apps that are still relying on the ability to access these nested hashes using non-symbol keys will be able to observe the deprecation notices and have time to implement changes before non-symbol access is removed for good. A CHANGELOG entry is also added to note that non-symbol access to nested `config_for` hashes is deprecated.
* | | | Optimized namespaces_to_paths method.alkesh262019-02-111-2/+3
|/ / /
* | | Rename database_operations config to *_contextJohn Hawthorn2019-02-071-4/+5
| | |
* | | Remove finalizer and configurationAaron Patterson2019-02-061-3/+0
| | |
* | | Set sqlite3 gem version explicitly in generated GemfileSergey Ponomarev2019-02-051-0/+1
| | |
* | | Merge pull request #35126 from alkesh26/railities-typo-fixEileen M. Uchitelle2019-02-012-2/+2
|\ \ \ | | | | | | | | Railties typo fixes.
| * | | Railities typo fixes.alkesh262019-02-012-2/+2
| | | |
* | | | Enable `Lint/ErbNewArguments` cop to avoid the deprecated arguments warningRyuta Kamizono2019-02-011-2/+1
|/ / / | | | | | | | | | | | | | | | Related 5754a29a974d31cab2b4392716b9825a3d910a69. And follows Ruby standard library style https://github.com/ruby/ruby/commit/3406c5d.
* | | Merge pull request #34980 from y-yagi/fixes_34979Yuji Yaginuma2019-01-311-2/+4
|\ \ \ | | | | | | | | Don't add `RAILS_ENV` in generate action
| * | | Don't add `RAILS_ENV` in generate actionyuuji.yaginuma2019-01-191-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In the case of generator, `RAILS_ENV` is interpreted as an argument as it is. Avoid this because it will result unintended by the user. Fixes #34979.
* | | | Adds basic automatic database switching to RailsEileen Uchitelle2019-01-301-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following PR adds behavior to Rails to allow an application to automatically switch it's connection from the primary to the replica. A request will be sent to the replica if: * The request is a read request (`GET` or `HEAD`) * AND It's been 2 seconds since the last write to the database (because we don't want to send a user to a replica if the write hasn't made it to the replica yet) A request will be sent to the primary if: * It's not a GET/HEAD request (ie is a POST, PATCH, etc) * Has been less than 2 seconds since the last write to the database The implementation that decides when to switch reads (the 2 seconds) is "safe" to use in production but not recommended without adequate testing with your infrastructure. At GitHub in addition to the a 5 second delay we have a curcuit breaker that checks the replication delay and will send the query to a replica before the 5 seconds has passed. This is specific to our application and therefore not something Rails should be doing for you. You'll need to test and implement more robust handling of when to switch based on your infrastructure. The auto switcher in Rails is meant to be a basic implementation / API that acts as a guide for how to implement autoswitching. The impementation here is meant to be strict enough that you know how to implement your own resolver and operations classes but flexible enough that we're not telling you how to do it. The middleware is not included automatically and can be installed in your application with the classes you want to use for the resolver and operations passed in. If you don't pass any classes into the middleware the Rails default Resolver and Session classes will be used. The Resolver decides what parameters define when to switch, Operations sets timestamps for the Resolver to read from. For example you may want to use cookies instead of a session so you'd implement a Resolver::Cookies class and pass that into the middleware via configuration options. ``` config.active_record.database_selector = { delay: 2.seconds } config.active_record.database_resolver = MyResolver config.active_record.database_operations = MyResolver::MyCookies ``` Your classes can inherit from the existing classes and reimplment the methods (or implement more methods) that you need to do the switching. You only need to implement methods that you want to change. For example if you wanted to set the session token for the last read from a replica you would reimplement the `read_from_replica` method in your resolver class and implement a method that updates a new timestamp in your operations class.
* | | | Convert path to string before call `length`yuuji.yaginuma2019-01-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because eager load paths support to using `Pathname`, and `Pathname` doesn't have `length` method. Ref: https://travis-ci.org/rails/rails/jobs/485088071#L5140-L5143 Follow up aadeed1518b9092ea21adf49c728172368129f0e.
* | | | Simplify path prefix extractionXavier Noria2019-01-271-2/+3
| | | |
* | | | Fix typo: overriden -> overridden [ci skip] (#35060)Vipul A M2019-01-261-1/+1
| | | |
* | | | Merge pull request #34789 from christos/fix-editing-new-environment-credentialsKasper Timm Hansen2019-01-252-2/+12
|\ \ \ \ | | | | | | | | | | Don't load app environment when editing credentials
| * | | | Don't load app environment when editing credentialsChristos Zisopoulos2018-12-262-2/+12
| | | | | | | | | | | | | | | | | | | | This avoids missing key exceptions caused by code that tries to read the credentials before they have been added to the encrypted file, for example when editing the credentials for a new environment.
* | | | | Fix deeply nested namespace command printingGannon McGibbon2019-01-241-3/+11
| | | | |
* | | | | Merge pull request #34993 from schuetzm/allow-subdomains-of-localhostRafael França2019-01-231-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Subdomains of localhost are safe against DNS rebinding
| * | | | | Subdomains of localhost are safe against DNS rebindingMarc Schütz2019-01-231-1/+1
| | |/ / / | |/| | |
* | | | | Merge pull request #34997 from alkesh26/typo-fix-webserverEileen M. Uchitelle2019-01-222-3/+3
|\ \ \ \ \ | | | | | | | | | | | | Replaced webserver with web server
| * | | | | Changed webserver to web server.alkesh262019-01-222-3/+3
| |/ / / /
* | | | | Add Channel tests to `rails stats`bogdanvlviv2019-01-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails generates `test/channels`(#34933) and even allows `rails test:channels` (#34947). `rails stats` has been providing info about `app/channels`, it makes sense to add `test/channels` as well. (I've changed test because we generate `test/channels` with some code)
* | | | | Report statistics from ActionMailboxDan McGregor2019-01-201-0/+2
|/ / / /
* | | | Preparing for 6.0.0.beta1 releaseRafael Mendonça França2019-01-181-1/+1
| | | |
* | | | Revert "Remove deprecated `server` argument from the rails server command"yuuji.yaginuma2019-01-181-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fa791fb8e2a718b5d0430c7ca5a454678dfc192d. Reason: `server` argument was deprecated in Rails 6.0. Ref: #32058.
* | | | Use released webpackerRafael Mendonça França2019-01-171-1/+1
| | | |
* | | | Remove deprecated `after_bundle` helper inside plugins templatesRafael Mendonça França2019-01-173-21/+12
| | | |
* | | | Remove deprecated `server` argument from the rails server commandRafael Mendonça França2019-01-171-21/+2
| | | |
* | | | Remove deprecated support to old `config.ru` that use the application class ↵Rafael Mendonça França2019-01-171-13/+0
| | | | | | | | | | | | | | | | as argument of `run`
* | | | Remove deprecated `environment` argument from the rails commandsRafael Mendonça França2019-01-171-11/+1
| | | |
* | | | Remove deprecated `capify!`Rafael Mendonça França2019-01-171-9/+0
| | | |
* | | | Remove deprecated `config.secret_token`Rafael Mendonça França2019-01-172-20/+5
| | | |
* | | | Change `SQLite3Adapter` to always represent boolean values as integersRafael Mendonça França2019-01-171-4/+0
| |/ / |/| |
* | | Merge pull request #34953 from gmcgibbon/seed_with_inline_jobsRafael França2019-01-171-1/+13
|\ \ \ | | | | | | | | Seed database with inline ActiveJob job adapter
| * | | Seed database with inline ActiveJob job adapterGannon McGibbon2019-01-171-1/+13
| | | |
* | | | Merge pull request #33419 from bogdanvlviv/update-active_storageGeorge Claghorn2019-01-162-1/+12
|\ \ \ \ | | | | | | | | | | `rake app:update` should update active_storage
| * | | | Add foreign key to active_storage_attachments for `blob_id` via new migrationbogdanvlviv2019-01-162-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need this in order to be able to add this migration for users that use ActiveStorage during update their apps from Rails 5.2 to Rails 6.0. Related to #33405 `rake app:update` should update active_storage `rake app:update` should execute `rake active_storage:update` if it is used in the app that is being updated. It will add new active_storage's migrations to users' apps during update Rails. Context https://github.com/rails/rails/pull/33405#discussion_r204239399 Also, see a related discussion in the Campfire: https://3.basecamp.com/3076981/buckets/24956/chats/12416418@1236713081
* | | | | Add a space in framework names. Matches Active Record in generated Gemfile.Kasper Timm Hansen2019-01-161-2/+2
| |_|_|/ |/| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 22:15:42 +0000