aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib
Commit message (Collapse)AuthorAgeFilesLines
* Make `ActionDispatch::Response#content_type` behavior configurableyuuji.yaginuma2019-06-212-0/+4
| | | | | | | | | I changed return value of `ActionDispatch::Response#content_type` in #36034. But this change seems to an obstacle to upgrading. https://github.com/rails/rails/pull/36034#issuecomment-498795893 Therefore, I restored the behavior of `ActionDispatch::Response#content_type` to 5.2 and deprecated old behavior. Also, made it possible to control the behavior with the config.
* Allow using env var to specify pidfileBen Thorner2019-06-191-5/+6
| | | | | | | | | | | | | | | | Previously it was only possible to specify the location of the pidfile for the 'rails server' command with the '-P' flag. This adds support for specifying the pidfile using a PIDFILE env var, which can still be overridden by the '-P' flag and with the default pidfile path unchanged. The motivation for this feature comes from using Docker to run multiple instances of the same rails app. When developing a rails app with Docker, it's common to bind-mount the rails root directory in the running container, so that changes to files are shared between the container and the host. However, this doesn't work so well with the pidfile and it's necessary to (remember to) add a '-P' flag to the 'rails server' command line; being able to specify this flag using an env var would make developing with Rails+Docker a bit simpler.
* Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-1330-36/+0
| | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Remove redundant blank line at the bottom of the generated controller testyuuji.yaginuma2019-06-071-1/+1
|
* Extract default log file open operation to methodyuuji.yaginuma2019-06-052-10/+14
| | | | | | This allows customize a default log file(e.g. `reopen`) by an application. Fixes #32211.
* Fix rubocop violationyuuji.yaginuma2019-06-051-2/+1
|
* Merge pull request #36395 from cpruitt/6-0-stableEileen M. Uchitelle2019-06-041-3/+9
| | | Do not clear deprecated initializer dependencies if using classic autoloader
* Bring `after_bundle` back to API document [ci skip]yuuji.yaginuma2019-05-291-1/+6
| | | | | At class level `:nodoc:` all elements are prevented. Instead, use `:stopdoc:` / `:startdoc:` to make `after_bundle` appear.
* Skip needless spaces from generated app layout.Kasper Timm Hansen2019-05-261-1/+1
|
* Bump Gemfile entry jbuilder versionAnton Rieder2019-05-231-1/+1
| | | | | | | | | | jbuilder 2.6.4 is the first version that relaxes the version constraint to allow Rails 6. I also did some more tests in #25183, although not with 2.6.4 explicitly. To simplify the version requirement, I went for 2.7. https://github.com/rails/jbuilder/blob/v2.6.4/jbuilder.gemspec https://github.com/rails/rails/issues/25183#issuecomment-494342406
* Fix: DummyCompiler embeds invalid YAML contentVishal Telangre2019-05-151-8/+2
| | | | | | Fixes https://github.com/rails/rails/issues/36285. Follow up of https://github.com/rails/rails/pull/36237.
* Merge pull request #36237 from eileencodes/fix-erb-in-database-yaml-againEileen M. Uchitelle2019-05-141-1/+6
|\ | | | | Fix database loading when ERB is single line ternary
| * Fix database loading when ERB is single line ternaryeileencodes2019-05-101-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | *sigh* this seems like the never ending bug. I don't love or even like this fix but it does _work_. Rafael suggested using `dummy_key: dummy_value` but unfortunately that doesn't work. So we're left with checking whethere there might be ternary type things in the content and then assuming that we want to replace the line with a key value pair. Technically fixes https://github.com/rails/rails/issues/36088
* | Add ActionDispatch::SystemTestCase#fill_in_rich_text_areaGeorge Claghorn2019-05-131-1/+1
| |
* | adds a blank line [ci skip]Xavier Noria2019-05-131-0/+1
| |
* | warn about non-eager loaded dirs in zeitwerk:checkXavier Noria2019-05-131-19/+53
| |
* | Update the sqlite db yaml template to match others and mention proper ↵Vipul A M2019-05-122-2/+2
| | | | | | | | supported version
* | Merge pull request #36225 from ↵Yuji Yaginuma2019-05-091-1/+1
|\ \ | | | | | | | | | | | | deivid-rodriguez/workaround_sass_rails_requirement Use a better requirement for sass-rails 6 prereleases
| * | Use a better requirement for sass-rails 6 prereleasesDavid Rodríguez2019-05-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This is the behavior I naively expect for the operator when used with a single digit, but it's definitely an edge case for it, and it doesn't seem to work as expected for including prereleases. Using >= works fine and make the intention more clear anyways.
* | | Fix indentation of the config.eager_load nil warningSharang Dashputre2019-05-091-1/+1
|/ /
* / Fix indentation for config.eager_load nil warning messageAbhay Nikam2019-05-081-5/+5
|/
* Make generated test work even when using virtual attributesyuuji.yaginuma2019-05-054-7/+17
| | | | | | | | | The virtual attributes(`attachment` and `rich_text`) can't set value with `fill_in`. So avoid using it. Once #35885 is merged, will be modified to use it. Also, add checking attachment attached or not for avoiding `DelegationError` when attachment didn't attach.
* Fix rubocop offencesRyuta Kamizono2019-04-301-1/+1
|
* new config to opt-out from adding app directories to $LOAD_PATHXavier Noria2019-04-282-6/+10
|
* Bump bootsnap to a version with disables iseq_cache for Ruby 2.5Prathamesh Sonpatki2019-04-261-1/+1
| | | | - Refs https://github.com/Shopify/bootsnap/pull/257
* Start Rails 6.1 developmentRafael Mendonça França2019-04-242-2/+4
|
* Merge pull request #36067 from st0012/update-generator-for-api-appRafael França2019-04-232-0/+4
|\ | | | | Remove action_controller.perform_caching from api app's configs
| * Remove action_controller.perform_caching from api app's configsst00122019-04-242-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | As suggested in https://github.com/rails/rails/issues/35602#issuecomment-485833483, because we don't provide view caching and doesn't include `ActionController::Caching` for api apps, we should also avoid generating ```ruby config.action_controller.perform_caching = true ``` for those api apps. So it won't confuse people. **But because `perform_caching` will be `true` if not set, the behavior of the app would still be the same without these configs.**
* | Merge pull request #35852 from larouxn/resurrectionRafael França2019-04-232-0/+9
|\ \ | |/ |/| Resurrect external JS/CS generation
| * Burn unnecessary files 🔥Nicholas La Roux2019-04-053-19/+0
| |
| * Style fixesNicholas La Roux2019-04-051-3/+3
| |
| * Resurrect generator templatesNicholas La Roux2019-04-052-0/+4
| |
| * Resurrect js/js engine options and generatorsNicholas La Roux2019-04-053-0/+24
| |
* | Implements the task zeitwerk:checkXavier Noria2019-04-232-0/+79
| | | | | | | | [Matilda Smeds & Xavier Noria]
* | Allow sass-rails greater than 5.x in new appsGuillermo Iguaran2019-04-221-1/+1
| |
* | [#35782] Allow loading seeds without ActiveJob (~> 5.2.3)Jeremy Weathers2019-04-191-1/+1
| |
* | Add `null: false` constraint by default for `belongs_to` associationsPrathamesh Sonpatki2019-04-191-2/+8
| | | | | | | | | | | | - Also deprecate passing {required} to the model generator. - Also made sure the global config `belongs_to_required_by_default` is applied correctly to the model generator for `null: false` option.
* | Merge pull request #34788 from gsamokovarov/actionable-errorsKasper Timm Hansen2019-04-191-0/+1
|\ \ | | | | | | Introduce Actionable Errors
| * | Manage ActionDispatch::ActionableExceptions from the default middleware stackGenadi Samokovarov2019-04-191-0/+1
| | |
* | | Help command for visible commands should be hiddenakinomaeni2019-04-191-2/+4
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` $ rails --help > tmp/before $ bundle update rails ... $ rails --help > tmp/after $ diff -u tmp/before tmp/after --- tmp/before 2019-04-19 00:12:08.000000000 -0700 +++ tmp/after 2019-04-19 00:14:55.000000000 -0700 @@ -52,7 +52,6 @@ db:version destroy dev:cache - dev:help encrypted:edit encrypted:show initializers ```
* | Factorize bin/update in bin/setup, and make bin/setup idempotentDavid Stosik2019-04-172-35/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `bin/setup` and `bin/update` are currently almost the same file. The only thing that keeps them apart is that one is running `bin/rails db:setup` and the other `bin/rails db:migrate`. I'm suggesting here that they should be a unique script, which needs to be idempotent. - New to a project, need to get started? `bin/setup` - Need to install new dependencies that were added recently? `bin/setup`. Before deprecating `bin/update`, I'm suggesting we just have it call `bin/setup`.
* | Add collection cache versioningLachlan Sylvester2019-04-161-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cache versioning enables the same cache key to be reused when the object being cached changes by moving the volatile part of the cache key out of the cache key and into a version that is embedded in the cache entry. This is already occurring when the object being cached is an `ActiveRecord::Base`, but when caching an `ActiveRecord::Relation` we are currently still putting the volatile information (max updated at and count) as part of the cache key. This PR moves the volatile part of the relations `cache_key` into the `cache_version` to support recycling cache keys for `ActiveRecord::Relation`s.
* | [Rails::MailersController] Do not leak I18n global setting changesThierry Joyal2019-04-161-2/+5
| |
* | Merge pull request #35906 from yoones/notes-tags-registrationRafael França2019-04-152-2/+15
|\ \ | | | | | | Notes tags registration
| * | Adds `register_tags`Younes SERRAJ2019-04-122-2/+15
| | |
* | | generate config.cache_classes = false if SpringXavier Noria2019-04-141-5/+10
| | |
* | | deprecates autoloading constants during initialization [closes #35745]Xavier Noria2019-04-141-0/+37
| | | | | | | | | | | | See rationale in the warning message included in the patch.
* | | Do not treat `environment_desc` as commandsyuuji.yaginuma2019-04-131-1/+3
| | | | | | | | | | | | For avoid to show `environment_desc` in help.
* | | Merge pull request #35916 from soartec-lab/delete_not_use_methodRyuta Kamizono2019-04-111-15/+0
|\ \ \ | |/ / |/| | Delete not user method for plugin_generator
| * | Delete not user method for plugin_generatorsoartec-lab2019-04-091-15/+0
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 21:10:59 +0000