| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
| |
I don't know when this changed, checked back up to 3.2 and integration
tests instantiate fixtures just fine.
|
| |\
| |
| | |
rake stats for engines
|
| | | |
|
| |\ \
| | |
| | | |
fixed capitalization [ci skip]
|
| | | | |
|
| | | | |
|
| |\ \ \
| |/ /
|/| |
| | | |
avoid using alias in generators
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Ruby's alias produces public methods, causing a spurious Thor task
to be created. For example, this is the reason MigrationGenerator
currently has two tasks:
> ActiveRecord::Generators::MigrationGenerator.all_tasks.keys
=> ["singular_name", "create_migration_file"]
singular_name was meant to be an attribute, not a task. Because it's
public, it gets called as a task every time the generator is invoked.
The fix is to ensure all generator methods have the correct
visibility.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
schneems/schneems/generator-output-in-error"
This reverts commit 7466d6a9f989a1a8f90899b79b34f1152e440b7c, reversing
changes made to b850c4c540e8f0c15742f67c532f521a4a123655.
This was an accidental merge. A new PR will follow.
/cc @schneems
|
| | |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Let's say we just ran:
```
$ rails g migrate add_click_to_issue_assignment
```
We will get an error that looks like:
```
Could not find generator migrate.
```
This patch adds all existing migrations to the output to make it easier for a developer to find a valid migration.
```
Could not find generator "migrate". Please select a valid generator:
Rails:
assets
controller
generator
helper
integration_test
mailer
migration
model
resource
scaffold
scaffold_controller
task
```
It would be nice to do some spelling detection and suggest alternatives, but for now this should help.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The fix introduced at 75ba7425f6d235f254c00a45a58f42e88f80301a were
missing this case.
To fix the original issue mentioned at that commit the correct is to
remove update_config_files from the command list since we should not run
both config_files command when creating a new application.
Tests were added to make sure everything is working fine.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were generating this configuration with :json what may break
applications upgrating from Rails 4.0-.
Now we always generate with a safer value and people is free to choose
hybrid if they want.
We don't generate with hybrid by default because there are some cases
that can fail. These cases are explained on the upgrading guide.
|
| | | |
|
| | |
| |
| |
| |
| | |
Since the generated application’s Gemfile is using single quotation marks, it
seems fair to use it on plugin’s Gemfile as well.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Database configuration was trying to load the first path that
config.paths['config/database'] was returning even if the path didn't
exist in the filesystem.
Because Rails::Paths::Path has the possibility to return more than 1
path (as an array), database_configuration should filter down the paths
to the existing one and then load the first one.
This would make it possible to move the database.yml file and add the
new path to paths['config/database'] and still load the configurations.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
GeneratedAttribute#column_name checks already for reference? on the
attribute returning the right name to use as symbol for label and field.
|
| | |
| |
| |
| |
| | |
The last uses of this variable was removed with the `--builder` option.
2da5ea1c9feb4a7b491bd00bd6ffd931b9203da8
|
| | |
| |
| |
| | |
This reverts commit 7f62f30f58fe5f2955e3292ab1f01aa2c9a8f0ee.
|
| | |
| |
| |
| |
| |
| |
| | |
Like rake tasks and runner blocks these blocks should also being shared
between applications since they are stored at the classes.
Fixes #14748
|
| | | |
|
| |\ \
| | |
| | | |
Improve debugging support
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Move assets precompile (and version) to an initializer
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
sprockets-rails 2.1 needs the precompile list to be available in all
environments.
|
| |/ / /
| | |
| | |
| | |
| | |
| | | |
This will load properly the loading hooks.
Closes rails/sass-rails#205
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ / |
|
| | |
| |
| |
| |
| | |
In passing, allow multi-word adapters to be referenced in a URL:
underscored_name must become hyphened-name.
|
| | |
| |
| |
| | |
Fixes #14620
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
In 1.9, it doesn't live in its own file, so we'll have to define it
ourselves.
Check RUBY_VERSION, instead of rescuing the require, because we want
this to break if `psych/y` moves in a future Ruby release.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Previously, we relied on the IRB-detection in Psych itself. But that
doesn't work when we're running under spring: the application boots (and
thus psych is required) before we switch to console mode and load IRB.
Fixes #14587.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll
change to the absolute-path interpretation in 4.2.
The current "correct" spellings for in-memory, relative, and absolute
URLs, respectively, are:
sqlite3::memory:
sqlite3:relative/path
sqlite3:/full/path
Substantially reverses/defers fbb79b517f3127ba620fedd01849f9628b78d6ce.
Uncovered by @guilleiguaran while investigating #14495, though that
sounds like a different issue.
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Don't load test env by default.
Closes #13241
|
| | | | |
|
