| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit suppressed
`warning: instance variable @session_store not initialized`.
e5a6f7ee9e951dbe0e4e9ea2c0743b4dfb135c57 introduced these
warnings.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.
I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.
We may need to backport this for Rails 5.0.1.
Fixes #25899.
|
|\ \ \
| | | |
| | | |
| | | | |
Setup default session store internally, no longer through an initializer
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
initializer
- By default the session store will be set to cookie store with
application name as session key.
- Older apps are not affected as they will have the session store
initializer generated by Rails in older versions, and Rails will not
overwrite the session store if it is already set or disabled.
- But new apps will not have the initializer, instead the session store
will be set to cookie store by default.
- Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
set to activerecord session store
- Use keyword args as it is possible to use them now.
- The error message for activerecord-session_store gem was added in 1807384.
- But it was added for a code path which gets called when we try to
**access** the session store, not when we **set** it.
- So the test expecting the exception started failing because now the
session store is set via railtie again **after** setting it first with
:active_record_store in the test.
- As the error is not raised while setting the store to
:active_record_store, the store gets overwritten by railtie and when
we access it via `session_store` while building the default middleware
stack, the exception is not raised.
- This commit moves the code for raising the exception to the path where
we try to set the store.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
by Rails
- We need to ability to check whether the session store it is set or
not so that we can set it ourselves in an internal initializer.
- We can't rely on return value of `config.session_store` as it can
return `nil` when set to `disabled` and we will accidentally override it
and set to default cookie store.
- So introduced new method which just tells us whether it is set or not.
|
|\ \ \ \
| | | | |
| | | | | |
Give importance to rails command [ci skip]
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Speed up RDoc generation when it's already been done once
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Only include files that contain changes since the last generation
of the API documentation.
Thus, only modified files are re-generated instead of the whole API.
The `created.rid` file won't contain the whole list of files anymore
if we generate several times the API but we don't really care about it,
only the generation date and time is important.
It is possible to fall back to the previous behavior by defining the ALL
environment variable running the `rake rdoc` task.
|
| |/ / /
|/| | | |
|
|\ \ \ \
| | | | |
| | | | | |
Use the HOST environment variable for rails server #25677
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
fledman/add_respond_to_missing_to_rails_application_configuration_custom
implement respond_to_missing? to match method_missing
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
johnmeehan/allow-registering-directory-for-rake-notes
Allow rake notes to work with other directories.
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Additional directories can be added using
SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir")
Result: rake notes will now extract notes from these directories.
|
|\ \ \ \
| | | | |
| | | | | |
Display railtie class name in `rails initializers`
|
| | | | | |
|
| | | | | |
|
| | |_|/
| |/| | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The options used in this file are *not* directly described in the Rails 5.0
release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but
instead in section 2 of the Guide for Upgrading Ruby on Rails document
(http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
refer to rails command instead of rake in doc of `SourceAnnotationExtractor`
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| |/ / /
|/| | | |
Clean backtrace in IRB
|
| | | |
| | | |
| | | |
| | | | |
Add handling of cleaning up backtrace from IRB console in case of errors
|
| | | |
| | | |
| | | |
| | | | |
Follow up to #25431
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update
Display link to Rails upgrade guide at the end of `rails app:update` task.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
- This will nudge people in the direction of going through upgrade
guides.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Update to Turbolinks 5.0.0 final
|
| |/ / / |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will fix the failures fixed by
41488adbb89a09fa96188486f8414842ff28c848
and keep this new option that is semi-private
outside of the generated configurations
|
| | |
| | |
| | |
| | |
| | | |
Railties tests didn't know about the new config option added in 80b416f so
it needed to be added to the railties generators for configs.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will make easier to applications that rely on having const_missing
hooks in production upgrade to Rails 5.
This option is going to be remove in the future and the default behavior
will be to disable the dependency loading.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The /rails/info routes were inaccessible in apps with a catch-all
globbing route, as they were being appended after the globbing route and
would never be matched.
See also ccc3ddb7762bae0df7e2f8d643b19b6a4769d5be.
|
| | |
| | |
| | |
| | |
| | |
| | | |
- As assets are removed for API only apps anyways, so we don't need any
conditional upfront.
- assets are removed for API apps here - https://github.com/rails/rails/blob/94ef224aa61ace3fa643eab161ff9056b7d90a62/railties/lib/rails/generators/rails/app/app_generator.rb#L266-L273.
|
| | |
| | |
| | |
| | |
| | | |
This option is used in a initializer hook that runs before the
config/initializers files so it will not work if it is set there.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/generate_mailer_layout_files_if_it_does_not_already_exist
generate mailer layout files if it does not already exist
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, if `ApplicationMailer` does not exist, it is generated when
run the mailer generator, but layouts files does not generate.
However, because it uses the layouts in `ApplicationMailer`,
layouts are required.
Follow up to #24161
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix API controller tests by assigning them the encoding type
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Fixes #25183.
- The `as: :json` feature was added in
https://github.com/rails/rails/pull/21671 and recommended to use for
JSON endpoints so let's use it by default for API controller tests.
|