aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib
Commit message (Collapse)AuthorAgeFilesLines
* Use fullpath from Rack request rather than building iteileencodes2015-03-201-11/+5
| | | | | | | | | | | | | | | | | | | | In Rack, `#fullpath` checks if there is a query string and builds the query correctly: ``` def path script_name + path_info end def fullpath query_string.empty? ? path : "#{path}?#{query_string}" end ``` We can utilize this instead of manually building the fullpath because they are the same result. This also reduces allocations in `#call` because we don't need `build_original_fullpath` to create the paths and query strings. We don't need to build `fullpath` twice.
* Updated MySQL documentation link to MySQL latest version 5.6 everywhere [ci ↵amitkumarsuroliya2015-03-192-2/+2
| | | | skip]
* Merge pull request #19404 from dmathieu/remove_rack_envAaron Patterson2015-03-195-5/+5
|\ | | | | Don't fallback to RACK_ENV when RAILS_ENV is not present
| * don't fallback to RACK_ENV when RAILS_ENV is not presentDamien Mathieu2015-03-195-5/+5
| |
* | Use absolute path on find_method location for the runnerArthur Neves2015-03-191-1/+1
| |
* | Fix test rake when passing multiple argumentsArthur Neves2015-03-191-2/+2
| | | | | | | | bundle exec db:migrate rake was not working, with the new runner, before this commit
* | method_source needs to be a hard dependency on railtiesArthur Neves2015-03-191-4/+0
| |
* | Merge pull request #19216 from senny/bin_test_runnerYves Senn2015-03-198-24/+205
|\ \ | | | | | | `bin/rails test` runner (rerun snippets, run tests by line, option documentation)
| * | Use Rails::TestRunner on rake testArthur Neves2015-03-181-16/+17
| | |
| * | Fix reporter test and verbose modeArthur Neves2015-03-181-1/+1
| | |
| * | move `ENV["BACKTRACE"]` support into the TestRunner.Yves Senn2015-03-182-3/+2
| | |
| * | `-p`, `--pattern` to run tests using a pattern.Yves Senn2015-03-181-0/+4
| | |
| * | use `bin/rails t` runner in `test_runner_test.rb`.Yves Senn2015-03-181-2/+2
| | |
| * | Fix relative dir call on test runnerArthur Neves2015-03-181-5/+10
| | |
| * | Add tests for runner#test_files methodArthur Neves2015-03-181-7/+7
| | |
| * | Run multiple files on runnerArthur Neves2015-03-181-4/+5
| | |
| * | `-e` / `--environment` for the test runner.Yves Senn2015-03-182-2/+8
| | |
| * | move argument parsing into the `Runner`.Yves Senn2015-03-182-3/+6
| | |
| * | get rid of NAMED_PATTERNS in favor of running a whole directoryYves Senn2015-03-181-7/+4
| | |
| * | document running a test by line number.Yves Senn2015-03-181-0/+7
| | |
| * | pluralize rerun snippet heading.Yves Senn2015-03-181-1/+1
| | |
| * | Show the right file when test raisesArthur Neves2015-03-181-4/+3
| | |
| * | Move minitest pluginArthur Neves2015-03-183-21/+20
| | | | | | | | | | | | | | | | | | | | | Minitest Rails plugin should be loaded on test_help, so we report errors even when not running from the runner. Also fix the backtrace
| * | Move some logic to runnerArthur Neves2015-03-182-13/+11
| | |
| * | Dont display Failed test if suite passedArthur Neves2015-03-181-0/+1
| | |
| * | Better file:line parsing and filter method by file tooArthur Neves2015-03-181-11/+19
| | |
| * | no need to escape the method in a regex wrap, minitest does that for usArthur Neves2015-03-181-1/+1
| | |
| * | If a nem given, use that name to filter the testArthur Neves2015-03-181-5/+1
| | |
| * | Add test run by line, and report error by lineArthur Neves2015-03-183-3/+62
| | |
| * | spike of a `OptionParser` backed test runner.Yves Senn2015-03-184-2/+100
| |/
* / Add a new-line to the end of route method generated code.Arthur Neves2015-03-182-3/+5
|/ | | | | | | | Fix regression on route method that was added by bac812a7ef2660a2fe2ab00822e5e66228379822. The regression was that when calling the `route` method, we were not appending a \n anymore. [fixes #19316]
* add mailer suffix to comments for email previewsyuuji.yaginuma2015-03-151-2/+2
|
* Merge pull request #19323 from naoty/rake_initializerRafael Mendonça França2015-03-132-0/+7
|\ | | | | Add `rake initializer`
| * Add `rake initializer`Naoto Kaneko2015-03-142-0/+7
| | | | | | | | | | This task prints out initializers for an application. It is useful to develop a rubygem which involves the initialization process.
* | Update sprockets links to point to rails orgJoshua Peek2015-03-133-3/+3
|/
* Use `def setup` instead of `setup do`eileencodes2015-03-121-2/+4
| | | | | `setup do` creates unnecessary allocations of proc objects in callbacks. This prevents that from happening and results in faster code.
* pass a config to the route setAaron Patterson2015-03-051-1/+1
| | | | | This way we can get the relative_url_root from the application without setting another global value
* Revert work arounds for upstream Ruby 2.2.0 kwargs bugGenadi Samokovarov2015-03-051-3/+3
| | | | | | | | | | | | | | | | | | | The bug caused a segfault and you can find more info about it at: https://bugs.ruby-lang.org/issues/10685. We did a couple of work arounds, but 2.2.1 rolled out and those aren't needed anymore. Here are the reverted commits: - Revert "Work around for upstream Ruby bug #10685", commit 707a433870e9e06af688f85a4aedc64a90791a64. - Revert "Fix segmentation fault in ActionPack tests", commit 22e0a22d5f98e162290d9820891d8191e720ad3b. I'm also bumping the Ruby version check to 2.2.1 to prevent future segfaults.
* Some documentation edits [ci skip]Robin Dupret2015-03-051-3/+3
| | | | | | * Fix a few typos * Wrap some lines around 80 chars * Rephrase some statements
* ask the routes objects for its Rack env keyAaron Patterson2015-03-021-1/+1
| | | | | | this centralizes the logic for determining the script name key and drops object allocations when calling `engine_script_name` (which is called on each `url_for`).
* Merge pull request #19173 from robin850/rbx-buildRafael Mendonça França2015-03-021-1/+1
|\ | | | | Improve the Rubinius build
| * Avoid Ruby versions check on RubiniusRobin Dupret2015-03-021-1/+1
| | | | | | | | | | Rubinius is still targeting compliance with Ruby 2.1.0 but we are pretty close to a green build so let's avoid this check for the moment.
* | Rake restart task no longer loads entire Rails environment when run.Hyonjee Joo2015-03-021-1/+1
|/ | | | | The restart task does not need access to models or other classes and helpers from the application environment.
* Lines of code can be 100,000+ in a Rails appAkira Matsuda2015-03-011-4/+4
| | | | Actually, our app has 400,000 LOC :boom:
* Created rake restart task.Hyonjee Joo2015-02-262-0/+5
| | | | | | Fixes #18876. Rake restart touches `tmp/restart.txt` to restart application on next request. Updated tests and documentation accordingly.
* Merge pull request #18434 from brainopia/change_filter_on_rails_info_routesRichard Schneeman2015-02-261-2/+23
|\ | | | | Change filter on /rails/info/routes to use an actual path regexp from rails
| * Change filter on /rails/info/routes to use an actual path regexp from railsbrainopia2015-02-231-2/+23
| | | | | | | | | | | | | | | | Change filter on /rails/info/routes to use an actual path regexp from rails and not approximate javascript version. Oniguruma supports much more extensive list of features than javascript regexp engine. Fixes #18402.
* | fix typo [ci-skip]Robert Krzyzanowski2015-02-251-1/+1
|/
* Merge pull request #18395 from shunsukeaida/improve_generator_name_suggestionsRichard Schneeman2015-02-231-3/+1
|\ | | | | Improve generator name suggestions a bit.
| * Improve generator name suggestions a bit.ShunsukeAida2015-02-221-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the Levenshtein distances to most commands were wrongly calculated due to a big shortcut. This might be included in the original code for the performance sake, but I'm not sure that's something we should take over accuracy in Rails. Before 'foo' to 'assets' #=> 3 'foo' to 'controller' #=> 3 'foo' to 'generator' #=> 3 'foo' to 'helper' #=> 3 'foo' to 'integration_test' #=> 3 'foo' to 'jbuilder' #=> 3 'foo' to 'job' #=> 2 'foo' to 'mailer' #=> 3 'foo' to 'migration' #=> 3 'foo' to 'model' #=> 3 'foo' to 'resource' #=> 3 'foo' to 'resource_route' #=> 3 'foo' to 'scaffold' #=> 3 'foo' to 'scaffold_controller' #=> 3 'foo' to 'task' #=> 4 'foo' to 'active_record:migration' #=> 3 'foo' to 'active_record:model' #=> 3 'foo' to 'coffee:assets' #=> 3 'foo' to 'css:assets' #=> 3 'foo' to 'css:scaffold' #=> 3 'foo' to 'erb:controller' #=> 3 'foo' to 'erb:mailer' #=> 3 'foo' to 'erb:scaffold' #=> 3 'foo' to 'js:assets' #=> 3 'foo' to 'scss:assets' #=> 3 'foo' to 'scss:scaffold' #=> 3 'foo' to 'test_unit:controller' #=> 3 'foo' to 'test_unit:generator' #=> 3 'foo' to 'test_unit:helper' #=> 3 'foo' to 'test_unit:integration' #=> 3 'foo' to 'test_unit:job' #=> 3 'foo' to 'test_unit:mailer' #=> 3 'foo' to 'test_unit:model' #=> 3 'foo' to 'test_unit:plugin' #=> 3 'foo' to 'test_unit:scaffold' #=> 3 After 'foo' to 'assets' #=> 6 'foo' to 'controller' #=> 8 'foo' to 'generator' #=> 8 'foo' to 'helper' #=> 6 'foo' to 'integration_test' #=> 15 'foo' to 'jbuilder' #=> 8 'foo' to 'job' #=> 2 'foo' to 'mailer' #=> 6 'foo' to 'migration' #=> 8 'foo' to 'model' #=> 4 'foo' to 'resource' #=> 7 'foo' to 'resource_route' #=> 12 'foo' to 'scaffold' #=> 6 'foo' to 'scaffold_controller' #=> 16 'foo' to 'task' #=> 4 'foo' to 'active_record:migration' #=> 21 'foo' to 'active_record:model' #=> 17 'foo' to 'coffee:assets' #=> 12 'foo' to 'css:assets' #=> 10 'foo' to 'css:scaffold' #=> 10 'foo' to 'erb:controller' #=> 12 'foo' to 'erb:mailer' #=> 10 'foo' to 'erb:scaffold' #=> 10 'foo' to 'js:assets' #=> 9 'foo' to 'scss:assets' #=> 11 'foo' to 'scss:scaffold' #=> 11 'foo' to 'test_unit:controller' #=> 18 'foo' to 'test_unit:generator' #=> 18 'foo' to 'test_unit:helper' #=> 16 'foo' to 'test_unit:integration' #=> 20 'foo' to 'test_unit:job' #=> 12 'foo' to 'test_unit:mailer' #=> 16 'foo' to 'test_unit:model' #=> 14 'foo' to 'test_unit:plugin' #=> 16 'foo' to 'test_unit:scaffold' #=> 16 Besides that, the conjunction "or" of the message now appears only between the last two suggestions.