aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #23631 from y-yagi/generate_mailer_views_in_apiYves Senn2016-02-152-3/+7
|\ \ | | | | | | generate mailer views in Rails API
| * | generate mailer views in Rails APIyuuji.yaginuma2016-02-152-3/+7
| | | | | | | | | | | | | | | View files is necessary to send mail, it should be generated even Rails API. Fixes #23617
* | | test runner, relay minitest information about the error location.Yves Senn2016-02-151-1/+1
| | | | | | | | | | | | | | | This is a follow-up to ea70c29 to bring back the assertion error location information provided by minitest.
* | | Revert "Prefer Minitest's location for test failures."Yves Senn2016-02-151-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0db310586ac3e15be95d2ef27ff40cfa24c05c10. Closes #23686. Conflicts: railties/test/application/test_runner_test.rb It's possible that the `result.location` returned by minitest is outside the test file itself. For example in the case of mocha. This resulted in bad rerun snipptets: ``` bin/rails test app/models/deliveries/delivery.rb:103 ``` Let's always use the first line of the failed test-case in our rerun snippet. We can display the line number of the assertion error elsewhere.
* | | Merge pull request #23569 from Gaurav2728/no_doc_of_some_railtie_methodsVipul A M2016-02-151-4/+7
|\ \ \ | | | | | | | | mark as #:nodoc: [ci skip]
| * | | mark as #:nodoc: [ci skip]Gaurav Sharma2016-02-151-4/+7
| | | | | | | | | | | | can’t be instantiate directly or may be no need for doc.
* | | | Merge pull request #23664 from y-yagi/remove_test_order_from_environment_fileYves Senn2016-02-151-3/+0
|\ \ \ \ | |/ / / |/| | | remove `active_support.test_order` from environment file
| * | | remove `active_support.test_order` from environment fileyuuji.yaginuma2016-02-141-3/+0
| | | | | | | | | | | | | | | | | | | | The default test order has been changed to `:random` in 5f777e4b5ee2e3e8e6fd0e2a208ec2a4d25a960d. Therefore, it is no more need to be specified in the environment file.
* | | | Merge pull request #23505 from kaspth/inject-rails-config-through-railtieKasper Timm Hansen2016-02-141-0/+1
|\ \ \ \ | |/ / / |/| | | Inject Rails related configuration through Railtie
| * | | Inject Rails' channel paths in engine.Kasper Timm Hansen2016-02-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize, thereby coupling ourselves to Rails. Instead add `app/channels` to Rails' app paths and assign the existent files to `channel_paths`. Users can still append to those load paths with `<<` and `push` in `config/application.rb`. This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails and root definitions in the tests.
* | | | Use Ruby 1.9 hash syntaxRafael Mendonça França2016-02-121-1/+1
| | | |
* | | | Use correct path in documentation.Tom von Schwerdtner2016-02-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | s/config\/production/config\/environments\/production/ [ci skip]
* | | | - Fixed and removed long arguments to rake routesVipul A M2016-02-121-3/+3
| |/ / |/| | | | | | | | | | | | | | - Fixed related documentation and usage all around Fixes #23561
* | | Merge pull request #23528 from bensheldon/patch-1Richard Schneeman2016-02-101-1/+1
|\ \ \ | | | | | | | | Set database poolsize via rails_max_threads
| * | | Set postgresql poolsize via RAILS_MAX_THREADSBen Sheldon2016-02-101-1/+1
| |/ /
* | | Merge pull request #23512 from y-yagi/set_association_name_to_fixtureDavid Heinemeier Hansson2016-02-101-1/+1
|\ \ \ | | | | | | | | set association name to generated fixtures if attribute is reference
| * | | set association name to generated fixtures if attribute is referenceyuuji.yaginuma2016-02-061-1/+1
| |/ / | | | | | | | | | | | | | | | | | | It has been changed to require `belongs_to` by default in Rails 5. Therefore in order to pass the controller test, have association of set to fixtures. Fixes #23384
* | | include spring-watcher-listen in the Gemfile of new applicationsXavier Noria2016-02-101-0/+3
| | |
* | | enables the evented monitor in new applicationsXavier Noria2016-02-103-1/+8
| | |
* | | revert dev:cache to rake task, fixes #23410Scott Bronson2016-02-074-22/+15
| | |
* | | Remove unused private methodSyamil MJ2016-02-071-4/+0
|/ /
* | Fix mixing line filters with Minitest's -n filter.Kasper Timm Hansen2016-02-051-4/+12
| | | | | | | | | | | | | | | | | | | | | | Previous commit accidentally broke mixing line filters with string -n filter. Fix by checking if it is a string and returning it. We also need to ensure the -n filter carry forward into any other composite filters. Fix by letting the named filter be extractable, so we'll keep this for the next runnable's run.
* | - app generate option --skip-sprockets leaves jquery-rails gem, which relies ↵Vipul A M2016-02-041-1/+1
| | | | | | | | | | | | | | | | on sprockets environment - Remove jquery-rails if --skip-sprockets is true Fixes #23431
* | Merge pull request #23478 from vipulnsward/23470-pass-api-in-update-generatorRafael França2016-02-041-1/+1
|\ \ | | | | | | Pass api only option to rails rails:update task to update only based on api Apps
| * | Pass api only option to rails rails:update task to update only based on API.Vipul A M2016-02-041-1/+1
| |/ | | | | | | Fixes #23470
* | Turbolinks has moved outDavid Heinemeier Hansson2016-02-041-1/+1
| | | | | | | | All grown up and shit!
* | Redis is now only needed if you want to use Action Cable in productionDavid Heinemeier Hansson2016-02-041-2/+2
| | | | | | | | So no need to have it on by default in the Gemfile.
* | rake stats dynamically scales nowAkira Matsuda2016-02-041-9/+21
| | | | | | | | So it can properly show stats for an app with 1,000,000+ LOC
* | Revert "Lines of code can be 100,000+ in a Rails app"Akira Matsuda2016-02-041-4/+4
| | | | | | | | | | | | This reverts commit 293bd95c3e77275193130bc14c986348aae8b0e2. This broke the header :<
* | Merge pull request #23458 from kamipo/activerecord_supports_mysql_5.0_and_upSean Griffin2016-02-032-2/+2
|\ \ | | | | | | Active Record supports MySQL >= 5.0
| * | Active Record supports MySQL >= 5.0Ryuta Kamizono2016-02-042-2/+2
| | | | | | | | | | | | | | | Currently some features uses `information_schema` (e.g. foreign key support). `information_schema` introduced since MySQL 5.0.
* | | Merge pull request #23456 from kaspth/line-filter-triggers-one-runnableKasper Timm Hansen2016-02-031-1/+1
|\ \ \ | |/ / |/| | Fix line filters running tests from multiple runnables.
| * | Fix line filters running tests from multiple runnables.Kasper Timm Hansen2016-02-031-1/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `derive_regexp` was written with the assumption that we were run from a blank slate — that if the filter didn't match we might as well return it because it was nil. This isn't the case because minitest calls `run` on every runnable. Which is any subclass of Minitest::Runnable, such as ActiveSupport::TestCase, ActionDispatch::IntegrationTest as well as any inheriting from those. Thus after the first `run` we'd have put in a composite filter in `options[:filter]` making the next `run` create a linked list when it failed to match the regexp and put the composite filter as the head. Every runnable would accumulate more and more of the same filters, which effectively acted like an expanding whitelist and we ran tests from other runnables. Clog the accumulation by returning nil if there's no filter to derive a regexp from. Note: we pass a seed in the tests because Minitest shuffles the runnables to ensure the whitelist is expanded enough that the failure is triggered.
* / Add dummy apple icon filesAlexey Zabelin2016-02-032-0/+0
|/ | | | | | | | Previously Safari would try to load these files when you visit localhost:3000. That created two exceptions in the log. It also caused the exception notifier to send them out. In response to #23427
* Merge pull request #23447 from y-yagi/update_pg_supported_version_in_docsYves Senn2016-02-032-2/+2
|\ | | | | update supported version of PostgreSQL in docs [ci skip]
| * update supported version of PostgreSQL in docs [ci skip]yuuji.yaginuma2016-02-032-2/+2
| | | | | | | | Follow up to #23434
* | use rails command in routes taskyuuji.yaginuma2016-02-031-3/+3
|/ | | | | For other task has become to use the rails command at doc and test, I think that routes task also it is better to use the rails command.
* Generated engines should protect from forgeryAaron Patterson2016-02-011-0/+1
| | | | | | Generated engines should call `protect_from_forgery`. If this method isn't called, then the Engine could be susceptible to XSS attacks. Thanks @tomekr for reporting this to us!
* :warning: assigned but unused variable - errAkira Matsuda2016-02-021-2/+2
|
* Preparing for Rails 5.0.0.beta2Sean Griffin2016-02-011-1/+1
|
* Add spaces in the braces.Kasper Timm Hansen2016-02-011-1/+1
| | | | | | Solves personal insanity, since I was down in these files. (Please don't submit PRs like this.)
* Merge pull request #23225 from vipulnsward/20420-rake-routes-optionsKasper Timm Hansen2016-02-011-2/+30
|\ | | | | Add options for rake routes task
| * Add options for rake routes taskVipul A M2016-02-021-2/+30
| | | | | | | | | | | | | | | | | | | | Add two options: `-c` and `-g`. `-g` option returns the urls name, verb and path fields that match the pattern. `-c` option returns the urls for specific controller. Fixes #18902, and Fixes #20420 [Anton Davydov & Vipul A M]
* | Merge pull request #23398 from matthewd/interlockMatthew Draper2016-02-021-1/+1
|\ \ | |/ |/| Address remaining known issues in Interlock
| * Always obtain the lock and do the unloadMatthew Draper2016-02-021-1/+1
| | | | | | | | | | | | We mostly care about `reload_classes_only_on_change=true`, because that's the default... and there, we definitely need to wait for the lock when necessary.
* | Merge pull request #23057 from schneems/schneems/default-puma-configRichard Schneeman2016-02-014-3/+55
|\ \ | | | | | | Add Default Puma Config
| * | Add Default Puma Configschneems2016-01-294-3/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the `puma` command is run without any configuration options it will detect presence of a `config/puma.rb` file and use that. Currently there is discrepancy between `puma` command and `rails server` but Evan said it would be reasonable to add in reading in config from the default location. I am working on that right now as a feature in puma/puma. Why do we need this? By default Puma uses 16 threads, and by default ActiveRecord only has 5 threads. Due to the architecture of AR it is guaranteed that if you're running with fewer DB connections than your server has threads you will hit `ActiveRecord::ConnectionTimeoutError ` eventually if your app gets modest amounts of traffic. Since we are providing a default webserver, we should provide reasonable configuration for that webserver. This PR does a few things, first it sets the default Puma thread count to 5 to mach ActiveRecord's default. It sets the default environment to `"development"` and the default port to 300 so that booting the server with `$ puma` will give you the same default port as `rails server`. It is worth mentioning that by reading in from `PORT` environment variable this config can work with containerized deployments, such as on Heroku. We are not using worker processes by default, that way JRuby and windows devs can use this configuration without modification. I went ahead and included a default `on_worker_boot`. It won't be used unless a worker count is specified, that means this config will not use it. Even though it's not being used now It will make someone who wants to try modifying their config to run extra workers easier. cc/ @pixeltrix
* | | Merge pull request #23385 from matthewd/default-subscription-adapterMatthew Draper2016-02-021-4/+2
|\ \ \ | |_|/ |/| | Change default ACa adapter for development & test
| * | Use the in-process subscription adapter for development & testMatthew Draper2016-02-011-4/+2
| | |
* | | Merge pull request #23381 from matthewd/uneventful-redisMatthew Draper2016-02-021-1/+0
|\ \ \ | | | | | | | | Redis sans EventMachine
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 05:28:48 +0000