| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / /
| | |
| | |
| | |
| | |
| | | |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update
Display link to Rails upgrade guide at the end of `rails app:update` task.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
- This will nudge people in the direction of going through upgrade
guides.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Update to Turbolinks 5.0.0 final
|
| |/ / / |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will fix the failures fixed by
41488adbb89a09fa96188486f8414842ff28c848
and keep this new option that is semi-private
outside of the generated configurations
|
| | |
| | |
| | |
| | |
| | | |
Railties tests didn't know about the new config option added in 80b416f so
it needed to be added to the railties generators for configs.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will make easier to applications that rely on having const_missing
hooks in production upgrade to Rails 5.
This option is going to be remove in the future and the default behavior
will be to disable the dependency loading.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The /rails/info routes were inaccessible in apps with a catch-all
globbing route, as they were being appended after the globbing route and
would never be matched.
See also ccc3ddb7762bae0df7e2f8d643b19b6a4769d5be.
|
| | |
| | |
| | |
| | |
| | |
| | | |
- As assets are removed for API only apps anyways, so we don't need any
conditional upfront.
- assets are removed for API apps here - https://github.com/rails/rails/blob/94ef224aa61ace3fa643eab161ff9056b7d90a62/railties/lib/rails/generators/rails/app/app_generator.rb#L266-L273.
|
| | |
| | |
| | |
| | |
| | | |
This option is used in a initializer hook that runs before the
config/initializers files so it will not work if it is set there.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/generate_mailer_layout_files_if_it_does_not_already_exist
generate mailer layout files if it does not already exist
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, if `ApplicationMailer` does not exist, it is generated when
run the mailer generator, but layouts files does not generate.
However, because it uses the layouts in `ApplicationMailer`,
layouts are required.
Follow up to #24161
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix API controller tests by assigning them the encoding type
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Fixes #25183.
- The `as: :json` feature was added in
https://github.com/rails/rails/pull/21671 and recommended to use for
JSON endpoints so let's use it by default for API controller tests.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since Ruby 2.4 isn't out yet, the fact that it will make `to_time` preserve the
time zone should be toggled with a update flag.
Second, remove the flipping on what version had what defaults. It's called new
framework defaults, so it's from the future looking. Thus keep the line that
mentions past versions.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
- Adjusted tests instead.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
about old apps and how you can upgrade to new defaults.
[Kasper Timm Hansen, Prathamesh Sonpatki]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
request_forgery_protection configs
- Earlier per_form_csrf_tokens and request_forgery_protection config
files were generated for old apps upgraded to Rails 5.
- But when we collapsed all initializers into one file, the entire file
does not get created for old apps.
- This commit fixes it and also changes values for all new defaults for
old apps so that they will not break.
- Also added a test for `rails app:update`.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Move real new default options to the top of the file.
- After that club together all the options which were added to keep
backward compatibility. So all of them will get only one header.
- Based on https://github.com/rails/rails/pull/25231#issuecomment-222945173.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
guides/source/action_cable_overview.md
|
| |/ / /
| | | |
| | | |
| | | | |
http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#english
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Collapse all new default initializers into a single file
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Adjusted tests also for this new behavior.
- Based on the discussion in
https://github.com/rails/rails/pull/25184#issuecomment-222454583.
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | | |
- These initializers are new defaults for Rails 5 and newly generated
apps do not need to change them.
- Fixes #25181
|
|\ \ \
| | | |
| | | | |
Remove public/ files for API apps
|
| | | |
| | | |
| | | |
| | | | |
- Fixes #25180
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
second is now irrelevant with the dedicated API mode
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Use RAILS_MAX_THREADS as pool size on all adapters
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When RAILS_MAX_THREADS is set, the postgresql adapter uses it as the
connection pool size, so that there are always enough connections
available to serve Action Cable requests.
The same logic applies when using any other adapter.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Un-hide helper and assets options for controller generator
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
These options were hidden via 9b36cf0fa4cbdcb2e2072ef1b8179a98b13efce3,
but these options have tests written for them, and I believe that they
are supposed to be public API.
Fixes #24168.
|
| | | | |
| | | | |
| | | | |
| | | | | |
environments
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
javascript engine of the application
- Now we will detect what javascript engine user is using and based on
that we will generate either `.js` or `.coffee` version of the channel
file.
- This also needs a change in coffee-rails to override the `js_template`
method. Related PR https://github.com/rails/coffee-rails/pull/72.
- Currently coffee-rails gem sets
`config.app_generators.javascript_engine` to `:coffee` and using this
information we override the `js_template` to set the extension as
`.coffee` in coffee-rails gem.
- Using this approach, we can keep the `channel.js` and `channel.coffee`
files in the Rails repository itself.
- Additionally the `js_template` method can act as public interface for
coffee-rails gem to hook into and change the extension to `.coffee`
without maintaining the actual asset files.
[Prathamesh Sonpatki, Matthew Draper]
|
| |/ /
|/| |
| | |
| | | |
Conventionally envs are ordered development -> test -> production.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
remove unnessary option setting from test runner
|
| | | |
| | | |
| | | |
| | | |
| | | | |
In order to prevent `OptionParser::ParseError` when specify the rake options to
`routes` task.
|