| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
```
$ git grep namespaced_file_path
railties/lib/rails/generators/named_base.rb: def namespaced_file_path
railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/")
```
|
|
|
|
|
|
|
|
| |
This fixes the following warning.
```
Expected boolean default value for '--rc'; got "~/.railsrc" (string)
```
|
|
|
|
|
|
|
| |
Unintentionally makes `--webpack` implied on `rails new apper`.
If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`,
so we can check for that instead of `"base"`.
|
|
|
|
| |
setup
|
|
|
|
| |
namespace_ladder can be nil here
|
|
|
|
| |
Don't expect the caller of this method to know that the return value has an extra " "
|
| |
|
|
|
|
|
|
|
|
|
| |
This fixes the following error when executing rails new command.
```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```
Follow up to #27288
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Extract notes as binary
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prevents:
ArgumentError: invalid byte sequence in UTF-8
railties/lib/rails/source_annotation_extractor.rb:115:in `=~'
railties/lib/rails/source_annotation_extractor.rb:115:in `block in extract_annotations_from'
And there's no reason we need to interpret the files as UTF-8
when scanning for annotations.
Applies to Rails 4.2 as well.
|
| | |
|
| |
| |
| | |
Clarifying some of the language/punctuation and removing a couple comma splices.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Follow up to 3dac36bd8e26363bb10f4d2a7b21efa75d200e26
|
| |
| |
| | |
Move node_modules, package.json, and yarn.lock file to vendor
|
| |
| |
| |
| |
| | |
`Gem.win_platform?` check if it is Windows more accurately.
Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Add Yarn support in new apps using --yarn option
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When making the new command insfrastructure I had missed that
`bin/rails runner some_file.rb some args` would pass the extra
args onto the file in `ARGV`.
Now fixed by allowing the command to take extra args again, and
make sure to remove the file name from `ARGV`.
|
| |
| |
| |
| | |
if turbolinks is present in gemfile list
|
| |
| |
| |
| |
| |
| |
| | |
- New apps generated on master and latest bundler give warning about
"github" source being insecure.
- Use the same solution used for Rails master in the generated app's
Gemfile to fix this issue.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`.
```
% rails plugin new my_engine -S --full --skip-gemspec
% cd my_engine
% bin/rails test
rails aborted!
NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100>
```
|
|\ \
| | |
| | |
| | | |
Add --skip-coffee generating option
|
| | |
| | |
| | |
| | |
| | |
| | | |
Usage
`rails new awesome-project --skip-coffee`
|
| | |
| | |
| | |
| | | |
YAML and ERB were removed at 971d510
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This removes the following warnings.
```ruby
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @load_console not initialized
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized
```
|
| | | |
|
| | | |
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
runner blocks
fixing @generators var initialization
pre initializing variables values
Changing from var init to symbol to instance var get/set
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
meinac/add_missing_types_into_ar_model_generator_usage"
This reverts commit aaf561d26cf9a879ff40190b625155015c6225da, reversing
changes made to 83776676e54b387fc52081ff31cfd7710bae9e03.
Reason: It is not a good idea to connect to the database on generators
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
meinac/add_missing_types_into_ar_model_generator_usage
Dynamically show available sql types [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
Dynamically list available sql data types based on current database adapter.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
They're just barren on the site and confure more than guide, instead
rely on the built in --help to guide users.
|