| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Currently, if `ApplicationMailer` does not exist, it is generated when
run the mailer generator, but layouts files does not generate.
However, because it uses the layouts in `ApplicationMailer`,
layouts are required.
Follow up to #24161
|
| |
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
| |
|
|\
| |
| | |
remove unnessary option setting from test runner
|
| |
| |
| |
| |
| | |
In order to prevent `OptionParser::ParseError` when specify the rake options to
`routes` task.
|
| |
| |
| |
| |
| |
| |
| | |
If run the test over the `rake` command, because of the test patterns is passed
via `rake_run` method, do not need to be obtained from the argv.
This probably fixes #24372.
|
| |
| |
| |
| | |
`railtie` is already a string!
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will
preserve the timezone of the receiver when converting to an instance
of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we
need to introduce a compatibility layer so that apps that upgrade do
not break. New apps will have a config initializer file that defaults
to match the new Ruby 2.4 behavior going forward.
For information about the changes to Ruby see:
https://bugs.ruby-lang.org/issues/12189
https://bugs.ruby-lang.org/issues/12271
Fixes #24617.
|
|\
| |
| |
| |
| | |
y-yagi/use_wrapper_file_to_add_rake_task_for_engines
use wrapper file to add rake task for engines
|
| |
| |
| |
| |
| |
| |
| |
| | |
`bundler` provides wrapper file to add rask tasks.
https://github.com/bundler/bundler/blob/master/lib/bundler/gem_tasks.rb
Instead of directly call method, by which require this file,
it can be used without updating of Rakefile if task has been added.
|
|/ |
|
|\
| |
| |
| | |
Add ActiveSupport::TimeZone.country_zones helper
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Railties' `config` method instatiates a Rails::Railtie::Configuration
object. Rails::Configuration is not used in this file.
The patch does not replace the file being required with the one for
Rails::Railtie::Configuration because that one is autoloaded. See the
spot where this patch changes double quotes with single quotes.
Rails::Railtie::Configuration does depend on Rails::Configuration, and
it requires it accordingly.
|
|\
| |
| |
| |
| | |
prathamesh-sonpatki/add-config-to-deprecation-warning
Add `config` to the deprecation warnings of deprecated config options
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The pass touches a few minor things.
One important aspect is that the wording treats "railtie" as a
regular noun. This is so because Railtie is a constant and
generally the text refers to "classes that act as railties",
which is different.
Railties are so fundamental in Rails that deserve a noun,
like engine, class, array, application, etc. They have a
meaning per se, beyond constants.
Also, make clear an extension's railtie does not need to
be called "Railtie" or have "Railtie" in their class name.
|
| |
| |
| |
| |
| | |
Idiomatically trailing hashes in method calls do not use
explicit curlies.
|
| |
| |
| |
| |
| | |
Rake includes (an extended version of) FileUtils in tasks.
It is more idiomatic that they use this provided interface.
|
|/
|
|
|
|
| |
With the exception of what is loaded in active_support/rails,
each file is responsible for its own dependencies. You cannot
rely on runtime order of execution.
|
|
|
|
|
|
| |
This was added in a4c358f, but `config.assets` has been removed in 5172d93.
Also, do not use env path to `Sprockets::Cache::FileStore` even `sprockets-rails`.
ref: https://github.com/rails/sprockets-rails/blob/master/lib/sprockets/railtie.rb#L129
|
|
|
|
|
|
| |
* Updated syntax
* Updated tests to match syntax
|
|\
| |
| | |
remove unused `require`
|
| | |
|
| |
| |
| |
| | |
Also, make sure to call the +complete+ hooks if +run+ fails.
|
|\ \
| | |
| | | |
Added 'config.' to deprecation warning
|
| | |
| | |
| | |
| | | |
Misc:
`config.public_file_server.enabled = true` instead `public_file_server.enabled = true`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- We need to pass the restart command to Puma so that it will use it
while restarting the server.
- Also made sure that all the options passed by user while starting
the server are used in the generated restart command so that they will
be used while restarting the server.
- Besides that we need to remove the server.pid file for the previous running
server because otherwise Rack complains about it's presence.
- We don't care if the server.pid file does not exist. We only want to delete
it if it exists.
- This also requires some changes on Puma side which are being tracked
here - https://github.com/puma/puma/pull/936.
- Fixes #23910.
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
y-yagi/show_correct_command_name_in_help_of_rails_runner
show correct command name in help of rails runner
|
| | |
| | |
| | |
| | |
| | |
| | | |
If use rails together with `spring`, `spring` is rewrite `$0` in the interior
command name. Therefore, for `$0` correct command name does not appear, `$0` has
been modified so that it does not use.
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When generating a plugin without ActiveRecord (-O),
ActionCable wasn't include, which causes problems with the
require action_cable statement in cable.js
add active_job require statement
also updated order of require statements to match with all.rb
|
| |
| |
| |
| |
| | |
Didn't feel we were clear enough about our motivation for placing Rails first
and why we needed to call `load_plugins`.
|
| |
| |
| |
| | |
The useless explicit self calls were driving me nuts.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When calling `load_plugins` minitest would fill out its extensions, then
we'd tackle ourselves on as the last plugin. Because minitest loads plugins
in order we will ultimately have the last say on what reporters will be used.
Invert that strategy by putting ourselves first and give other plugins plenty
of leeway to override our default reporter setup.
Fixes #24179.
|
| | |
|
| |
| |
| |
| |
| |
| | |
In https://github.com/rails/rails/commit/dfa48f200cbc5c1ca18457a8cde14642e12af5,
a call to `#sum` was added. For that to always work, we need to require the
core_ext/enumerable module.
|
|\ \
| | |
| | | |
changed default value of `caching` option to `nil`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The default is that's false, caching even if you do not specify the caching option is determined not to use,
and `tmp/caching-dev.txt` will be deleted.
If it is this, regardless of whether or not there is `tmp/caching-dev.txt`, be sure to order would be necessary to specify the caching option,
I think that in than good to so as not to do anything by default.
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features.
We are also matching the stdout logging interface to the default logger in bootstrap https://github.com/rails/rails/blob/f5a5988352b165143f0f9d622707c351c1470882/railties/lib/rails/application/bootstrap.rb#L42-L45.
|
| |
| |
| |
| |
| | |
Lets have the server and the Rake task go through the same ropes, so we can
share all the file lookup, adding, and deleting code.
|
| |
| |
| |
| |
| |
| |
| | |
If we're gonna do this right, it will look mighty different from this anyway.
(Looking at you, Rails 5.1).
It isn't being used in any code as of now, so yanking is the best option.
|
| | |
|
|\ \
| | |
| | | |
Remove passing `with_dispatchers` to AppGenerator
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- While working on https://github.com/rails/rails/pull/22790 I found out
that we pass `with_dispatchers: true` but it's not used at all by Rails.
- We were passing `with_dispatchers: true` in few tests too but again
it's not used by Rails.
|