aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
* check if @rake_patterns is definedyuuji.yaginuma2015-09-281-1/+2
| | | | | | | This removes the following warning. ``` railties/lib/rails/test_unit/minitest_plugin.rb:45: warning: instance variable @rake_patterns not initialize ```
* stop using deprecated method in mailers controlleryuuji.yaginuma2015-09-232-3/+3
| | | | Accessing mime types via constants is deprecated.
* fix application_controller require_dependency path generated by the scaffold ↵yuuji.yaginuma2015-09-201-1/+1
| | | | | | | generator This is follow up to #6643. In #6643, the controller generator only had been fixed, in this commit to fix the scaffold generator.
* mostly remove the ParamsParser middlewareAaron Patterson2015-09-181-1/+0
| | | | | This can still be added to the middleware stack, but is really not necessary. I'll follow up with a commit that deprecates the constant
* Fix displaying mailer previews on non local requests.Wojciech Wnętrzak2015-09-171-1/+5
| | | | | When config `action_mailer.show_previews` is set, previews are displayed regardless of local request check.
* Bundler tzinfo-data in windows, even first generated new app are MacEric Guo2015-09-151-2/+0
|
* Merge pull request #21568 from amitsuroliya/mysql_version_updateRafael Mendonça França2015-09-132-2/+2
|\ | | | | Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
| * Updated MySQL documentation link to MySQL latest version 5.7 everywhere [ci ↵amitkumarsuroliya2015-09-102-2/+2
| | | | | | | | | | skip] Bumps from `5.6` to `5.7`
* | dev and edge have some common, so factor it out.Eric Guo2015-09-131-10/+7
|/
* Replace AR with ActiveRecord to make it more readable [ci skip]arvind2015-09-081-1/+1
|
* Merge pull request #21519 from y-yagi/test_runner_raise_errorKasper Timm Hansen2015-09-083-7/+16
|\ | | | | raise LoadError when a non-existent file or directory is specified to the test runner
| * modify to pass the correct argument to the test runner from rakeyuuji.yaginuma2015-09-082-6/+15
| | | | | | | | | | | | | | | | test runner sets file to be tested in plugin_rails_options, but in plugin_rails_options, processing has been made to the argument of the actual command rather than the argument of Minitest.run. For example, if you run `./bin rake db:migrate test`, the options[:patterns], `db:migrate test` was incorrectly set.
| * raise LoadError when a non-existent file or directory is specified to the ↵yuuji.yaginuma2015-09-071-1/+1
| | | | | | | | | | | | | | | | test runner Currently, if a file or directory that does not exist was specified in the test runner, that argument is ignored. This commit has been modified to cause an error if there is no file or directory.
* | Fix strange messages for `rails g foo`FUJI Goro (gfx)2015-09-071-1/+1
|/
* make `ENV` a required argumentyuuji.yaginuma2015-08-291-1/+1
|
* remove require of files under support that do not useyuuji.yaginuma2015-08-271-3/+0
| | | | | | I do not know why files under the support has been require. However, under the support even rails application does not use. In addition, since the default under the support file nor is generated, it requires I think not necessary
* Merge pull request #21267 from davidcornu/rails-server-port-env-varRafael Mendonça França2015-08-241-1/+1
|\ | | | | Use the PORT environment variable for rails server
| * Use the PORT environment variable for rails serverDavid Cornu2015-08-181-1/+1
| |
* | smooth move aaron.... :bomb:Aaron Patterson2015-08-201-2/+2
| |
* | point at rack masterAaron Patterson2015-08-201-0/+2
| |
* | fix path of annotations.rake [ci skip]yuuji.yaginuma2015-08-201-1/+1
| |
* | Migrate to Sprockets 4.Andrei Istratii2015-08-195-4/+40
|/
* Fixed syslog example in production config templateprintercu2015-08-171-1/+2
|
* Plugins are generated with the version 0.1.0Daniel Morris2015-08-161-1/+1
| | | | | | The semantic versioning specification uses MAJOR.MINOR.PATCH – it would make more sense to set the version to 0.1.0 for initial development since a patch release cannot be created before a minor feature release.
* Tiny documentation fixes [ci skip]Robin Dupret2015-08-161-4/+2
| | | | | | * Add missing `def` and remove useless `do` keywords. * Move `:nodoc:` in front of the methods' definition so that methods under these ones are correctly visible on the API.
* Merge pull request #21021 from sgrif/sg-no-routes-commentSean Griffin2015-08-121-54/+1
|\ | | | | Replace the giant comment in routes.rb with a link to the guides
| * Replace the giant comment in routes.rb with a link to the guidesSean Griffin2015-07-241-54/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment not only serves no purpose, but in my experience is actively detrimental to new developers getting started with Rails. Expereinced developers just end up deleting this comment, and are annoyed that they had to take this step. I also spend a lot of time mentoring brand new developers, and a consistent theme I've seen is that this comment just ends up intimidating them, and making them think it's dangerous to edit this file. One of my students just said this (due to the number of comments which even new developers don't actually read, they just see it as a sign that this thing is "dangerous"). > I don't edit any file that Rails generates for me, until my instructor > says that it's OK to do so. Realistically, this comment adds 0 value. We have very good documentation, which we can just link to instead. If someone is truly new enough to benefit from this info, they presumably just ran `gem install rails`, and have an internet connection that they can use to read the routing guide. The choice of language here was very specific. I chose "the DSL available" over "what is possible", because a consistent theme I've noticed among my students is that they aren't aware that this is actually a Ruby file, and can write any Ruby code here that they want. This file is not the only offender, but is by far the biggest point of pain that I've seen, and felt it was a good spot to open this discussion.
* | Merge pull request #21124 from kirs/feature/reload-i18nKasper Timm Hansen2015-08-102-1/+11
|\ \ | | | | | | Reload I18n.load_path in development
| * | Reload I18n locales in developmentKir Shatrov2015-08-102-1/+11
| | |
* | | Merge pull request #21176 from y-yagi/fix_scaffold_tests_inside_api_engineRafael Mendonça França2015-08-091-1/+4
|\ \ \ | | | | | | | | make generated scaffold functional tests work inside API engines
| * | | make generated scaffold functional tests work inside API enginesyuuji.yaginuma2015-08-091-1/+4
| | | | | | | | | | | | | | | | | | | | * set engine's route in setup * use fixture with engine namespace
* | | | WhitespacesRafael Mendonça França2015-08-091-1/+1
|/ / /
* | | Fix deprecation warning in testseileencodes2015-08-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the string version of the class reference is now deprecated when referencing middleware. This should be written as a class not as a string. Deprecation warning that this change fixes: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions ```
* | | Added bin/update script to update application automaticallyMehmet Emin İNAÇ2015-08-071-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use system! fix changelog use bundle check first and use rake use system instead system! for bundle check
* | | Only load statistics.rake once from inside engineErsin Akinci2015-08-061-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running rake stats from inside an engine, the engine's Rakefile attempts to reload statistics.rake after the test app loads it, which results in STATS_DIRECTORIES being redefined and an annoying warning. This patch skips loading statistics.rake from tasks.rb if rake's current scope isn't empty, i.e. if we are running from inside an engine and not the test app dir or a normal app. Fixes #20510.
* | | Merge pull request #21043 from ↵Rafael Mendonça França2015-08-061-0/+1
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/loading_fixtures_in_engine_integration_tests set the correct path to `ActionDispatch::IntegrationTest.fixture_path`
| * | | set the correct path to `ActionDispatch::IntegrationTest.fixture_path`yuuji.yaginuma2015-07-281-0/+1
| | |/ | |/| | | | | | | | | | `ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine, path under the dummy is will be set, fixtures under test was not loaded.
* | | stop using deprecated `render :text` in railtiesyuuji.yaginuma2015-08-062-2/+2
| | |
* | | routes in the env via the request objectAaron Patterson2015-08-051-3/+2
| | |
* | | allocate a request object to avoid hash allocationsAaron Patterson2015-08-051-3/+2
| | | | | | | | | | | | | | | This decouples the `call` method from knowing the SCRIPT_NAME key and offloads decisions about how to access script_name
* | | Use exist? instead of deprecated exists?Kasper Timm Hansen2015-08-051-2/+2
| | |
* | | Merge pull request #20961 from ccallebs/add-dev-mode-cachingKasper Timm Hansen2015-08-054-2/+51
|\ \ \ | |_|/ |/| | Add dev caching toggle / server options
| * | Add rake dev:cache task to enable dev mode caching.Chuck Callebs2015-08-044-2/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Taken from @Sonopa's commits on PR #19091. Add support for dev caching via "rails s" flags. Implement suggestions from @kaspth. Remove temporary cache file if server does not have flags. Break at 80 characters in railties/CHANGELOG.md Remove ability to disable cache based on server options. Add more comprehensive options: --dev-caching / --no-dev-caching
* | | Merge pull request #21105 from os97673/allow-minitest-pluginsRafael Mendonça França2015-08-031-0/+1
|\ \ \ | | | | | | | | Allow Minitest to load plugins. Fixes #21102
| * | | Allow Minitest to load plugins. Fixes #21102Oleg Sukhodolsky2015-08-031-0/+1
| | | |
* | | | Inform user to add script in correct location into the application.js ↵Mehmet Emin İNAÇ2015-08-032-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | manifest file [ci skip] use it change the warning
* | | | Revert "test runner should crash with non existing file argument."Yves Senn2015-08-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 465f0fbca3d4a1c269038b84ec9cc248fdab5fab. This breaks some cases where non file / directory arguments are passed to the runner (for example db:migrate). I still think that we can get this to work. From what I can tell there is no reason why db:migrate is passed along to `Minitest.run`. I'll revert and investigate possible solutions.
* | | | Merge pull request #21104 from atul-shimpi/masterYves Senn2015-08-032-2/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Inform user to add styles in correct location in application.css [ci skip]
| * | | | Inform user to add styles in correct location in application.cssatul-shimpi2015-08-032-2/+4
| |/ / /
* / / / test runner should crash with non existing file argument.Yves Senn2015-08-031-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | Before this patch, using `bin/rails test` with a non existing file or directory argument would silently swallow the argument and run the whole test suite. After the patch the command fails with `cannot load such file --`.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 21:49:36 +0000