aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Fix broken alignments caused by auto-correct commit 411ccbdRyuta Kamizono2016-08-101-1/+2
| | | | | | | | | | | | | | | | Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
* | | | code gardening: removes redundant selfsXavier Noria2016-08-0812-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* | | | revises most Lint/EndAlignment offensesXavier Noria2016-08-073-9/+10
| | | | | | | | | | | | | | | | Some case expressions remain, need to think about those ones.
* | | | Merge pull request #24260 from ↵Kasper Timm Hansen2016-08-071-1/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | y-yagi/show_error_message_when_error_raised_in_rails_runner show error message when error raised in rails runner
| * | | | show error message when error raised in rails runneryuuji.yaginuma2016-08-031-1/+3
| | |/ / | |/| |
* | | | Defer requiring Rake until it's needed.Kasper Timm Hansen2016-08-071-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eagerly requiring Rake could put 100ms on to the Rails boot time. Shimmy that down to 0 by requiring Rake when no native Rails command exists and we try to run a Rake task. Or when printing all the Rake commands through `rails help`. Fixes #25029
* | | | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-071-1/+0
| | | |
* | | | Merge pull request #26060 from siong1987/minor/puma-configGuillermo Iguaran2016-08-061-1/+1
|\ \ \ \ | | | | | | | | | | .to_i is unnecessary for puma threads.
| * | | | .to_i is unnecessary.Teng Siong Ong2016-08-041-1/+1
| |/ / /
* | | | applies remaining conventions across the projectXavier Noria2016-08-0613-37/+28
| | | |
* | | | normalizes indentation and whitespace across the projectXavier Noria2016-08-0620-186/+186
| | | |
* | | | remove redundant curlies from hash argumentsXavier Noria2016-08-062-5/+3
| | | |
* | | | modernizes hash syntax in railtiesXavier Noria2016-08-063-18/+18
| | | |
* | | | applies new string literal convention in railties/libXavier Noria2016-08-06104-616/+616
|/ / / | | | | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* | | Show supported DBs first in `rails new --help`Akira Matsuda2016-08-031-5/+5
| | |
* | | Suppress warningsyui-knk2016-07-311-0/+1
| | | | | | | | | | | | | | | | | | | | | This commit suppressed `warning: instance variable @session_store not initialized`. e5a6f7ee9e951dbe0e4e9ea2c0743b4dfb135c57 introduced these warnings.
* | | A generated app should not include Uglifier with `--skip-javascript` option.Ben Pickles2016-07-262-3/+9
| | |
* | | Enforce minimal web-console version for Rails 5Genadi Samokovarov2016-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I dropped the version constraint in web-console with the idea it will be easier to upgrade the console between Rails releases. However, issues like #25899 started popping up. I'm reintroducing the constraint, but this time, I don't set an upper limit to the major version. This will keep the web-console in a version that always works for the current Rails version and can be easily upgraded to the last one with `bundle update`. We may need to backport this for Rails 5.0.1. Fixes #25899.
* | | Merge pull request #25438 from prathamesh-sonpatki/rm-session-store-initializerRafael Mendonça França2016-07-204-15/+25
|\ \ \ | | | | | | | | | | | | Setup default session store internally, no longer through an initializer
| * | | Setup default session store internally, no longer through an application ↵Prathamesh Sonpatki2016-07-174-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | initializer - By default the session store will be set to cookie store with application name as session key. - Older apps are not affected as they will have the session store initializer generated by Rails in older versions, and Rails will not overwrite the session store if it is already set or disabled. - But new apps will not have the initializer, instead the session store will be set to cookie store by default. - Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
| * | | Refactor the existing session_store to use keyword args and raise early when ↵Prathamesh Sonpatki2016-07-171-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | set to activerecord session store - Use keyword args as it is possible to use them now. - The error message for activerecord-session_store gem was added in 1807384. - But it was added for a code path which gets called when we try to **access** the session store, not when we **set** it. - So the test expecting the exception started failing because now the session store is set via railtie again **after** setting it first with :active_record_store in the test. - As the error is not raised while setting the store to :active_record_store, the store gets overwritten by railtie and when we access it via `session_store` while building the default middleware stack, the exception is not raised. - This commit moves the code for raising the exception to the path where we try to set the store.
| * | | Introduce a new method for checking whether session_store is set by user or ↵Prathamesh Sonpatki2016-07-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | by Rails - We need to ability to check whether the session store it is set or not so that we can set it ourselves in an internal initializer. - We can't rely on return value of `config.session_store` as it can return `nil` when set to `disabled` and we will accidentally override it and set to default cookie store. - So introduced new method which just tells us whether it is set or not.
* | | | Merge pull request #25795 from mechanicles/command-importanceGuillermo Iguaran2016-07-131-1/+1
|\ \ \ \ | | | | | | | | | | Give importance to rails command [ci skip]
| * | | | Give importance to rails command in the comment section.Santosh Wadghule2016-07-131-1/+1
| |/ / /
* | | | Merge pull request #25690 from robin850/speed-up-rdocXavier Noria2016-07-121-0/+13
|\ \ \ \ | | | | | | | | | | Speed up RDoc generation when it's already been done once
| * | | | Speed up RDoc generation when it's already been done onceRobin Dupret2016-07-111-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only include files that contain changes since the last generation of the API documentation. Thus, only modified files are re-generated instead of the whole API. The `created.rid` file won't contain the whole list of files anymore if we generate several times the API but we don't really care about it, only the generation date and time is important. It is possible to fall back to the previous behavior by defining the ALL environment variable running the `rake rdoc` task.
* | | | | rails -> Rails [ci skip]Santosh Wadghule2016-07-121-1/+1
| |/ / / |/| | |
* | | | Merge pull request #25688 from mahnunchik/host-env-varGuillermo Iguaran2016-07-081-0/+1
|\ \ \ \ | | | | | | | | | | Use the HOST environment variable for rails server #25677
| * | | | Use the HOST environment variable for rails server #25677Evgeny Vlasenko2016-07-051-0/+1
| |/ / /
* | | | Merge pull request #25704 from ↵Rafael França2016-07-051-0/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | fledman/add_respond_to_missing_to_rails_application_configuration_custom implement respond_to_missing? to match method_missing
| * | | | implement respond_to_missing? to match method_missingDavid Feldman2016-07-051-0/+4
| | | | |
* | | | | Merge pull request #25692 from ↵Rafael França2016-07-051-0/+6
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | johnmeehan/allow-registering-directory-for-rake-notes Allow rake notes to work with other directories.
| * | | | Allow rake notes to work with other directories.John Meehan2016-07-051-0/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | Additional directories can be added using SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir") Result: rake notes will now extract notes from these directories.
* | | | Merge pull request #25257 from ta1kt0me/inspect_initializersRichard Schneeman2016-07-052-1/+5
|\ \ \ \ | | | | | | | | | | Display railtie class name in `rails initializers`
| * | | | Initializer provides its context class nameta1kt0me2016-06-122-3/+5
| | | | |
| * | | | Delegate public method for raitile nameta1kt0me2016-06-112-1/+3
| | | | |
| * | | | Display railtie class name in `rails initializers`ta1kt0me2016-06-021-1/+1
| | |_|/ | |/| |
* | | | Point to the correct documentation [ci skip]Benjamin Quorning2016-07-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The options used in this file are *not* directly described in the Rails 5.0 release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but instead in section 2 of the Guide for Upgrading Ruby on Rails document (http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).
* | | | Robots.txt removed disallow all instructionsSam Sweeney2016-07-051-4/+0
| |/ / |/| |
* | | Merge pull request #25646 from y-yagi/refer_to_rails_command_instead_of_rakeVipul A M2016-07-021-3/+3
|\ \ \ | | | | | | | | refer to rails command instead of rake in doc of `SourceAnnotationExtractor`
| * | | refer to rails command instead of rake in doc of `SourceAnnotationExtractor` ↵yuuji.yaginuma2016-07-021-3/+3
| | | | | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #25222 from vipulnsward/25219-fix-logsMatthew Draper2016-07-022-1/+13
|\ \ \ \ | |/ / / |/| | | Clean backtrace in IRB
| * | | Fixes #25219Vipul A M2016-07-012-1/+13
| | | | | | | | | | | | | | | | Add handling of cleaning up backtrace from IRB console in case of errors
* | | | fix task name to removeyuuji.yaginuma2016-07-021-1/+1
| | | | | | | | | | | | | | | | Follow up to #25431
* | | | Do not run `bundle install` when generating a new plugin.Rafael Mendonça França2016-07-012-2/+2
|/ / / | | | | | | | | | | | | | | | Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
* | | Merge pull request #25431 from ↵Rafael França2016-06-302-1/+10
|\ \ \ | | | | | | | | | | | | | | | | prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update Display link to Rails upgrade guide at the end of `rails app:update` task.
| * | | Display link to Rails upgrade guide at the end of `rails app:update` task.Prathamesh Sonpatki2016-06-302-1/+10
| | | | | | | | | | | | | | | | | | | | - This will nudge people in the direction of going through upgrade guides.
* | | | Merge pull request #25607 from sstephenson/turbolinks-5-finalRafael Mendonça França2016-06-301-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | Update to Turbolinks 5.0.0 final
| * | | | Update to Turbolinks 5.0.0 finalSam Stephenson2016-06-301-1/+1
| |/ / /
* / / / Point to released coffee-railsRafael Mendonça França2016-06-301-1/+1
|/ / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 08:11:42 +0000