aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
* Don't generate HTML/ERB templates for scaffold controller with --api flagPrathamesh Sonpatki2017-01-071-1/+6
| | | | - Fixes #27591.
* `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-058-9/+9
| | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* Revert "Merge pull request #27550 from ↵Rafael Mendonça França2017-01-035-6/+6
| | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API
* Merge pull request #27550 from ↵Rafael França2017-01-035-6/+6
|\ | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine Fix generator command for nested (namespaced) rails engine
| * Fix generator command for nested (namespaced) rails engineFumiaki MATSUSHIMA2017-01-035-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* | Remove deprecated CONTROLLER environment variable for routes taskRafael Mendonça França2017-01-031-7/+0
| |
* | Remove deprecated tasks in railtiesRafael Mendonça França2017-01-031-12/+0
| |
* | Remove deprecated file `rails/rack/debuggerRafael Mendonça França2017-01-031-3/+0
| |
* | Remove deprecated config.serve_static_filesRafael Mendonça França2017-01-031-19/+0
| |
* | Remove deprecated `config.static_cache_control`Rafael Mendonça França2017-01-032-13/+1
| |
* | Merge pull request #24814 from vipulnsward/24811-fix-double-tasksArthur Nogueira Neves2017-01-031-1/+0
|\ \ | | | | | | Don't list out tasks as separately that are under lib, which cause them to be listed twice under Libraries and tasks.
| * | Don't list out tasks as separately that are under lib, which cause them to ↵Vipul A M2016-07-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | be listed twice under Libraries and tasks. We already count and list it under libraries. Fixes #24811
* | | Merge pull request #27435 from kamipo/follow_up_25307Sean Griffin2017-01-032-2/+2
|\ \ \ | |_|/ |/| | Active Record supports MySQL >= 5.1.10
| * | Active Record supports MySQL >= 5.1.10Ryuta Kamizono2016-12-222-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #25307 and #23458. Related with #27422. We are using `information_schema.referential_constraints` since #25307. The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is enough to support >= 5.1.10 at least. MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011. MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013.
* | | Remove bin/yarn if yarn is skipped, tidy up testsPrathamesh Sonpatki2017-01-011-2/+2
| | | | | | | | | | | | | | | | | | - No need to remove bin/yarn separately for API only apps because :skip_yarn is set to true for API only apps. - Added a test for :skip_yarn config.
* | | remove unnecessary `remove_file`yuuji.yaginuma2017-01-011-1/+0
| | | | | | | | | | | | | | | | | | It deletes the `app/mailers` directory itself, it is not necessary to delete the file individually. https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/app_generator.rb#L329
* | | Match Thor's `desc` signature.Kasper Timm Hansen2016-12-311-1/+1
| | | | | | | | | | | | It can also take an options hash.
* | | Prevent command name being printed twice.Kasper Timm Hansen2016-12-311-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Thor would inadvertantly duplicate the command usage because of the help method in a command class. Fixes #26664. [ Yuji Yaginuma & Kasper Timm Hansen ]
* | | remove `skip_bundle` option from plugin generatoryuuji.yaginuma2016-12-312-3/+3
| | | | | | | | | | | | | | | | | | | | | Because `bundle install` is not executed regardless of whether the option is specified or not. Ref: fbd1e98cf983572ca9884f17f933ffe92833632a
* | | Enforce middleware ordering with a test, instead of commentsMatthew Draper2016-12-311-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | We want the actual order to be very predictable, so it's rightly defined in code -- not with an on-the-fly tsort. But we can do the tsort here, and then verify that it matches the implemented ordering. This way we don't leave future readers guessing which parts of the ordering are deliberate and which are arbitrary.
* | | Allow log remote ip addres when config.action_dispatch.trusted_proxies passedLeonid Batizhevsky2016-12-301-1/+2
| | |
* | | Remove needless `ActiveSupport::Deprecation.silence`Ryuta Kamizono2016-12-311-3/+1
| | |
* | | Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-291-0/+1
| | |
* | | Merge branch 'master' into fix_26964Kasper Timm Hansen2016-12-2940-472/+449
|\ \ \
| * \ \ Merge branch 'master' into clear_all_environments_log_by_defaultRafael França2016-12-2965-498/+578
| |\ \ \
| | * | | Fix Rubocop violations and fix documentation visibilityRafael Mendonça França2016-12-281-38/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API.
| | * | | Correct indent-accounting in controller route generationMatthew Draper2016-12-251-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #27447 [Matthew Draper & Yuuji Yaginuma]
| | * | | Privatize unneededly protected methods in RailtiesAkira Matsuda2016-12-2525-135/+136
| | | | |
| | * | | Privatize some methods that were originally protectedAkira Matsuda2016-12-251-25/+27
| | | | |
| | * | | Prefer class << self; def over def self.Akira Matsuda2016-12-251-200/+200
| | | | |
| | * | | `protected` here doesn't protect anythingAkira Matsuda2016-12-251-26/+25
| | | | | | | | | | | | | | | | | | | | there aren't any instance method defined in this class
| | * | | Describe what we are protectingAkira Matsuda2016-12-232-0/+4
| | |/ /
| | * | `ARGV.shift` before calling Rails generatorsJon Moss2016-12-171-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Gems like rspec-rails depend on `ARGV` being shifted, and `scaffold` (for example) not being the first item in `ARGV`. This should allow rspec-rails to be passing on Rails master.
| | * | Remove unused method `namespaced_file_path`Fumiaki MATSUSHIMA2016-12-141-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` $ git grep namespaced_file_path railties/lib/rails/generators/named_base.rb: def namespaced_file_path railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/") ```
| | * | use appropriate type for `rc` optionyuuji.yaginuma2016-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning. ``` Expected boolean default value for '--rc'; got "~/.railsrc" (string) ```
| | * | Don't assign a default to `webpack`.Kasper Timm Hansen2016-12-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Unintentionally makes `--webpack` implied on `rails new apper`. If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`, so we can check for that instead of `"base"`.
| | * | Add option to trigger JS framework-specific installation as part of webpack ↵David Heinemeier Hansson2016-12-121-2/+5
| | | | | | | | | | | | | | | | setup
| | * | Oops!Akira Matsuda2016-12-121-1/+1
| | | | | | | | | | | | | | | | namespace_ladder can be nil here
| | * | :nail_care:Akira Matsuda2016-12-121-2/+2
| | | | | | | | | | | | | | | | Don't expect the caller of this method to know that the return value has an extra " "
| | * | run `webpack` command only when webpack option is specifiedyuuji.yaginuma2016-12-101-1/+1
| | | |
| | * | gemfile entry method need to return an empty array rather than nil (#27318)Yuji Yaginuma2016-12-091-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following error when executing rails new command. ``` (erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError) ``` Follow up to #27288
| | * | Use GitHub webpacker until closer to releaseDavid Heinemeier Hansson2016-12-091-1/+1
| | | |
| | * | Basic --webpack delegation to new webpacker gem (#27288)David Heinemeier Hansson2016-12-092-1/+16
| | | |
| | * | Show message if Yarn is not installed (#27312)Guillermo Iguaran2016-12-091-1/+8
| | | |
| | * | Only have Yarn bundling commented out as we cant be sure Yarn is installedDavid Heinemeier Hansson2016-12-082-5/+2
| | | |
| | * | specify `skip_yarn` option in API-only Application (#27309)Yuji Yaginuma2016-12-081-2/+8
| | | |
| | * | Merge pull request #25051 from bf4/extract_notes_as_binarySean Griffin2016-12-081-1/+1
| | |\ \ | | | | | | | | | | Extract notes as binary
| | | * | Extract notes from files in binaryBenjamin Fleischer2016-09-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevents: ArgumentError: invalid byte sequence in UTF-8 railties/lib/rails/source_annotation_extractor.rb:115:in `=~' railties/lib/rails/source_annotation_extractor.rb:115:in `block in extract_annotations_from' And there's no reason we need to interpret the files as UTF-8 when scanning for annotations. Applies to Rails 4.2 as well.
| | * | | Make Yarn the default, drop default vendor/asset directories (#27300)David Heinemeier Hansson2016-12-088-84/+22
| | | | |
| | * | | Update puma.rbbrchristian2016-12-051-6/+6
| | | | | | | | | | | | | | | Clarifying some of the language/punctuation and removing a couple comma splices.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 00:45:51 +0000