| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
| |
| |
| |
| |
| | |
- Remove sprockets-rails from generated Gemfile as rails has a hard-dependency on it
- Also allow sprockets-rails >= 2.0.0
|
| |\ \
| | |
| | | |
Replace ActionDispatch::Head with Rack::Head.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
I put the wrong path in my last PR by accident. Fixed here. Related to #17742
|
| |/ /
| |
| |
| |
| |
| | |
Currently, the docs uses a syntax that is unclear and not general
American English. I've switched it to be clearer wording. Not a big
fix, but may be helpful.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
We generate a `.keep` file inside the log directory to make
sure the directory itself is under version control. let's keep
it that way.
/cc @matthewd
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
Skip spring install in Cygwin due to fork() bad support.
|
| | |/
| |
| |
| | |
See also: https://www.cygwin.com/faq.html#faq.using.fixing-fork-failures
|
| |\ \
| | |
| | | |
Minor English fixes in docs [ci skip]
|
| | |/ |
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
This is a more conservative approach to 2602a49. Also changed the comment to be
more inline with everything else in the file (describing what the config value
is doing and why). People should just read the docs for alternatives.
|
| |/
|
|
|
|
|
|
|
| |
This reverts commit 2602a49a8600ab52f807599bbd5b1f9c0be4214f, reversing
changes made to 5d7c1057684c377bc2801c8851e99ff11ab23530.
The explicit default was introduced in 21f6d72, so apps created with Rails < 4
have the commented out version, which means that this change would break those
apps.
|
| |\
| |
| | |
Fix Rails::Paths::Path.unshift interface
|
| | | |
|
| |\ \
| |/
|/| |
simplify rake test vs rake test:all
|
| | |
| |
| |
| | |
Renames `rake test:all` to `rake test` by changing old `rake test:run` to previous version of `rake test:all`. Removes old definition of `rake test`. Also renames `rake test:all:db` to `rake test:db` and deprecates `rake test:all` & `rake test:all:db`
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Replaces the following in two places:
```diff
-require ::File.expand_path('../config/environment', __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
```
|
| | |
| |
| |
| | |
Just prefer secrets over config
|
| |\ \
| | |
| | |
| | | |
Allow fallback to LegacyKeyGenerator when secret_key_base is not set but secrets.secret_token is
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- `secrets.secret_token` is now used in all places `config.secret_token` was
- `secrets.secret_token`, when not present in `config/secrets.yml`,
now falls back to the value of `config.secret_token`
- when `secrets.secret_token` is set, it over-writes
`config.secret_token` so they are the same (for backwards-compatibility)
- Update docs to reference app.secrets in all places
- Remove references to `config.secret_token`, `config.secret_key_base`
- Warn that missing secret_key_base is deprecated
- Add tests for secret_token, key_generator, and message_verifier
- the legacy key generator is used with the message verifier when
secrets.secret_key_base is blank and secret_token is set
- app.key_generator raises when neither secrets.secret_key_base nor
secret_token are set
- app.env_config raises when neither secrets.secret_key_base nor
secret_token are set
- Add changelog
Run focused tests via
ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
|
| | | |
| | |
| | |
| | | |
active_support/notifications [ci skip]
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Commit(810af6f) changed which extensions are taken into account,
so make to match comment of find_in.
And sort extensions to follow the added order.
|
| | | | |
|
| | | | |
|
| |/ / |
|
| | | |
|
| | |
| |
| |
| | |
800 pixels, and the full available screen size is not being used.
|
| |\ \
| | |
| | | |
Added 'tzinfo-data' if we are using jruby
|
| | | | |
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch uniformizes warning messages. I used the most common style
already present in the code base:
* Capitalize the first word.
* End the message with a full stop.
* "Rails 5" instead of "Rails 5.0".
* Backticks for method names and inline code.
Also, converted a few long strings into the new heredoc convention.
|
| |/
|
|
|
|
|
| |
For the most part of cases --skip-gems option just remove one line in
the Gemfile. This is not worth for the complexity it adds.
Closes #17196
|
| |
|
|
|
|
| |
claudiob/replace-slower-block-call-with-faster-yield
Replace (slower) block.call with (faster) yield
|
| |
|
|
| |
This reverts commit 0ab075e75f58bf403f7ebe20546c7005f35db1f6.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Performance optimization: `yield` with an implicit `block` is faster than `block.call`.
See http://youtu.be/fGFM_UrSp70?t=10m35s and the following benchmark:
```ruby
require 'benchmark/ips'
def fast
yield
end
def slow(&block)
block.call
end
Benchmark.ips do |x|
x.report('fast') { fast{} }
x.report('slow') { slow{} }
end
# => fast 154095 i/100ms
# => slow 71454 i/100ms
# =>
# => fast 7511067.8 (±5.0%) i/s - 37445085 in 4.999660s
# => slow 1227576.9 (±6.8%) i/s - 6145044 in 5.028356s
```
|
| |\
| |
| | |
Fix example code for `Rails::Generators::Testing::Behaviour` [ci skip]
|
| | |
| |
| |
| |
| | |
`cleanup_destination_root` method is not found anywhere.
Instead, `prepare_destination` clean up distination root on setup.
|
| |/ |
|
| |\
| |
| | |
clarify debugger platform invocation
|
| | | |
|
| |\ \
| | |
| | | |
remove unneeded file from Railties.
|
| | |/ |
|
| |/ |
|
| |\
| |
| | |
fix test_helper for mountable plugin
|
| | | |
|
| | | |
|
| |/ |
|
