aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
* Add missing type reference hereZachary Scott2015-05-241-1/+1
|
* Omit .keep in .gitignore when generated with --skip-keeps.Ben Pickles2015-05-222-1/+7
|
* [ci skip] Remove comments about Rails 3.1claudiob2015-05-112-11/+8
| | | | | | | | | Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939 where @senny said: > From my point of view, all the docs (guides, API) are version bound. > They should describe that version and continue to be available when newer versions are released. > The cross referencing can be done by the interested user.
* Refactor railties console and dbconsole commandsMehmet Emin İNAÇ2015-05-103-101/+99
| | | | fix minor convention problems
* require object/blank not usedAnkit Gupta2015-05-061-1/+0
| | | | the current class is not the blank?, present? as well as other inheriting, the test suite runs
* Merge pull request #20023 from mohnish/patch-1Yves Senn2015-05-061-2/+1
|\ | | | | | | Use the built-in rake tasks
| * Use the built-in rake tasksMohnish Thallavajhula2015-05-041-2/+2
| | | | | | Use the `log:clear` and `tmp:clear` rake tasks in the setup file template
* | list reserved words in generator errorSean Linsley2015-05-052-2/+2
| |
* | Merge pull request #19756 from georgemillo/docsRobin Dupret2015-05-051-17/+26
|\ \ | |/ |/| fixing English in Rails::Engine docs
| * fixing English in Rails::Engine docsGeorge Millo2015-04-231-17/+26
| | | | | | | | [ci skip]
* | Fix URI.escape is obsolete warningsAndrew White2015-05-051-1/+1
| |
* | Tiny documentation edits [ci skip]Robin Dupret2015-05-041-2/+3
| | | | | | | | | | | | * Fix a few typos * Wrap lines to 80 chars * Use `+` instead of `<tt>`
* | Improve display of attachment names in mailer previewsAndrew White2015-05-041-1/+1
| | | | | | | | | | Display attachment filenames as a comma separated list rather than showing the inspect output for the array.
* | Fix mailer previews with attachmentsAndrew White2015-05-042-7/+9
| | | | | | | | | | | | Use the mail gem's own API to locate the correct part. Fixes #14435.
* | Remove unused private classesRafael Mendonça França2015-05-031-126/+0
| | | | | | | | | | | | | | The usage of these classes where removed at 8017e6af31caa58a58787274ff0ca01397219e49. cc @arthurnn @senny
* | Merge pull request #19093 from ↵Rafael Mendonça França2015-05-032-3/+3
|\ \ | | | | | | | | | | | | remomueller/fix-actionmailer-preview-links-on-subdirectories Mailer preview now uses `url_for` to fix links to emails for apps runnin...
| * | Mailer preview now uses `url_for` to fix links to emails for apps running on ↵Remo Mueller2015-04-302-3/+3
| | | | | | | | | | | | a subdirectory, closes #19092.
* | | Merge pull request #19976 from prathamesh-sonpatki/rm-assignsRafael Mendonça França2015-05-031-3/+2
|\ \ \ | | | | | | | | Removed `assigns` from functional_test templates
| * | | Removed `assigns` from functional_test templatesPrathamesh Sonpatki2015-05-021-3/+2
| |/ / | | | | | | | | | | | | - Based on DHH's suggestion about deprecating `assigns` in https://github.com/rails/rails/pull/18305#issuecomment-68605166.
* | | Use `def before_setup` instead of `setup do`eileencodes2015-05-021-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `setup do` creates unnecessary allocations of proc objects in test callbacks. This prevents that from happening and results in faster code. Originally I had done this as `def setup` and all Railties tests passed. See 044f9ab. Later it was reported there was an issue with this that caused routes in tests to be nil because devs don't generally call `super` in their test setups. Because of that I reverted the commit until I could find a suitble replacement. `before_setup` esentially does the same thing but without the requirement that applications call `super` in their test setups.
* | | Added missing fullstop in engine API docs [ci skip]Prathamesh Sonpatki2015-05-021-2/+2
|/ /
* | mailer previews for `NullMail` instances. Closes #19849.Yves Senn2015-04-282-6/+13
| |
* | mailer previews, make sure labels and values line up.Yves Senn2015-04-281-0/+4
| | | | | | | | | | | | While this was true before when every `dd` had a value, this patch makes sure that everything keeps lining up even when the `dd` node is blank.
* | Escape README in Plugin builder API documentationPrathamesh Sonpatki2015-04-261-1/+1
| | | | | | | | | | - So that RDoc will not generate link for README. [ci skip]
* | Do not show --helper and --assets options in the controller generator helpAkira Matsuda2015-04-251-1/+2
| | | | | | | | | | These options are not actually available. Thanks @soutaro for letting me aware of this.
* | Merge pull request #19236 from sshaw/more_tagged_logging_docsYves Senn2015-04-241-0/+3
|\ \ | | | | | | More docs on tagged logging [ci skip]
| * | Refer to the constructer argument in docsSkye Shaw2015-04-241-1/+1
| | |
| * | More docs on tagged logging [ci skip]sshaw2015-03-061-0/+3
| | | | | | | | | | | | | | | Mention that tags can also come from a Proc that accepts the request object or something's to_s method
* | | Fix CSS formatting in welcome#index.html.erbSean Collins2015-04-231-3/+10
| |/ |/|
* | Require yaml before trying to rescue its exception classRafael Mendonça França2015-04-221-1/+1
| |
* | Remove sqlite support from `rails dbconsole`Andrew White2015-04-221-3/+0
| | | | | | | | | | | | Support for versions of SQLite less than 3 was removed in #6011 as part of the Rails 4.0 release. Therefore there is no need to have support for it in the `rails dbconsole` command anymore.
* | Don't ask something that we don't want toRafael Mendonça França2015-04-221-1/+1
| | | | | | | | | | | | We only want to support adapters that we officially support through the entire framework so it is better to not ask patches for adapters that we may not support
* | Merge pull request #19858 from cllns/fix-scaffolding-css-formattingRafael Mendonça França2015-04-221-7/+20
|\ \ | | | | | | Fix formatting of scaffold css
| * | Fix formatting of scaffold cssSean Collins2015-04-221-7/+20
| | |
* | | Add blank lines between divs in form scaffoldingSean Collins2015-04-201-0/+2
|/ /
* | Implicitly skip spring for `rails new --dev`Godfrey Chan2015-04-201-1/+1
| | | | | | | | | | | | Spring seems like an obvious foot gun for the `--dev` setup, presumably you are about to make lots of changes to the codebase, so it should always reload the framework.
* | [ci skip] Document running a rake command as a rails commandNick Cox2015-04-151-0/+11
| |
* | Merge pull request #19751 from y-yagi/fix_indent_of_controllerAndrew White2015-04-141-3/+4
|\ \ | | | | | | fix indent in routes when using namespaced controllers
| * | fix indent in routes when using namespaced controllersyuuji.yaginuma2015-04-141-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: namespace :foo do namespace :bar do get 'baz/index' end end After: namespace :foo do namespace :bar do get 'baz/index' end end
* | | Merge pull request #19753 from jonatack/use-ruby-2-2-2Guillermo Iguaran2015-04-131-3/+3
|\ \ \ | |/ / |/| | Upgrade to Ruby 2.2.2
| * | Upgrade to Ruby 2.2.2Jon Atack2015-04-141-3/+3
| | | | | | | | | | | | and fix the grammar in the ruby_version_check.rb user message.
* | | Error message no longer tells you to set the (deprecated) secret_token.Dan2015-04-121-1/+1
| | |
* | | Speed up Levenshtein by 50% and reduce 97% of memory usageYuki Nishijima2015-04-111-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calculating ------------------------------------- each_char 924.000 i/100ms each_codepoint 1.381k i/100ms ------------------------------------------------- each_char 9.320k (¡Þ 5.1%) i/s - 47.124k each_codepoint 13.857k (¡Þ 3.6%) i/s - 70.431k Comparison: each_codepoint: 13857.4 i/s each_char: 9319.5 i/s - 1.49x slower The full report can be found here: https://gist.github.com/yuki24/a80988f35aceac76f1d5
* | | bugfix CodeStatics#calculate_directory_statics when dir has source extensionPablo Vizcay2015-04-091-4/+2
| | |
* | | Avoid to define an initializer after the load_config_initializersRafael Mendonça França2015-04-071-1/+1
| | | | | | | | | | | | | | | This make the config/initializers run before the railties are loaded what can break some configurations.
* | | Merge pull request #19429 from mxhold/print_bundle_install_output_line_by_lineMatthew Draper2015-04-031-6/+6
|\ \ \ | | | | | | | | | | | | Print `bundle install` output in `rails new` as soon as it's available
| * | | Print `bundle install` output in `rails new` as soon as it's availableMax Holder2015-03-281-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, running `rails new` would not print any of the output from `bundle install` until all the gems had finished installing. This made it look like the generator was hanging at the `bundle install` step. This commit switches to using `system` so that the bundle command can output as it needs to. This has the added benefit of including output bundler produces on standard error, which the previous code ignored since backticks only capture standard out. This is not a big deal right now since bundler does not currently print errors to standard error, but that may change in the future (see: bundler/bundler/issues/3353).
* | | | remove extra newline from ApplicationJob templateyuuji.yaginuma2015-03-311-1/+0
| |/ / |/| |
* | | Merge pull request #19034 from jvanbaarsen/explicit-job-base-classMatthew Draper2015-03-301-0/+3
|\ \ \ | | | | | | | | | | | | Add explicit base class for ActiveJob jobs
| * | | Add explicit base class for ActiveJob jobsJeroen van Baarsen2015-03-231-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Jobs generated now inherent from ApplicationJob * ApplicationJob inherents from ActiveJob::Base * Added entry to changelog Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>