| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |/ / /
| |/| | |
| | | | |
| | | | | |
Ref: https://github.com/rails/rails/blob/a8217bb594a625fb46a6af1488c0bde4aeac4986/railties/lib/rails/generators/rails/app/templates/config/storage.yml#L24
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
intrip/30049-application-controller-renderer-defaults-automatic-reload-in-dev
Fix ApplicationController.renderer.defaults overriding in development
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously overriding ApplicationController.renderer.defaults wasn't
working effectively in development. In fact the override was unset every
time the code was reloaded. The solution is to wrap the code in a
`.to_prepare` block.
|
|\ \ \ \
| | | | |
| | | | | |
Fix dummy_app configuration
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Use `with_dummy_app?` in gitignore
|
| |/ / / |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since Rails 4.0, `config.ru` generated by default uses instances of
`Rails.application`. Therefore, I think that it is good to deprecate
the old behavior.
Related: #9669
|
|/ / |
|
| | |
|
|\ \
| | |
| | | |
Add Active Storage to Rails
|
| | |
| | |
| | |
| | | |
And deal with a temporary test fix until we allow you to skip active storage.
|
| |\ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
With Active Storage supporting Azure, we should show people how to set it up.
Incorporates the minor changes originally in https://github.com/rails/activestorage/pull/88 as well
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
y-yagi/use_assert_nil_if_value_is_nil_in_assert_field_default_value_
Use `assert_nil` if `value` is nil in `assert_field_default_value`
|
| | |/ /
| |/| |
| | | |
| | | |
| | | | |
It is deprecate to specify nil for expect argument of `assert_equal`.
Ref: https://github.com/seattlerb/minitest/commit/922bc9151a622cb3ef0b9f170aa09c3bb72c7eb8
|
|\ \ \ \
| | | | |
| | | | | |
Remove extra empty line
|
| | |/ /
| |/| | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Improve bundler binstub error message
|
| | | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rails displays an error message if you have a bundler-generated binstub
at `./bin/rails` instead of a Rails-generated binstub.
This error message is misleading because it makes it seem as though
Rails 5 introduced recent changes in how binstubs are used, when these
changes were actually introduced way back in Rails 4.
The suggested upgrade steps are appropriate for an app that was created
in Rails 3, but they likely aren't the correct fix for someone who sees
this error message today on a modern app. I believe the `--binstubs`
option on bundler is a more likely culprit and troubleshooting path.
|
|\ \ \
| | | |
| | | | |
Use duktape gem as default JS engine on Windows-MINGW
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The fallback javascript engine on Windows is Windows Script Host (JScript).
However this engine isn't able to process the default assets, because it supports
ES3 only but the coffeescript compiler requires ES5.
Fixes #30014
|
|\ \ \
| | | |
| | | | |
Remove unnecessary `doc` directory deletion
|
| | |/
| |/|
| | |
| | | |
Since 553b695, `doc` directory is not created in application.
|
|\ \ \
| | | |
| | | | |
[ci skip] Fix rails_command comments
|
| | |/
| |/| |
|
| |/
|/| |
|
|/ |
|
|\ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Solves #29923
This regression was caused due to a wrong regex to filter out
paths, introduced in commit 796a1cf0e
The regex was /^\w+\// which did not accept paths with a leading
slash and hence all absolute paths were filtered out.
This change introduces a change in regex which allows for a leading
slash and acts on the matched term accordingly.
While cascading through the case block, the paths are checked for
line number specification, existence of a directory at that path
and if none of those match, then it is considered to be a path to the
file. The regex matchers specified are filtered out via the call
to `Array#compact` since they do not match any of these conditions.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating models, we created ApplicationRecord in the default
location if no file existed there. That was annoying for people who
moved it to somewhere else in the autoload path. At this point, the
vast majority of apps should have either run the upgrade script or
generated a model since upgrading. For those that haven't the error
message after generating a new model should be helpful:
NameError: uninitialized constant ApplicationRecord
To ease friction in that case, this also adds a generator for
ApplicationRecord.
|
|\
| |
| | |
Do not show URL in boot info when using Puma
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Puma has its own configuration file(e.g. `config/puma.rb`).
Can define a port and a URL to bind in the configuration file. Therefore,
on Rails side, can not grasp which URI to bind finally.
Because of that, it may show a URL different from the actually bound
URL, so I think that it is better not to show it.
Fixes #29880
|
|\ \
| | |
| | | |
Move generator namespacing to Base
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Generators need to be aware of namespace to work properly in engines.
Methods to help with this lived in Rails::Generators::NamedBase. Moving
them to Rails::Generators::Base (which NamedBase inherits from) allows a
follow-up in which a namespace aware unnamed generator can be created.
|
| | | |
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I've used many development related performance tools, but the single most consistently helpful tool is `rack-mini-profiler`.
The tool provides a lightweight UI element for each page, that shows the server response time. When clicked it expands to show more detail:
![](https://www.dropbox.com/s/0aciw4mk8c059n0/Screenshot%202017-07-24%2010.24.24.png?dl=1)
This can be used to detect expensive queries, N+1 issues and general performance related problems.
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in Rails 4.0, you could use `/dev/stdin` on both Linux and Mac, but with
the switch to Kernel.load in Rails 4.1, this broke on Linux (you get
a LoadError). Instead, explicitly detect `-` as meaning stdin, then
read from stdin explicitly, instead of performing file gymnastics. This
should now work on any platform uniformly.
Passing a script via stdin is useful when you're sshing to a server,
and the script you want to run is stored locally. You could theoretically
pass the entire script on the command line, but in reality you'll run
into problems with the command being too long.
|
|
|
|
|
|
| |
Bootsnap precomputes load path resolution and caches ruby ISeq
and YAML parsing/compilation, reducing application boot time by
approximately 50% on supported configurations.
|
|
|
|
|
|
|
| |
Since #29725, load application file when `dbconsole` command is executed.
However, if do not set `RAILS_ENV` before reading the application file,
can not connect to the env specified in option, so added the setting
of `RAILS_ENV`.
|