aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
* Use `def before_setup` instead of `setup do`eileencodes2015-05-021-2/+4
| | | | | | | | | | | | | | `setup do` creates unnecessary allocations of proc objects in test callbacks. This prevents that from happening and results in faster code. Originally I had done this as `def setup` and all Railties tests passed. See 044f9ab. Later it was reported there was an issue with this that caused routes in tests to be nil because devs don't generally call `super` in their test setups. Because of that I reverted the commit until I could find a suitble replacement. `before_setup` esentially does the same thing but without the requirement that applications call `super` in their test setups.
* Added missing fullstop in engine API docs [ci skip]Prathamesh Sonpatki2015-05-021-2/+2
|
* mailer previews for `NullMail` instances. Closes #19849.Yves Senn2015-04-282-6/+13
|
* mailer previews, make sure labels and values line up.Yves Senn2015-04-281-0/+4
| | | | | | While this was true before when every `dd` had a value, this patch makes sure that everything keeps lining up even when the `dd` node is blank.
* Escape README in Plugin builder API documentationPrathamesh Sonpatki2015-04-261-1/+1
| | | | | - So that RDoc will not generate link for README. [ci skip]
* Do not show --helper and --assets options in the controller generator helpAkira Matsuda2015-04-251-1/+2
| | | | | These options are not actually available. Thanks @soutaro for letting me aware of this.
* Merge pull request #19236 from sshaw/more_tagged_logging_docsYves Senn2015-04-241-0/+3
|\ | | | | More docs on tagged logging [ci skip]
| * Refer to the constructer argument in docsSkye Shaw2015-04-241-1/+1
| |
| * More docs on tagged logging [ci skip]sshaw2015-03-061-0/+3
| | | | | | | | | | Mention that tags can also come from a Proc that accepts the request object or something's to_s method
* | Fix CSS formatting in welcome#index.html.erbSean Collins2015-04-231-3/+10
| |
* | Require yaml before trying to rescue its exception classRafael Mendonça França2015-04-221-1/+1
| |
* | Remove sqlite support from `rails dbconsole`Andrew White2015-04-221-3/+0
| | | | | | | | | | | | Support for versions of SQLite less than 3 was removed in #6011 as part of the Rails 4.0 release. Therefore there is no need to have support for it in the `rails dbconsole` command anymore.
* | Don't ask something that we don't want toRafael Mendonça França2015-04-221-1/+1
| | | | | | | | | | | | We only want to support adapters that we officially support through the entire framework so it is better to not ask patches for adapters that we may not support
* | Merge pull request #19858 from cllns/fix-scaffolding-css-formattingRafael Mendonça França2015-04-221-7/+20
|\ \ | | | | | | Fix formatting of scaffold css
| * | Fix formatting of scaffold cssSean Collins2015-04-221-7/+20
| | |
* | | Add blank lines between divs in form scaffoldingSean Collins2015-04-201-0/+2
|/ /
* | Implicitly skip spring for `rails new --dev`Godfrey Chan2015-04-201-1/+1
| | | | | | | | | | | | Spring seems like an obvious foot gun for the `--dev` setup, presumably you are about to make lots of changes to the codebase, so it should always reload the framework.
* | [ci skip] Document running a rake command as a rails commandNick Cox2015-04-151-0/+11
| |
* | Merge pull request #19751 from y-yagi/fix_indent_of_controllerAndrew White2015-04-141-3/+4
|\ \ | | | | | | fix indent in routes when using namespaced controllers
| * | fix indent in routes when using namespaced controllersyuuji.yaginuma2015-04-141-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: namespace :foo do namespace :bar do get 'baz/index' end end After: namespace :foo do namespace :bar do get 'baz/index' end end
* | | Merge pull request #19753 from jonatack/use-ruby-2-2-2Guillermo Iguaran2015-04-131-3/+3
|\ \ \ | |/ / |/| | Upgrade to Ruby 2.2.2
| * | Upgrade to Ruby 2.2.2Jon Atack2015-04-141-3/+3
| | | | | | | | | | | | and fix the grammar in the ruby_version_check.rb user message.
* | | Error message no longer tells you to set the (deprecated) secret_token.Dan2015-04-121-1/+1
| | |
* | | Speed up Levenshtein by 50% and reduce 97% of memory usageYuki Nishijima2015-04-111-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calculating ------------------------------------- each_char 924.000 i/100ms each_codepoint 1.381k i/100ms ------------------------------------------------- each_char 9.320k (¡Þ 5.1%) i/s - 47.124k each_codepoint 13.857k (¡Þ 3.6%) i/s - 70.431k Comparison: each_codepoint: 13857.4 i/s each_char: 9319.5 i/s - 1.49x slower The full report can be found here: https://gist.github.com/yuki24/a80988f35aceac76f1d5
* | | bugfix CodeStatics#calculate_directory_statics when dir has source extensionPablo Vizcay2015-04-091-4/+2
| | |
* | | Avoid to define an initializer after the load_config_initializersRafael Mendonça França2015-04-071-1/+1
| | | | | | | | | | | | | | | This make the config/initializers run before the railties are loaded what can break some configurations.
* | | Merge pull request #19429 from mxhold/print_bundle_install_output_line_by_lineMatthew Draper2015-04-031-6/+6
|\ \ \ | | | | | | | | | | | | Print `bundle install` output in `rails new` as soon as it's available
| * | | Print `bundle install` output in `rails new` as soon as it's availableMax Holder2015-03-281-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, running `rails new` would not print any of the output from `bundle install` until all the gems had finished installing. This made it look like the generator was hanging at the `bundle install` step. This commit switches to using `system` so that the bundle command can output as it needs to. This has the added benefit of including output bundler produces on standard error, which the previous code ignored since backticks only capture standard out. This is not a big deal right now since bundler does not currently print errors to standard error, but that may change in the future (see: bundler/bundler/issues/3353).
* | | | remove extra newline from ApplicationJob templateyuuji.yaginuma2015-03-311-1/+0
| |/ / |/| |
* | | Merge pull request #19034 from jvanbaarsen/explicit-job-base-classMatthew Draper2015-03-301-0/+3
|\ \ \ | | | | | | | | | | | | Add explicit base class for ActiveJob jobs
| * | | Add explicit base class for ActiveJob jobsJeroen van Baarsen2015-03-231-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Jobs generated now inherent from ApplicationJob * ApplicationJob inherents from ActiveJob::Base * Added entry to changelog Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* | | | Replace `in Rails 4` with `in Rails %version%` in deprecation messageKir Shatrov2015-03-291-1/+2
| | | |
* | | | respect `pluralize_table_names` when generate fixture file. fixes #19519yuuji.yaginuma2015-03-272-1/+5
| | | |
* | | | Actually rename to `rake initializers`Godfrey Chan2015-03-211-1/+1
| |/ / |/| |
* | | Merge pull request #19441 from y-yagi/use_existArthur Nogueira Neves2015-03-211-1/+1
|\ \ \ | | | | | | | | use `Dir.exist?` instead of deprecated `Dir.exists?`
| * | | use `Dir.exist?` instead of deprecated `Dir.exists?`yuuji.yaginuma2015-03-211-1/+1
| | | |
* | | | Merge pull request #19445 from prathamesh-sonpatki/rm-ostructArthur Nogueira Neves2015-03-211-1/+0
|\ \ \ \ | | | | | | | | | | Removed requiring ostruct because its unused
| * | | | Removed requiring ostruct because its unusedPrathamesh Sonpatki2015-03-211-1/+0
| |/ / /
* / / / Fix typos in test runner's help outputPrathamesh Sonpatki2015-03-211-2/+2
|/ / /
* | | Revert "Use `def setup` instead of `setup do`"eileencodes2015-03-201-4/+2
| | | | | | | | | | | | This reverts commit 044f9ab7a4d6646ddce4560bb83b58cdc0baa751.
* | | `rake initializer` -> `rake initializers`Godfrey Chan2015-03-202-2/+2
| | | | | | | | | | | | | | | | | | Also edited the copy to be more consistent with `rake routes`. See #19323.
* | | Revert "Merge pull request #19404 from dmathieu/remove_rack_env"Jeremy Kemper2015-03-204-4/+4
| | | | | | | | | | | | | | | | | | | | | Preserving RACK_ENV behavior. This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
* | | Remove `#build_original_fullpath` methodeileencodes2015-03-201-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removing `#build_original_fullpath` because it is no longer used by the Rails' source code or called in the `#call` method becasue the previous commit now uses `fullpath` from Rack. The method was nodoc'ed so it's safe to remove. NOTE: I did this as a separate commit so if this does cause a problem with engines etc reverting is easy.
* | | Use fullpath from Rack request rather than building iteileencodes2015-03-201-11/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Rack, `#fullpath` checks if there is a query string and builds the query correctly: ``` def path script_name + path_info end def fullpath query_string.empty? ? path : "#{path}?#{query_string}" end ``` We can utilize this instead of manually building the fullpath because they are the same result. This also reduces allocations in `#call` because we don't need `build_original_fullpath` to create the paths and query strings. We don't need to build `fullpath` twice.
* | | Updated MySQL documentation link to MySQL latest version 5.6 everywhere [ci ↵amitkumarsuroliya2015-03-192-2/+2
| | | | | | | | | | | | skip]
* | | Merge pull request #19404 from dmathieu/remove_rack_envAaron Patterson2015-03-194-4/+4
|\ \ \ | | | | | | | | Don't fallback to RACK_ENV when RAILS_ENV is not present
| * | | don't fallback to RACK_ENV when RAILS_ENV is not presentDamien Mathieu2015-03-194-4/+4
| |/ /
* | | Use absolute path on find_method location for the runnerArthur Neves2015-03-191-1/+1
| | |
* | | Fix test rake when passing multiple argumentsArthur Neves2015-03-191-2/+2
| | | | | | | | | | | | bundle exec db:migrate rake was not working, with the new runner, before this commit
* | | method_source needs to be a hard dependency on railtiesArthur Neves2015-03-191-4/+0
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 06:24:42 +0000