| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / / /
| | | | |
| | | | |
| | | | | |
refs: #28011
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
mtsmfm/fix-generator-command-for-nested-rails-engine-take-2
Fix generator command for nested (namespaced) rails engine (take 2)
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rewrite https://github.com/rails/rails/pull/27550
085546df45 was reverted (b6ffb5efcb) because it change the return of `namespaced_path` from String to Array.
----------------
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
| | | | |
| | | | |
| | | | |
| | | | | |
empty lines
|
| | | | | |
|
| |_|/ /
|/| | | |
|
|\ \ \ \
| | | | |
| | | | | |
Collect all file patterns when running multiple rake test tasks
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Replaces the rake_patterns instance variable with simple require, as
`autorun` will run tests from all eagerly required test files.
Fixes #27801
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Ignore yarn error log file
|
| |/ / / / |
|
|/ / / /
| | | |
| | | |
| | | | |
If already have layout files, in many cases use it.
|
|\ \ \ \
| | | | |
| | | | | |
Added warning for reserved YAML keywords.
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
Update i18n.md
Addressed Feedback
|
|\ \ \ \
| | | | |
| | | | | |
Fully initialize routes before the first request is handled
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`AD::Journey::GTG::Simulator` is lazily built the first time
`Journey::Router#find_routes` is invoked, which happens when
the first request is served.
On large applications with many routes, building the simulator
can take several hundred milliseconds (~700ms for us).
Triggering this initialization during the boot process reduces
the impact of deploys on the application response time.
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
add warnings option to test runner
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove unreachable code
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`app_path` is a required argument. Therefore, if `app_path` is not
specified, it becomes an error in thor's option parsing, does not reach
this check.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
When specifying the `pretend` option, expect that no processing will be
done, so do not execute `git init` as well.
|
| | | |
| | | |
| | | |
| | | | |
tool like Capistrano and we dont need the play-by-play
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Follow up to b1c08d8d9b921fdcf3813b5c20a0c3fab96eccca
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Initalize git repo when creatin new rails app
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* If `--skip-git` is not specified initalize git repo
when creating new rails app
|
|\ \ \ \ \
| | | | | |
| | | | | | |
match indentations in environment template
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
allow to pass describe option to rake
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Since `Thor::HELP_MAPPINGS` contains `-D`, so `bin/rails -D` show
rails's help. But, in Rails 5.0.1, `bin/rails -D` show the description
of rake task. I think that it is better to have the same behavior.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Install Byebug gem as default in Windows (mingw and x64_mingw) platform.
|
| | | | | | | | |
|
| |/ / / / / / |
|
| | | | | | | |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
that as a dependency for assets:precompile
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Make all rails commands work in engine
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Currently, all rails commands can be executed in engine,
but `server`, `console`, `dbconsole` and `runner` do not work.
This make all rails commands work in engine.
Related to #22588
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`TestTask` add `lib` directory by default.
Ref: https://github.com/ruby/rake/blob/master/lib/rake/testtask.rb#L39..L41
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
it has some methods that override the accessors and calls the original accessors via `super`
this partially reverts 9360b6be63b7a452535699bcf6ae853df7f5eea7
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | | |
because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
(I personally prefer writing one string in one line no matter how long it is, though)
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
remove unused requires
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
Related to 0129ca2eeb6d5b2ea8c6e6be38eeb770fe45f1fa, f7782812f7e727178e4a743aa2874c078b722eef, f9ed83321ac1d1902578a0aacdfe55d3db754219
|
|\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
Conflicts:
railties/lib/rails/generators.rb
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|