| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | | |
about old apps and how you can upgrade to new defaults.
[Kasper Timm Hansen, Prathamesh Sonpatki]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
request_forgery_protection configs
- Earlier per_form_csrf_tokens and request_forgery_protection config
files were generated for old apps upgraded to Rails 5.
- But when we collapsed all initializers into one file, the entire file
does not get created for old apps.
- This commit fixes it and also changes values for all new defaults for
old apps so that they will not break.
- Also added a test for `rails app:update`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Move real new default options to the top of the file.
- After that club together all the options which were added to keep
backward compatibility. So all of them will get only one header.
- Based on https://github.com/rails/rails/pull/25231#issuecomment-222945173.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
guides/source/action_cable_overview.md
|
| |/ /
| | |
| | |
| | | |
http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#english
|
| |/
|/| |
|
|\ \
| | |
| | | |
Collapse all new default initializers into a single file
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Adjusted tests also for this new behavior.
- Based on the discussion in
https://github.com/rails/rails/pull/25184#issuecomment-222454583.
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
- These initializers are new defaults for Rails 5 and newly generated
apps do not need to change them.
- Fixes #25181
|
|\ \
| | |
| | | |
Remove public/ files for API apps
|
| | |
| | |
| | |
| | | |
- Fixes #25180
|
| | | |
|
| | |
| | |
| | |
| | | |
second is now irrelevant with the dedicated API mode
|
|/ / |
|
|\ \
| | |
| | | |
Use RAILS_MAX_THREADS as pool size on all adapters
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When RAILS_MAX_THREADS is set, the postgresql adapter uses it as the
connection pool size, so that there are always enough connections
available to serve Action Cable requests.
The same logic applies when using any other adapter.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Un-hide helper and assets options for controller generator
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
These options were hidden via 9b36cf0fa4cbdcb2e2072ef1b8179a98b13efce3,
but these options have tests written for them, and I believe that they
are supposed to be public API.
Fixes #24168.
|
| | | |
| | | |
| | | |
| | | | |
environments
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
javascript engine of the application
- Now we will detect what javascript engine user is using and based on
that we will generate either `.js` or `.coffee` version of the channel
file.
- This also needs a change in coffee-rails to override the `js_template`
method. Related PR https://github.com/rails/coffee-rails/pull/72.
- Currently coffee-rails gem sets
`config.app_generators.javascript_engine` to `:coffee` and using this
information we override the `js_template` to set the extension as
`.coffee` in coffee-rails gem.
- Using this approach, we can keep the `channel.js` and `channel.coffee`
files in the Rails repository itself.
- Additionally the `js_template` method can act as public interface for
coffee-rails gem to hook into and change the extension to `.coffee`
without maintaining the actual asset files.
[Prathamesh Sonpatki, Matthew Draper]
|
| |/
|/|
| |
| | |
Conventionally envs are ordered development -> test -> production.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
|\ \
| | |
| | | |
remove unnessary option setting from test runner
|
| | |
| | |
| | |
| | |
| | | |
In order to prevent `OptionParser::ParseError` when specify the rake options to
`routes` task.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If run the test over the `rake` command, because of the test patterns is passed
via `rake_run` method, do not need to be obtained from the argv.
This probably fixes #24372.
|
| | |
| | |
| | |
| | | |
`railtie` is already a string!
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will
preserve the timezone of the receiver when converting to an instance
of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we
need to introduce a compatibility layer so that apps that upgrade do
not break. New apps will have a config initializer file that defaults
to match the new Ruby 2.4 behavior going forward.
For information about the changes to Ruby see:
https://bugs.ruby-lang.org/issues/12189
https://bugs.ruby-lang.org/issues/12271
Fixes #24617.
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/use_wrapper_file_to_add_rake_task_for_engines
use wrapper file to add rake task for engines
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`bundler` provides wrapper file to add rask tasks.
https://github.com/bundler/bundler/blob/master/lib/bundler/gem_tasks.rb
Instead of directly call method, by which require this file,
it can be used without updating of Rakefile if task has been added.
|
|/ / |
|
|\ \
| | |
| | |
| | | |
Add ActiveSupport::TimeZone.country_zones helper
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Railties' `config` method instatiates a Rails::Railtie::Configuration
object. Rails::Configuration is not used in this file.
The patch does not replace the file being required with the one for
Rails::Railtie::Configuration because that one is autoloaded. See the
spot where this patch changes double quotes with single quotes.
Rails::Railtie::Configuration does depend on Rails::Configuration, and
it requires it accordingly.
|
|\ \
| | |
| | |
| | |
| | | |
prathamesh-sonpatki/add-config-to-deprecation-warning
Add `config` to the deprecation warnings of deprecated config options
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The pass touches a few minor things.
One important aspect is that the wording treats "railtie" as a
regular noun. This is so because Railtie is a constant and
generally the text refers to "classes that act as railties",
which is different.
Railties are so fundamental in Rails that deserve a noun,
like engine, class, array, application, etc. They have a
meaning per se, beyond constants.
Also, make clear an extension's railtie does not need to
be called "Railtie" or have "Railtie" in their class name.
|
| | |
| | |
| | |
| | |
| | | |
Idiomatically trailing hashes in method calls do not use
explicit curlies.
|
| | |
| | |
| | |
| | |
| | | |
Rake includes (an extended version of) FileUtils in tasks.
It is more idiomatic that they use this provided interface.
|
|/ /
| |
| |
| |
| |
| | |
With the exception of what is loaded in active_support/rails,
each file is responsible for its own dependencies. You cannot
rely on runtime order of execution.
|
| |
| |
| |
| |
| |
| | |
This was added in a4c358f, but `config.assets` has been removed in 5172d93.
Also, do not use env path to `Sprockets::Cache::FileStore` even `sprockets-rails`.
ref: https://github.com/rails/sprockets-rails/blob/master/lib/sprockets/railtie.rb#L129
|
| |
| |
| |
| |
| |
| | |
* Updated syntax
* Updated tests to match syntax
|
|\ \
| | |
| | | |
remove unused `require`
|
| | | |
|