| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
- Based on DHH's suggestion about deprecating `assigns` in
https://github.com/rails/rails/pull/18305#issuecomment-68605166.
|
| |
|
|
|
|
|
|
| |
While this was true before when every `dd` had a value,
this patch makes sure that everything keeps lining up even
when the `dd` node is blank.
|
|
|
|
|
| |
- So that RDoc will not generate link for README.
[ci skip]
|
|
|
|
|
| |
These options are not actually available.
Thanks @soutaro for letting me aware of this.
|
|\
| |
| | |
More docs on tagged logging [ci skip]
|
| | |
|
| |
| |
| |
| |
| | |
Mention that tags can also come from a Proc that accepts the request
object or something's to_s method
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Support for versions of SQLite less than 3 was removed in #6011 as part
of the Rails 4.0 release. Therefore there is no need to have support for
it in the `rails dbconsole` command anymore.
|
| |
| |
| |
| |
| |
| | |
We only want to support adapters that we officially support through the
entire framework so it is better to not ask patches for adapters that
we may not support
|
|\ \
| | |
| | | |
Fix formatting of scaffold css
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
Spring seems like an obvious foot gun for the `--dev` setup, presumably you are
about to make lots of changes to the codebase, so it should always reload the
framework.
|
| | |
|
|\ \
| | |
| | | |
fix indent in routes when using namespaced controllers
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before:
namespace :foo do
namespace :bar do
get 'baz/index'
end
end
After:
namespace :foo do
namespace :bar do
get 'baz/index'
end
end
|
|\ \ \
| |/ /
|/| | |
Upgrade to Ruby 2.2.2
|
| | |
| | |
| | |
| | | |
and fix the grammar in the ruby_version_check.rb user message.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Calculating -------------------------------------
each_char 924.000 i/100ms
each_codepoint 1.381k i/100ms
-------------------------------------------------
each_char 9.320k (¡Þ 5.1%) i/s - 47.124k
each_codepoint 13.857k (¡Þ 3.6%) i/s - 70.431k
Comparison:
each_codepoint: 13857.4 i/s
each_char: 9319.5 i/s - 1.49x slower
The full report can be found here:
https://gist.github.com/yuki24/a80988f35aceac76f1d5
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
This make the config/initializers run before the railties are loaded
what can break some configurations.
|
|\ \ \
| | | |
| | | |
| | | | |
Print `bundle install` output in `rails new` as soon as it's available
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, running `rails new` would not print any of the output from
`bundle install` until all the gems had finished installing. This made
it look like the generator was hanging at the `bundle install` step.
This commit switches to using `system` so that the bundle command can
output as it needs to.
This has the added benefit of including output bundler produces on
standard error, which the previous code ignored since backticks only
capture standard out. This is not a big deal right now since bundler
does not currently print errors to standard error, but that may change
in the future (see: bundler/bundler/issues/3353).
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | |
| | | | |
Add explicit base class for ActiveJob jobs
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Jobs generated now inherent from ApplicationJob
* ApplicationJob inherents from ActiveJob::Base
* Added entry to changelog
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
|
| | | | |
|
| | | | |
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
use `Dir.exist?` instead of deprecated `Dir.exists?`
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Removed requiring ostruct because its unused
|
| |/ / / |
|
|/ / / |
|
| | |
| | |
| | |
| | | |
This reverts commit 044f9ab7a4d6646ddce4560bb83b58cdc0baa751.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Also edited the copy to be more consistent with `rake routes`.
See #19323.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Preserving RACK_ENV behavior.
This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing
changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Removing `#build_original_fullpath` because it is no longer
used by the Rails' source code or called in the `#call` method becasue
the previous commit now uses `fullpath` from Rack.
The method was nodoc'ed so it's safe to remove.
NOTE: I did this as a separate commit so if this does cause a problem
with engines etc reverting is easy.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In Rack, `#fullpath` checks if there is a query string and builds the
query correctly:
```
def path
script_name + path_info
end
def fullpath
query_string.empty? ? path : "#{path}?#{query_string}"
end
```
We can utilize this instead of manually building the fullpath because
they are the same result. This also reduces allocations in `#call`
because we don't need `build_original_fullpath` to create the paths and
query strings. We don't need to build `fullpath` twice.
|
| | |
| | |
| | |
| | | |
skip]
|
|\ \ \
| | | |
| | | | |
Don't fallback to RACK_ENV when RAILS_ENV is not present
|
| |/ / |
|
| | | |
|
| | |
| | |
| | |
| | | |
bundle exec db:migrate rake was not working, with the new runner, before this commit
|
| | | |
|
|\ \ \
| | | |
| | | | |
`bin/rails test` runner (rerun snippets, run tests by line, option documentation)
|