| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939
where @senny said:
> From my point of view, all the docs (guides, API) are version bound.
> They should describe that version and continue to be available when newer versions are released.
> The cross referencing can be done by the interested user.
|
|
|
|
| |
fix minor convention problems
|
|
|
|
| |
the current class is not the blank?, present? as well as other inheriting, the test suite runs
|
|\
| |
| |
| | |
Use the built-in rake tasks
|
| |
| |
| | |
Use the `log:clear` and `tmp:clear` rake tasks in the setup file template
|
| | |
|
|\ \
| |/
|/| |
fixing English in Rails::Engine docs
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| | |
* Fix a few typos
* Wrap lines to 80 chars
* Use `+` instead of `<tt>`
|
| |
| |
| |
| |
| | |
Display attachment filenames as a comma separated list rather than
showing the inspect output for the array.
|
| |
| |
| |
| |
| |
| | |
Use the mail gem's own API to locate the correct part.
Fixes #14435.
|
| |
| |
| |
| |
| |
| |
| | |
The usage of these classes where removed at
8017e6af31caa58a58787274ff0ca01397219e49.
cc @arthurnn @senny
|
|\ \
| | |
| | |
| | |
| | | |
remomueller/fix-actionmailer-preview-links-on-subdirectories
Mailer preview now uses `url_for` to fix links to emails for apps runnin...
|
| | |
| | |
| | |
| | | |
a subdirectory, closes #19092.
|
|\ \ \
| | | |
| | | | |
Removed `assigns` from functional_test templates
|
| |/ /
| | |
| | |
| | |
| | | |
- Based on DHH's suggestion about deprecating `assigns` in
https://github.com/rails/rails/pull/18305#issuecomment-68605166.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`setup do` creates unnecessary allocations of proc objects in test
callbacks. This prevents that from happening and results in faster code.
Originally I had done this as `def setup` and all Railties tests passed.
See 044f9ab. Later it was reported there was an issue with this that
caused routes in tests to be nil because devs don't generally call
`super` in their test setups. Because of that I reverted the commit
until I could find a suitble replacement.
`before_setup` esentially does the same thing but without the
requirement that applications call `super` in their test setups.
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| | |
While this was true before when every `dd` had a value,
this patch makes sure that everything keeps lining up even
when the `dd` node is blank.
|
| |
| |
| |
| |
| | |
- So that RDoc will not generate link for README.
[ci skip]
|
| |
| |
| |
| |
| | |
These options are not actually available.
Thanks @soutaro for letting me aware of this.
|
|\ \
| | |
| | | |
More docs on tagged logging [ci skip]
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Mention that tags can also come from a Proc that accepts the request
object or something's to_s method
|
| |/
|/| |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Support for versions of SQLite less than 3 was removed in #6011 as part
of the Rails 4.0 release. Therefore there is no need to have support for
it in the `rails dbconsole` command anymore.
|
| |
| |
| |
| |
| |
| | |
We only want to support adapters that we officially support through the
entire framework so it is better to not ask patches for adapters that
we may not support
|
|\ \
| | |
| | | |
Fix formatting of scaffold css
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
Spring seems like an obvious foot gun for the `--dev` setup, presumably you are
about to make lots of changes to the codebase, so it should always reload the
framework.
|
| | |
|
|\ \
| | |
| | | |
fix indent in routes when using namespaced controllers
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before:
namespace :foo do
namespace :bar do
get 'baz/index'
end
end
After:
namespace :foo do
namespace :bar do
get 'baz/index'
end
end
|
|\ \ \
| |/ /
|/| | |
Upgrade to Ruby 2.2.2
|
| | |
| | |
| | |
| | | |
and fix the grammar in the ruby_version_check.rb user message.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Calculating -------------------------------------
each_char 924.000 i/100ms
each_codepoint 1.381k i/100ms
-------------------------------------------------
each_char 9.320k (¡Þ 5.1%) i/s - 47.124k
each_codepoint 13.857k (¡Þ 3.6%) i/s - 70.431k
Comparison:
each_codepoint: 13857.4 i/s
each_char: 9319.5 i/s - 1.49x slower
The full report can be found here:
https://gist.github.com/yuki24/a80988f35aceac76f1d5
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
This make the config/initializers run before the railties are loaded
what can break some configurations.
|
|\ \ \
| | | |
| | | |
| | | | |
Print `bundle install` output in `rails new` as soon as it's available
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, running `rails new` would not print any of the output from
`bundle install` until all the gems had finished installing. This made
it look like the generator was hanging at the `bundle install` step.
This commit switches to using `system` so that the bundle command can
output as it needs to.
This has the added benefit of including output bundler produces on
standard error, which the previous code ignored since backticks only
capture standard out. This is not a big deal right now since bundler
does not currently print errors to standard error, but that may change
in the future (see: bundler/bundler/issues/3353).
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | |
| | | | |
Add explicit base class for ActiveJob jobs
|