| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | | |
this means we can meaningfully override methods in the subclass
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add an after_bundle callback in Rails templates
Conflicts:
railties/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The template runs before the generation of binstubs – this does not
allow to write one, that makes an initial commit to version control.
It is solvable by adding an after_bundle callback.
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | | |
Also keep the hook as other tools may rely on it,
we just don't do anything by default on Rails.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
apps I have ever worked with has done this. Let us reflect that default. You often want those SQL quieries to be able to debug issues in production
|
|/ /
| |
| |
| | |
simply be tested as part of the view thats using them. If you need something beyond that, you can add a test yourself for them
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.
Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.
Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.
The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.
Paired @sgrif & @schneems
|
| | |
|
| |
| |
| |
| | |
help [ci skip]
|
|/ |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Since the rubysl-yaml gem doesn't ship with Psych by default because of
its dependency on libyaml, on Rubinius, the default engine is Syck.
However, if we want to be able to run the application safely on
different rubies, we need to make people using Rubinius rely on Psych.
See http://git.io/uuLVag for further information.
|
|\
| |
| |
| |
| | |
Conflicts:
actionpack/test/abstract_unit.rb
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | | |
aantix/additional_migration_conflict_help_messaging
Additional help messaging to help the user resolve a conflicted migration
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
a migration already exists for the resource.
The user is now alerted that they are able to skip the conflicted migration file via the --skip option.
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
The Logger by default includes a guard which checks for the
logging level. By removing the custom logging guards, we can decouple
the logging guard from the logging action to be done.
This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
|
| | |
|
| |
| |
| |
| |
| | |
This is a convenience for loading configuration for the current Rails
environment.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With this change it will be possible to add additional options to the `option_parser` like this:
require 'rails/commands/server'
module Rails
class Server < ::Rack::Server
class Options
def option_parser_with_open(options)
parser = option_parser_without_open options
parser.on('-o', '--open', 'Open in default browser') { options[:open] = true }
parser
end
alias_method_chain :option_parser, :open
end
def start_with_open
start_without_open do
`open http://localhost:3000` if options[:open]
end
end
alias_method_chain :start, :open
end
end
|
|\ \
| |/
|/| |
This updates rails to use edge rack
|
| |
| |
| |
| |
| |
| |
| |
| | |
As Rack has some non backwards compatible changes added required
modifications to keep behaviour in rails close to same as before.
Also modified generators to include rack/rack for not yet released
version of rack
|
|\ \
| | |
| | | |
Do not load rails without loading bundler
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As we are setting notice in destroy action we should display that
For more information see https://github.com/rails/rails/pull/14044
And https://github.com/rails/jbuilder/pull/191
closes #14044
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Adds `config.action_mailer.preview_enabled`
This allows mail previewing to be enabled easily in non-development
environments such as staging. The default is set to true for development
so no changes should be required to existing Rails applications.
The mail preview path can still be configured using the existing
`config.action_mailer.preview_path` configuration option.
Adding this avoids devs from having to do stuff like:
https://gist.github.com/lengarvey/fa2c9bd6cdbeba96526a
Update actionmailer/CHANGELOG with new configuration.
Update configuring guide with new configuratation.
Add `config.action_mailer.preview_path` to configuring guide.
|
| |
| |
| |
| | |
Closes #15942
|
| |
| |
| |
| | |
Closes #15919
|
|\ \
| | |
| | | |
Add a '--skip-routes' flag for the Controller generator.
|
| | |
| | |
| | |
| | |
| | | |
This way it is possible to skip the addition of the 'get "foo/bar"' routes when
generating a controller.
|
|/ /
| |
| |
| |
| | |
Need to add individual `:nodoc:` for nested classes / modules to completely
remove the constants from the API.
|
| |
| |
| |
| |
| | |
eg. rails g scaffold UserProfile will have in index.html.erb "Listing User Profiles"
rather than Listing user_profiles.
|
| |
| |
| |
| |
| |
| |
| |
| | |
It was being used by Rails for show the development logs but since Rails
4 it is not being used anymore on the framework.
This class seems to be private but it were part of the public API we are
deprecating before removing.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also remove --skip-turbolinks.
This option is useful if users want to remove some gems like jbuilder,
turbolinks, coffee-rails, etc that don't have specific options on the
generator.
rails new my_app --skip-gems turbolinks coffee-rails
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When someone types in a generator command it currently outputs all generators. Instead we can attempt to find a subtle mis-spelling by running all generator names through a levenshtein_distance algorithm provided by rubygems.
So now a failure looks like this:
```ruby
$ rails generate migratioooons
Could not find generator 'migratioooons'. Maybe you meant 'migration' or 'integration_test' or 'generator'
Run `rails generate --help` for more options.
```
If the suggestions are bad we leave the user with the hint to run `rails generate --help` to see all commands.
|
| |
| |
| |
| |
| | |
File.exists? is deprecated in Ruby 2.1+
https://github.com/ruby/ruby/blob/v2_1_2/file.c#L1413
|
|\ \ |
|
| | | |
|