aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
...
* | Change transaction callbacks to not swallowing errors.Rafael Mendonça França2015-01-041-5/+0
| | | | | | | | | | | | | | | | Before this change any error raised inside a transaction callback are rescued and printed in the logs. Now these errors are not rescue anymore and just bubble up, as the other callbacks.
* | Merge pull request #13434 from tanraya/local_variablesCarlos Antonio da Silva2015-01-033-6/+6
|\ \ | | | | | | | | | | | | | | | | | | Use local variables in _form.html.erb generated by scaffold. Conflicts: railties/CHANGELOG.md
| * | Use local variables in _form.html.erb generated by scaffold generator.tanraya2014-07-263-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems a good idea to use local variables in generated partials instead of using instance variables. Before <%= render 'form' %> After <%= render 'form', product: @product %>
* | | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-032-0/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | | Add config to halt callback chain on return falseclaudiob2015-01-022-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
* | | | Remove the tmp/sessions folder and its clear taskRobin Dupret2015-01-032-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 1aea470 introduced this directory but this was at a time when the default way to store sessions was on the file system under the tmp directory. Let's remove references to it from the documentation as well. [Robin Dupret & yui-knk]
* | | | Generated fixtures won't use parent_id when generated with parent:referencesPablo Olmos de Aguilera Corradini2015-01-021-0/+2
|/ / / | | | | | | | | | Fix #18301
* | | Add --skip-action-mailer (or -M) to rails generateclaudiob2015-01-017-4/+15
| | |
* | | Fix scaffold generator with --helper=false optionRafael Mendonça França2015-01-011-0/+1
| | |
* | | Fix description for application_name method - change simple to simplyPrathamesh Sonpatki2014-12-301-1/+1
| | | | | | | | | | | | [ci skip]
* | | plugin's gemfile also needs tzinfo-data in WindowsShunsukeAida2014-12-301-0/+4
| | |
* | | Merge pull request #18209 from claudiob/bump-to-2-2Guillermo Iguaran2014-12-281-3/+3
|\ \ \ | | | | | | | | Require Ruby 2.2 for Rails 5.0
| * | | Require Ruby 2.2 for Rails 5.0claudiob2014-12-261-3/+3
| | | | | | | | | | | | | | | | | | | | Stems from [this comment](https://github.com/rails/rails/pull/18203#issuecomment-68138096) by @robin850 and by the blog post http://weblog.rubyonrails.org/2014/12/19/Rails-4-2-final
* | | | actually autoload all second-level directories called `app/*/concerns`Alex Robbin2014-12-261-4/+1
|/ / /
* | | - Changed `paths` to `routing_paths` to avoid warning `possible reference to ↵Vipul A M2014-12-261-3/+3
| | | | | | | | | | | | past scope`
* | | Remove unnecessary double spaceKenta Okamoto2014-12-261-1/+1
| |/ |/|
* | Merge pull request #18170 from tgxworld/add_docs_for_rails_application_secretsSean Griffin2014-12-231-1/+15
|\ \ | | | | | | | | | [ci skip]
| * | Rails::Application#secrets should be documented.Guo Xiang Tan2014-12-241-1/+15
| | |
* | | Use the new `foreign_key` option on `references` in generatorsSean Griffin2014-12-221-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes `rails g model Post user:references` from def change create_table :posts do |t| t.references :user, index: true end add_foreign_key :posts, :users end to def change create_table :posts do |t| t.references :user, index: true, foreign_key: true end end Changes `rails g migration add_user_to_posts user:references` from def change add_reference :posts, :users, index: true add_foreign_key :posts, :users end to def change add_reference :posts, :users, index: true, foreign_key: true end
* | | Skip byebug on all non-MRI rubies, fix testsSean Griffin2014-12-221-1/+1
| | | | | | | | | | | | | | | | | | The changes in #18149 added tests for the app generator, but only fixed it for the plugin generator (I should have let CI finish though I think it would have failed as an allowed failure).
* | | Only add debugger/byebug if on MRIArthur Neves2014-12-221-1/+1
|/ /
* | Fix typo in nodocrochefort2014-12-221-1/+1
| |
* | prefer single quotes, by the beard of the prophet!Xavier Noria2014-12-201-10/+10
| |
* | Make bin/setup portableTim Pope2014-12-191-7/+9
| |
* | Merge pull request #18100 from chancancode/serve_static_filesGodfrey Chan2014-12-194-7/+29
| | | | | | | | | | | | Allow static asset serving from env variable (enhanced!) Conflicts: railties/CHANGELOG.md
* | Merge pull request #18049 from yuki3738/fix_rails_db_command_errorRafael Mendonça França2014-12-161-1/+1
|\ \ | | | | | | Add a code checking about file or not to the rails db command
| * | Add a code checking about file or not to the rails db commandyuki37382014-12-161-1/+1
| | |
* | | English fix [ci skip]George Millo2014-12-161-3/+3
|/ /
* | Fix Duplicate web-console entries in GemfileNorimasaAndo2014-12-142-10/+4
| |
* | New applications should use sass-rails 5.0Rafael Mendonça França2014-12-121-6/+1
| |
* | Rails master requires arel masterRafael Mendonça França2014-12-121-2/+8
| |
* | Align the GemfileEntry API with stable branchesGodfrey Chan2014-12-121-5/+9
| | | | | | | | See 63462ec
* | [ci skip] Fix typoyui-knk2014-12-091-1/+1
| |
* | Use latest web-console when using --dev or --edgeSam Ruby2014-12-051-0/+10
| | | | | | | | | | | | Fixes: http://intertwingly.net/projects/AWDwR4/checkdepot-215/makedepot.log
* | Merge pull request #17797 from y-yagi/donot_delete_mailer_layoutsRafael Mendonça França2014-12-041-3/+5
|\ \ | | | | | | Don't remove mailer layouts files
| * | Don't remove mailer layouts filesyuuji.yaginuma2014-11-271-3/+5
| | |
* | | require 'rake' before requiring Rake tasksAkira Matsuda2014-12-031-0/+2
| | | | | | | | | | | | | | | | | | Without this, % rails r "require 'rails/tasks'" would cause a NoMethodError: undefined method `desc' for main:Object
* | | Silence Minitest for plugin tests.Guo Xiang Tan2014-12-021-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/17340. Use Minitest::BacktraceFilter instead of removing all silencers. This will allow the backtrace for all libraries in the plugin to be shown while removing noise generated by Minitest's backtrace.
* | | FIX: absolute_path may be nil for code added via instance_evalSam2014-12-011-1/+1
| | |
* | | Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-2910-22/+18
| | |
* | | adds missing period in test.rb [ci skip]Xavier Noria2014-11-291-1/+1
| | |
* | | Bump required Ruby version to 2.1.0claudiob2014-11-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | [This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that: > Rails 5.0 is in most likelihood going to target Ruby 2.2. Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383) that **at least** version 2.1.0 **must** be required by the `gemspec` files.
* | | We don't need to use sass-rails 5.0.0.betaRafael Mendonça França2014-11-281-2/+1
| | |
* | | Start Rails 5 development :tada:Rafael Mendonça França2014-11-281-3/+3
| | | | | | | | | | | | | | | | | | | | | We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9.
* | | docs, AR no longer makes use of `test:prepare`. [ci skip]Yves Senn2014-11-281-1/+2
| | | | | | | | | | | | | | | | | | Change originated from https://github.com/rails/rails/pull/17739#issuecomment-64829088 /cc @metaskills
* | | Revert "Test against rack master"Santiago Pastorino2014-11-271-2/+2
| | | | | | | | | | | | This reverts commit 2a4e14db981e38611667d407a975600ee720ada7.
* | | rails -> bin/rails in index.htmlXavier Noria2014-11-271-1/+1
|/ /
* | Test against rack masterRafael Mendonça França2014-11-261-2/+2
| |
* | Merge pull request #17761 from pschrammel/masterYves Senn2014-11-261-1/+1
|\ \ | | | | | | | | | be more general with adapter name
| * | be more general with adapter namePeter Schrammel2014-11-251-1/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 19:42:30 +0000