aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails/rack
Commit message (Collapse)AuthorAgeFilesLines
* Log the remote IP addr of clients behind a proxyAtul Bhosale2018-07-311-1/+1
| | | | [Atul Bhosale, Victor Nawothnig]
* Stop mutating body responseGeoff Lee2018-04-031-3/+3
| | | | | | If @app.call returns an object that is saved (for e.g., in a constant), the mutation results in a continuing cycle of wrapping the body in Rack::BodyProxy, eventually leading to SystemStackError ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ On branch fix-return-response-mutation-rack-logger - Tue 3 Apr 2018 19:54:28 PDT by Geoff Lee <geoff.lee@lendesk.com>
* Adding frozen_string_literal pragma to Railties.Pat Allan2017-08-141-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Remove deprecated file `rails/rack/debuggerRafael Mendonça França2017-01-031-3/+0
|
* Fix Rubocop violations and fix documentation visibilityRafael Mendonça França2016-12-281-38/+38
| | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API.
* Privatize unneededly protected methods in RailtiesAkira Matsuda2016-12-251-13/+11
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-7/+7
|
* applies new string literal convention in railties/libXavier Noria2016-08-062-8/+8
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Remove unused private methodSyamil MJ2016-02-071-4/+0
|
* Remove empty lines in Rails development loggerJon Moss2016-01-241-6/+0
| | | | | | This is causing bugs like #23215 to occur, due to the extra spaces being inserted. Also, this is fixed upstream in the upcoming release of Sprockets 4.
* Tiny documentation edits [ci skip]Robin Dupret2015-05-041-2/+3
| | | | | | * Fix a few typos * Wrap lines to 80 chars * Use `+` instead of `<tt>`
* Refer to the constructer argument in docsSkye Shaw2015-04-241-1/+1
|
* More docs on tagged logging [ci skip]sshaw2015-03-061-0/+3
| | | | | Mention that tags can also come from a Proc that accepts the request object or something's to_s method
* Remove debugger supportRafael Mendonça França2015-01-041-23/+2
| | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore
* Remove deprecated `Rails::Rack::LogTailer`Rafael Mendonça França2015-01-041-38/+0
|
* edit pass over all warningsXavier Noria2014-10-281-1/+1
| | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention.
* Prefer to pass block when logging.Guo Xiang Tan2014-07-181-1/+1
| | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
* Deprecate Rails::Rack::LogTailerRafael Mendonça França2014-06-171-0/+4
| | | | | | | | It was being used by Rails for show the development logs but since Rails 4 it is not being used anymore on the framework. This class seems to be private but it were part of the public API we are deprecating before removing.
* More Warnings removed for ruby trunkArun Agrawal2013-11-011-1/+1
| | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
* instrumenter can't be cached because the app could be called fromAaron Patterson2013-10-041-3/+4
| | | | different threads.
* "Naked" rescue clauses only catch StandardError subclasses.thedarkone2013-08-061-1/+1
| | | | Similar to #11497.
* Use the right instrumentation nameRafael Mendonça França2013-08-051-2/+2
| | | | | | | | | The pattern is event.component Closes #11769 Conflicts: railties/CHANGELOG.md
* exit with non-zero to signal failureHrvoje Šimić2013-05-131-2/+2
|
* fire a notification when the request stops / startsAaron Patterson2013-01-091-2/+17
|
* extract logger and development checks to methodsAaron Patterson2013-01-091-6/+16
|
* make the extremely useful logs debug levelAaron Patterson2012-11-091-2/+2
|
* Gotta log each spacer line separately to ensure each is taggedJeremy Kemper2012-10-061-1/+4
|
* Tag the blank log line between dev requests so it's easier to filter out ↵Jeremy Kemper2012-10-061-3/+3
| | | | | | | | | | | | | entire requests with grep -v without leaving a stray newline behind. Example: # Tag asset requests so it's easy to filter them from dev logs config.log_tags = [ -> request { :assets if request.path.starts_with?(config.assets.prefix) }, -> request { request.uuid } ] # Watch the logs, ignoring asset requests $ tail -100f log/development.log | grep -v assets
* Tune up Rails::Rack::Logger. Only put space between requests in development ↵Jeremy Kemper2012-09-261-14/+23
| | | | logs.
* Log newlines separately to ensure the 'Started GET ...' line has a tag on ↵Jeremy Kemper2012-09-251-1/+2
| | | | the same line
* Only apply log tags if the logger supports itJeremy Kemper2012-09-241-1/+1
|
* and one more timeAditya Sanghi2012-04-241-1/+1
|
* another attempt at the languageAditya Sanghi2012-04-181-1/+1
|
* stamp out ruby-debug19 with extreme prejudice :)Aditya Sanghi2012-04-171-2/+2
|
* Fix for log tailer when the log file doesn't exist.Manu J2012-01-201-3/+7
|
* rename ruby-debug to ruby-debug19Vishnu Atrai2012-01-011-1/+1
|
* Unify logger and taggedlogging middleware as both address logging concerns.José Valim2011-10-192-48/+26
|
* Simplify TaggedLogging symbol shortcuts (thanks Jose!)David Heinemeier Hansson2011-10-191-7/+4
|
* Added X-Request-Id tracking and TaggedLogging to easily log that and other ↵David Heinemeier Hansson2011-10-192-2/+41
| | | | production concerns
* Use again Rack's ContentLength middlewareSantiago Pastorino2011-10-181-38/+0
|
* Removed AS core_ext/kernel/requires as it's not used and is bad practice.Josh Kalderimis2011-05-231-4/+3
|
* Temporarily ship with ContentLength middleware.José Valim2011-05-202-5/+38
|
* Filter sensitive query string parameters in the log [#6244 state:committed]Prem Sichanugrist & Xavier Noria2011-03-111-1/+1
| | | | | | This provides more safety to applications that put secret information in the query string, such as API keys or SSO tokens. Signed-off-by: Xavier Noria <fxn@hashref.com>
* Use the derived request_method from AD::Request rather than the raw ↵Michael Koziarski2011-01-181-1/+1
| | | | | | REQUEST_METHOD from rack. This takes _method into account so the log shows the method which ActionController sees.
* replace if ! with unlessNeeraj Singh2010-10-171-1/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Refactor log-tailer to depend on File#eof? rather than File#mtimeCurtis Cablegram2010-08-031-4/+1
| | | | | | | | [#5220 state:resolved] Eliminate 1 instance variable and 1 local variable. Signed-off-by: José Valim <jose.valim@gmail.com>
* Change log-tailer to properly track multi-byte characters.Curtis Cablegram2010-08-031-1/+1
| | | | | | | | When end-of-line is represented within a file as "\r\n", it is represented in memory as a single "\n". This patch eliminates the discrepancy between size on disk and size in memory. Signed-off-by: José Valim <jose.valim@gmail.com>
* Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵José Valim2010-06-241-13/+11
| | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved]
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 15:56:09 +0000