| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | | |
Replace the giant comment in routes.rb with a link to the guides
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This comment not only serves no purpose, but in my experience is
actively detrimental to new developers getting started with Rails.
Expereinced developers just end up deleting this comment, and are
annoyed that they had to take this step. I also spend a lot of time
mentoring brand new developers, and a consistent theme I've seen is that
this comment just ends up intimidating them, and making them think it's
dangerous to edit this file.
One of my students just said this (due to the number of comments which
even new developers don't actually read, they just see it as a sign that
this thing is "dangerous").
> I don't edit any file that Rails generates for me, until my instructor
> says that it's OK to do so.
Realistically, this comment adds 0 value. We have very good
documentation, which we can just link to instead. If someone is truly
new enough to benefit from this info, they presumably just ran `gem
install rails`, and have an internet connection that they can use to
read the routing guide.
The choice of language here was very specific. I chose "the DSL
available" over "what is possible", because a consistent theme I've
noticed among my students is that they aren't aware that this is
actually a Ruby file, and can write any Ruby code here that they want.
This file is not the only offender, but is by far the biggest point of
pain that I've seen, and felt it was a good spot to open this
discussion.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
make generated scaffold functional tests work inside API engines
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* set engine's route in setup
* use fixture with engine namespace
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
use system!
fix changelog
use bundle check first and use rake
use system instead system! for bundle check
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
y-yagi/loading_fixtures_in_engine_integration_tests
set the correct path to `ActionDispatch::IntegrationTest.fixture_path`
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
`ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine,
path under the dummy is will be set, fixtures under test was not loaded.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add dev caching toggle / server options
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Taken from @Sonopa's commits on PR #19091.
Add support for dev caching via "rails s" flags.
Implement suggestions from @kaspth.
Remove temporary cache file if server does not have flags.
Break at 80 characters in railties/CHANGELOG.md
Remove ability to disable cache based on server options.
Add more comprehensive options: --dev-caching / --no-dev-caching
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
manifest file [ci skip]
use it
change the warning
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Inform user to add styles in correct location in application.css
[ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Don't fail when checking dependencies in bin/setup script
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Change wrong usage in documentation about autoload_paths [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We can't use this configuration outside of the application.rb
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This way, running a generator inside the plugin's directory, files that
are not relevant won't be generated (e.g. views or assets).
This won't interfere with the application's generators configuration.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |/ / / /
|/| | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
add system! to fail fast in bin/setup
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove `web-console` from API app generated Gemfile
|
| | |_|_|/ /
| |/| | | | |
|
| |/ / / /
|/| | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
Various grammar corrections and wrap to 80 characters.
|
|\ \ \ \
| | | | |
| | | | | |
remove unnecessary loading fixtures from `navigation_test.rb`
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
it has been corrected in 0176aef1ebaa9f69001c7045a51727a8ea9b61b8 as for loading of fixtures in `test_helper.rb`,
loading fixtures for each test is unnecessary.
|
|/ / /
| | |
| | |
| | |
| | | |
Interpolating an array inside a String will call #inspect on it. Let's
call #join to display a more human-readable error message.
|
| | | |
|
|\ \ \
| | | |
| | | | |
correct `file_fixture_path` in plugins `test_helper.rb`
|
| | | |
| | | |
| | | |
| | | | |
`fixture_path` does not end with a slash
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | | |
assert_file understands paths with special characters
|
| | | |
| | | |
| | | | |
fixes #20042
|
|\ \ \ \
| | | | |
| | | | | |
Use single quote in Railties generators Gemfile [ci skip]
|
| |/ / / |
|
|/ / / |
|
|/ /
| |
| |
| |
| | |
Since #13612, `template` is no longer being used to generate
migrations.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|