Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 2 | -0/+4 |
| | |||||
* | Remove unused method `namespaced_file_path` | Fumiaki MATSUSHIMA | 2016-12-14 | 1 | -4/+0 |
| | | | | | | | | ``` $ git grep namespaced_file_path railties/lib/rails/generators/named_base.rb: def namespaced_file_path railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/") ``` | ||||
* | Don't assign a default to `webpack`. | Kasper Timm Hansen | 2016-12-12 | 1 | -2/+2 |
| | | | | | | | Unintentionally makes `--webpack` implied on `rails new apper`. If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`, so we can check for that instead of `"base"`. | ||||
* | Add option to trigger JS framework-specific installation as part of webpack ↵ | David Heinemeier Hansson | 2016-12-12 | 1 | -2/+5 |
| | | | | setup | ||||
* | Oops! | Akira Matsuda | 2016-12-12 | 1 | -1/+1 |
| | | | | namespace_ladder can be nil here | ||||
* | :nail_care: | Akira Matsuda | 2016-12-12 | 1 | -2/+2 |
| | | | | Don't expect the caller of this method to know that the return value has an extra " " | ||||
* | run `webpack` command only when webpack option is specified | yuuji.yaginuma | 2016-12-10 | 1 | -1/+1 |
| | |||||
* | gemfile entry method need to return an empty array rather than nil (#27318) | Yuji Yaginuma | 2016-12-09 | 1 | -4/+4 |
| | | | | | | | | | This fixes the following error when executing rails new command. ``` (erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError) ``` Follow up to #27288 | ||||
* | Use GitHub webpacker until closer to release | David Heinemeier Hansson | 2016-12-09 | 1 | -1/+1 |
| | |||||
* | Basic --webpack delegation to new webpacker gem (#27288) | David Heinemeier Hansson | 2016-12-09 | 2 | -1/+16 |
| | |||||
* | Show message if Yarn is not installed (#27312) | Guillermo Iguaran | 2016-12-09 | 1 | -1/+8 |
| | |||||
* | Only have Yarn bundling commented out as we cant be sure Yarn is installed | David Heinemeier Hansson | 2016-12-08 | 2 | -5/+2 |
| | |||||
* | specify `skip_yarn` option in API-only Application (#27309) | Yuji Yaginuma | 2016-12-08 | 1 | -2/+8 |
| | |||||
* | Make Yarn the default, drop default vendor/asset directories (#27300) | David Heinemeier Hansson | 2016-12-08 | 8 | -84/+22 |
| | |||||
* | Update puma.rb | brchristian | 2016-12-05 | 1 | -6/+6 |
| | | | Clarifying some of the language/punctuation and removing a couple comma splices. | ||||
* | Add fullstop following the pattern used in rest of the file | Prathamesh Sonpatki | 2016-12-05 | 1 | -1/+1 |
| | |||||
* | use yarn binstub in `bin/update` | yuuji.yaginuma | 2016-12-02 | 1 | -1/+1 |
| | | | | Follow up to 3dac36bd8e26363bb10f4d2a7b21efa75d200e26 | ||||
* | Yarn: Move node_modules, package.json, and yarn.lock file to vendor (#27245) | David Heinemeier Hansson | 2016-12-01 | 6 | -9/+13 |
| | | | Move node_modules, package.json, and yarn.lock file to vendor | ||||
* | use `Gem.win_platform?` to check windows Ruby platforms | yuuji.yaginuma | 2016-11-30 | 3 | -4/+4 |
| | | | | | `Gem.win_platform?` check if it is Windows more accurately. Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952 | ||||
* | Let's use only vendored rails-ujs while we start to publish it to npm registry | Guillermo Iguaran | 2016-11-29 | 1 | -3/+1 |
| | |||||
* | Merge pull request #26836 from Liceth/npm | Guillermo Iguaran | 2016-11-29 | 7 | -3/+82 |
|\ | | | | | Add Yarn support in new apps using --yarn option | ||||
| * | Run yarn on setup and update scripts. | Liceth Ovalles | 2016-11-28 | 2 | -2/+8 |
| | | |||||
| * | Add node_modules to default gitignore | Liceth Ovalles | 2016-11-28 | 1 | -0/+5 |
| | | |||||
| * | Add node_modules path to assets load paths when --yarn option is used | Liceth Ovalles | 2016-11-28 | 1 | -0/+4 |
| | | |||||
| * | Add package.json for Yarn if --yarn option is added | Liceth Ovalles | 2016-11-28 | 3 | -1/+65 |
| | | |||||
* | | rails-ujs is now shipped with Action View | Guillermo Iguaran | 2016-11-29 | 1 | -3/+0 |
|/ | |||||
* | Don't add jQuery by default in new apps and use rails-ujs as UJS adapter instead | Guillermo Iguaran | 2016-11-21 | 2 | -4/+11 |
| | |||||
* | Use existing --skip-turbolinks option for conditionals instead of checking ↵ | Guillermo Iguaran | 2016-11-19 | 2 | -2/+2 |
| | | | | if turbolinks is present in gemfile list | ||||
* | Use secure source for gems referencing "github" in the generated apps | Prathamesh Sonpatki | 2016-11-18 | 1 | -0/+5 |
| | | | | | | | - New apps generated on master and latest bundler give warning about "github" source being insecure. - Use the same solution used for Rails master in the generated app's Gemfile to fix this issue. | ||||
* | Add `:skip_sprockets` to `Rails::PluginBuilder::PASSTHROUGH_OPTIONS` | Tsukuru Tanimichi | 2016-11-14 | 1 | -1/+1 |
| | | | | | | | | | | | | `rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`. ``` % rails plugin new my_engine -S --full --skip-gemspec % cd my_engine % bin/rails test rails aborted! NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100> ``` | ||||
* | Merge pull request #25248 from bluesh55:features/skip-coffee | Sean Griffin | 2016-11-12 | 1 | -1/+6 |
|\ | | | | | | | Add --skip-coffee generating option | ||||
| * | Add --skip-coffee generating option | seunghwan oh | 2016-06-02 | 1 | -1/+6 |
| | | | | | | | | | | | | Usage `rails new awesome-project --skip-coffee` | ||||
* | | Use tr instead of gsub | Akira Matsuda | 2016-11-02 | 1 | -1/+1 |
| | | |||||
* | | Don't put db:migrate and db:setup in binfiles if activerecord is excluded | Bouke van der Bijl | 2016-11-01 | 2 | -0/+4 |
| | | |||||
* | | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 9 | -26/+26 |
| | | |||||
* | | Revert "Merge pull request #23698 from ↵ | Rafael Mendonça França | 2016-10-28 | 1 | -1/+11 |
| | | | | | | | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage" This reverts commit aaf561d26cf9a879ff40190b625155015c6225da, reversing changes made to 83776676e54b387fc52081ff31cfd7710bae9e03. Reason: It is not a good idea to connect to the database on generators | ||||
* | | Merge pull request #23698 from ↵ | Arthur Nogueira Neves | 2016-10-28 | 1 | -11/+1 |
|\ \ | | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage Dynamically show available sql types [ci skip] | ||||
| * | | Dynamically show available sql types [ci skip] | Mehmet Emin İNAÇ | 2016-02-16 | 1 | -11/+1 |
| | | | | | | | | | | | | Dynamically list available sql data types based on current database adapter. | ||||
* | | | Explicitly show --no-helper and --no-assets options in help message | Akira Matsuda | 2016-10-28 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets. So I'm adding them to the help message. I'm still not sure how to show `--no-test-framework` though. | ||||
* | | | remove assets config from `new_framework_defaults` if `--skip-sprockets` is true | yuuji.yaginuma | 2016-10-25 | 1 | -0/+2 |
| | | | | | | | | | | | | If `sprockets` is not loaded, `Rails.application.config.assets` is not defined. | ||||
* | | | don't create db directory when skip active_record | José Gomes Júnior | 2016-10-21 | 1 | -0/+1 |
| | | | |||||
* | | | Allow the use of listen's 3.1.x branch. | Esteban Santana Santana | 2016-10-03 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | When the initial evented monitor feature was written, the latest version of listen was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series. This patch allows the use of the new versions. | ||||
* | | | use `active_support/testing/autorun` in `bin/test` script | yuuji.yaginuma | 2016-09-27 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | | | | | | 29f0fbd5db643b885665e4a14c7de3bf6c0d9c96 has changed that always call `Minitest.autorun` in `active_support/testing/autorun`. Therefore, when used directly `Minitest.run`, tests are performed twice. | ||||
* | | | remove unnecessary `RAILS_ENV` setting | yuuji.yaginuma | 2016-09-22 | 2 | -4/+0 |
| | | | | | | | | | | | | | | | | | | | | | `RAILS_ENV` is always set in the initialization process of test runner. https://github.com/rails/rails/blob/9fa07095a35be2d8cb5adcc992b988e73a6d9719/railties/lib/rails/test_unit/minitest_plugin.rb#L74 Therefore, it is not necessary to set in `test_helper`. | ||||
* | | | Move comment about disconnecting pool close to comment about preload | Prathamesh Sonpatki | 2016-09-14 | 1 | -7/+8 |
| | | | | | | | | | | | | - These two comments are connected to each other so kept them back to back. | ||||
* | | | Do not point to the 5-0-stable branch | Rafael Mendonça França | 2016-09-13 | 1 | -1/+1 |
| | | | | | | | | | | | | Master based applications should be pointing to master | ||||
* | | | Merge pull request #26314 from frodsan/puma-ar-disconnect | Richard Schneeman | 2016-09-13 | 1 | -0/+8 |
|\ \ \ | | | | | | | | | Disconnects all connections in the pool before forking. | ||||
| * | | | Disconnects all connections in the pool before forking. | Francesco Rodriguez | 2016-08-29 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | See discussion in https://github.com/puma/puma/issues/1001 | ||||
* | | | | Fix Remaining Case-In-Assignment Statement Formatting | Alex Kitchens | 2016-09-06 | 1 | -7/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recently, the Rails team made an effort to keep the source code consistent, using Ruboco (bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case statements were missed. This changes the case statements' formatting and is consistent with changes in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231. | ||||
* | | | | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -2/+2 |
| | | | |