| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Before this commit options for `rails new` and `rails plugin new` had to
be passed in a strict order, trying to execute a following command:
rails new -J path/to/app
resulted in an error.
This commit fixes the situation and allows to pass path to app anywhere
after `new`
|
|
|
|
| |
This reverts commit ba0407337e93c4ef55cef3472143f62e8a984a64.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, our default HTML would validate properly, but would generate
a warning: it doesn't declare a character encoding.
According to [the spec][encoding-spec], if you don't specify an
encoding, a 7 step algorithm happens, with a toooon of sub-steps. Or, we
could just actually specify it.
Since everything else in Rails assumes UTF-8, we should make sure pages
are served with that encoding too. This meta tag is the simplest way to
accomplish this.
More resources:
* http://blog.whatwg.org/the-road-to-html-5-character-encoding
* http://www.w3.org/International/tutorials/tutorial-char-enc/
* http://validator.w3.org/
[encoding-spec]: http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#determining-the-character-encoding
|
|
|
|
| |
[John J. Wang & Prathamesh Sonpatki]
|
|
|
|
|
|
|
| |
The defaults hash isn't used unless the +class_options+ hash has a
particular key, so we don't need to compute it unless this is true.
Also moving some code for extracting a module into its own method.
|
|
|
|
|
|
|
|
|
|
| |
When creating a new application using the default rails generator
(`rails new my_app`), it will apply some permissions bypassing the
current process umask. The `bin' directory and any files inside it will
always be set a mode of 0755.
This change removes the current umask bits from the mode applied by
the generator on the `bin' directory and its content.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
_form view [Fixes #11573]
|
| |
|
| |
|
|
|
|
| |
rake task included in test:all rake task.
|
|\
| |
| | |
Remove unnecessary string interpolation
|
| |
| |
| |
| | |
Removed from controller template of scaffold generator.
|
|/
|
|
|
|
| |
Before the AppGenerator is started, ARGV needs to be modified to
correctly account for some things. I'm extracting these out into their
own class.
|
| |
|
|
|
|
| |
favor of `ActiveRecord::Generators::ActiveModel#update`
|
|\
| |
| | |
Change Rails Migration generator module to use AS::Concern
|
| |
| |
| |
| | |
railties/lib/rails/generators/migration.rb file
|
|/
|
|
|
| |
There are historical reasons that the `plugin` command was `plugin_new`, now those are no longer applicable, we should remove the naming edge case from the project. This PR is based off of comments from #11176
ATP Railties
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/layout.html.erb
|
| |
| |
| |
| | |
Add a mention about the helper's test file generated invoking the
controller generator in the USAGE file
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
In #11088, `#to_a` was added to remove a deprecation around using
`#all`. I merged, but it really should have been `#scoped` instead, as
that's the preferred replacement.
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
Is it more suitable that using ```<th colspan="3">``` instead of three empty ```<th>```? It is simple, but what i am missing about it?
Change repetitive th tags to use colspan attribute
Update CHANGELOG.md
Update CHANGELOG.md
|
|
|
|
| |
all directives
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, ActiveModel is only loaded by ActiveRecord. If you skip ActiveRecord, ActiveModel will not be required (or even autoloaded) and including `ActiveModel::Model` into a plain Ruby class will raise `NameError`.
To reproduce this:
- create a new app with `rails new my_app -O`
- create a Ruby class that includes `ActiveModel::Model` in `app/models`
- load up a Rails console and try to do anything with the class :-)
Since ActionPack relies so heavily on the ActiveModel API, this should probably be considered a dependency of the app. Another possibility would be to make it a dependency of ActionController.
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When bundling a gem created with
rails plugin new
Bundler outputs the following warning when building the gem:
WARNING: licenses is empty
modified: railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec
|
| | |
|
| |
| |
| |
| |
| |
| | |
If you generate a fresh app without ActiverRecord, this template
exhibited a lone trailing line break. My watchful pre-commit hook
told me about it so I've fixed it here.
|
| |
| |
| |
| | |
stub command description
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prior to this change, for the following command:
$ rails new
we received "Options should be given after the application name" as an error message.
This is outdated and should be "Application name should be provided in arguments".
|
|\ \
| |/
|/| |
Remove jruby-openssl from default Gemfile
|
| | |
|
|\ \
| |/
|/|
| |
| | |
Conflicts:
activesupport/lib/active_support/callbacks.rb
|
| | |
|
| | |
|
| |
| |
| |
| | |
- http://help.github.com/ignore-files redirects to https://help.github.com/articles/ignoring-files
|