| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When there is a single scaffold in the routes.rb with no other lines
then revoking/destroying it will create a routes.rb file with a syntax
error. This is because the sentinel for the Thor `route` action didn't
include the newline but the logged route code did.
The fix is to add the newline to the sentinel and remove it from the
the logged route code.
Fixes #15913.
|
| | |
| | |
| | |
| | | |
ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
|
| | |
| | |
| | |
| | |
| | | |
Mostly cosmetics, except that `isolate_namespace` should be applied to the last
module in the chain.
|
| | |
| | |
| | |
| | |
| | |
| | | |
It was not possible to create a new gem with a hyphenated name via the `rails plugin new` generator.
The naming guide of rubygems clearly says dashes should be used for gems that extend other gems. http://guides.rubygems.org/name-your-gem/
|
| | |
| | |
| | |
| | | |
This prevents a flood of warnings when generating a new scaffold.
|
| | |
| | |
| | |
| | | |
Add space to new css defs.
|
|\ \ \
| | | |
| | | | |
Update option to skip test in generators
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Rails no longer generates Test::Unit files by default.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
5t111111/add-fix-for-loading-fixtures-in-engine-tests
Add fix for loading fixtures in engine tests (additional fix for #4971)
Conflicts:
railties/lib/rails/generators/rails/plugin/templates/test/test_helper.rb
|
| | | | | |
|
|/ / / / |
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
It's a thin layer to provide easy access to sample files throughout
test-cases. This adds the directory `test/fixtures/files` to newly
generated applications.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
A shortcut to setup controller environment
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Thanks @carlosantoniodasilva :yellow_heart:
|
|\ \ \ \
| |/ / /
|/| | |
| | | | |
Update Molde Generator Usage
|
|/ / /
| | |
| | | |
Including has_secure_token generator
|
|/ / |
|
|\ \
| | |
| | | |
Clean up grammar in scaffold index view, by removing the word 'Listing' ...
|
| | |
| | |
| | |
| | | |
list title.
|
| | |
| | |
| | |
| | | |
Fixes #18473
|
| | |
| | |
| | |
| | | |
deserve that billing)
|
| | | |
|
|/ / |
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
shunsukeaida/avoid_orm_being_humanized_in_generator_help_message
Overwrite descriptions generated by Generators::Base to respect acronym.
|
| |
| |
| |
| | |
hook_for
|
| |
| |
| |
| |
| | |
Following the same naming convention used in
controllers and jobs.
|
| |
| |
| |
| |
| | |
bebugger doesn't work with Ruby 2.2 so we don't need to support it
anymore
|
| |
| |
| |
| |
| |
| |
| |
| | |
Before this change any error raised inside a transaction callback
are rescued and printed in the logs.
Now these errors are not rescue anymore and just bubble up,
as the other callbacks.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Use local variables in _form.html.erb generated by scaffold.
Conflicts:
railties/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It seems a good idea to use local variables in generated partials instead of using instance variables.
Before
<%= render 'form' %>
After
<%= render 'form', product: @product %>
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps.
Conflicts:
railties/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This stems from [a comment](rails#17227 (comment)) by @dhh.
In summary:
* New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning.
* Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning.
For this purpose, this commit introduces a Rails configuration option:
```ruby
config.active_support.halt_callback_chains_on_return_false
```
For new Rails 5.0 apps, this option will be set to `false` by a new initializer
`config/initializers/callback_terminator.rb`:
```ruby
Rails.application.config.active_support.halt_callback_chains_on_return_false = false
```
For existing apps ported to Rails 5.0, the initializers above will not exist.
Even running `rake rails:update` will not create this initializer.
Since the default value of `halt_callback_chains_on_return_false` is set to
`true`, these apps will still accept `return true` as a way to halt callback
chains, displaying a deprecation warning.
Developers will be able to switch to the new behavior (and stop the warning)
by manually adding the line above to their `config/application.rb`.
A gist with the suggested release notes to add to Rails 5.0 after this
commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
|
|/ / /
| | |
| | |
| | | |
Fix #18301
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Changes `rails g model Post user:references` from
def change
create_table :posts do |t|
t.references :user, index: true
end
add_foreign_key :posts, :users
end
to
def change
create_table :posts do |t|
t.references :user, index: true, foreign_key: true
end
end
Changes `rails g migration add_user_to_posts user:references` from
def change
add_reference :posts, :users, index: true
add_foreign_key :posts, :users
end
to
def change
add_reference :posts, :users, index: true, foreign_key: true
end
|
| |
| |
| |
| |
| |
| | |
The changes in #18149 added tests for the app generator, but only fixed
it for the plugin generator (I should have let CI finish though I think
it would have failed as an allowed failure).
|
| | |
|