aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails/generators
Commit message (Collapse)AuthorAgeFilesLines
* Don't add jQuery by default in new apps and use rails-ujs as UJS adapter insteadGuillermo Iguaran2016-11-212-4/+11
|
* Use existing --skip-turbolinks option for conditionals instead of checking ↵Guillermo Iguaran2016-11-192-2/+2
| | | | if turbolinks is present in gemfile list
* Use secure source for gems referencing "github" in the generated appsPrathamesh Sonpatki2016-11-181-0/+5
| | | | | | | - New apps generated on master and latest bundler give warning about "github" source being insecure. - Use the same solution used for Rails master in the generated app's Gemfile to fix this issue.
* Add `:skip_sprockets` to `Rails::PluginBuilder::PASSTHROUGH_OPTIONS`Tsukuru Tanimichi2016-11-141-1/+1
| | | | | | | | | | | | `rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`. ``` % rails plugin new my_engine -S --full --skip-gemspec % cd my_engine % bin/rails test rails aborted! NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100> ```
* Merge pull request #25248 from bluesh55:features/skip-coffeeSean Griffin2016-11-121-1/+6
|\ | | | | | | Add --skip-coffee generating option
| * Add --skip-coffee generating optionseunghwan oh2016-06-021-1/+6
| | | | | | | | | | | | Usage `rails new awesome-project --skip-coffee`
* | Use tr instead of gsubAkira Matsuda2016-11-021-1/+1
| |
* | Don't put db:migrate and db:setup in binfiles if activerecord is excludedBouke van der Bijl2016-11-012-0/+4
| |
* | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-299-26/+26
| |
* | Revert "Merge pull request #23698 from ↵Rafael Mendonça França2016-10-281-1/+11
| | | | | | | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage" This reverts commit aaf561d26cf9a879ff40190b625155015c6225da, reversing changes made to 83776676e54b387fc52081ff31cfd7710bae9e03. Reason: It is not a good idea to connect to the database on generators
* | Merge pull request #23698 from ↵Arthur Nogueira Neves2016-10-281-11/+1
|\ \ | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage Dynamically show available sql types [ci skip]
| * | Dynamically show available sql types [ci skip]Mehmet Emin İNAÇ2016-02-161-11/+1
| | | | | | | | | | | | Dynamically list available sql data types based on current database adapter.
* | | Explicitly show --no-helper and --no-assets options in help messageAkira Matsuda2016-10-281-0/+2
| | | | | | | | | | | | | | | | | | I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets. So I'm adding them to the help message. I'm still not sure how to show `--no-test-framework` though.
* | | remove assets config from `new_framework_defaults` if `--skip-sprockets` is trueyuuji.yaginuma2016-10-251-0/+2
| | | | | | | | | | | | If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
* | | don't create db directory when skip active_recordJosé Gomes Júnior2016-10-211-0/+1
| | |
* | | Allow the use of listen's 3.1.x branch.Esteban Santana Santana2016-10-031-1/+1
| | | | | | | | | | | | | | | | | | When the initial evented monitor feature was written, the latest version of listen was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series. This patch allows the use of the new versions.
* | | use `active_support/testing/autorun` in `bin/test` scriptyuuji.yaginuma2016-09-271-1/+3
| | | | | | | | | | | | | | | | | | | | | 29f0fbd5db643b885665e4a14c7de3bf6c0d9c96 has changed that always call `Minitest.autorun` in `active_support/testing/autorun`. Therefore, when used directly `Minitest.run`, tests are performed twice.
* | | remove unnecessary `RAILS_ENV` settingyuuji.yaginuma2016-09-222-4/+0
| | | | | | | | | | | | | | | | | | | | | `RAILS_ENV` is always set in the initialization process of test runner. https://github.com/rails/rails/blob/9fa07095a35be2d8cb5adcc992b988e73a6d9719/railties/lib/rails/test_unit/minitest_plugin.rb#L74 Therefore, it is not necessary to set in `test_helper`.
* | | Move comment about disconnecting pool close to comment about preloadPrathamesh Sonpatki2016-09-141-7/+8
| | | | | | | | | | | | - These two comments are connected to each other so kept them back to back.
* | | Do not point to the 5-0-stable branchRafael Mendonça França2016-09-131-1/+1
| | | | | | | | | | | | Master based applications should be pointing to master
* | | Merge pull request #26314 from frodsan/puma-ar-disconnectRichard Schneeman2016-09-131-0/+8
|\ \ \ | | | | | | | | Disconnects all connections in the pool before forking.
| * | | Disconnects all connections in the pool before forking.Francesco Rodriguez2016-08-291-0/+8
| | | | | | | | | | | | | | | | See discussion in https://github.com/puma/puma/issues/1001
* | | | Fix Remaining Case-In-Assignment Statement FormattingAlex Kitchens2016-09-061-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recently, the Rails team made an effort to keep the source code consistent, using Ruboco (bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case statements were missed. This changes the case statements' formatting and is consistent with changes in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231.
* | | | fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-011-2/+2
| | | |
* | | | Set unknown_asset_fallback false only new appsschneems2016-08-291-1/+1
| | | |
* | | | Move default to different initializerschneems2016-08-292-4/+4
| | | | | | | | | | | | | | | | | | | | Is this usage correct? cc/ @prathamesh-sonpatki
* | | | Fix initializerschneems2016-08-291-1/+1
| | | |
* | | | Default assets.unknown_asset_fallback to falseschneems2016-08-291-0/+4
|/ / /
* | | Merge pull request #26224 from jonatack/consistent-asset-precompile-examplesEileen M. Uchitelle2016-08-191-2/+3
|\ \ \ | | | | | | | | Consistent examples and template for assets#precompile
| * | | Consistent examples and template for assets#precompileJon Atack2016-08-191-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent. This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template. Re-add spaces inside array parentheses.
* | | | Merge pull request #26157 from ↵Rafael França2016-08-161-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | y-yagi/remove_test_mailers_when_skipping_action-mailer remove "test/mailers" directory when skipping action-mailer
| * | | | remove "test/mailers" directory when skipping action-maileryuuji.yaginuma2016-08-141-0/+1
| |/ / / | | | | | | | | | | | | Related to #26146
* / / / Add three new rubocop rulesRafael Mendonça França2016-08-163-4/+4
|/ / / | | | | | | | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | | Ensure app/mailers is removed when skipping action-mailerBrian Cardarella2016-08-121-0/+1
| | | | | | | | | | | | Closes #26145
* | | Make cache max-age durations self-explanatoryNathan Long2016-08-122-2/+2
| | |
* | | code gardening: removes redundant selfsXavier Noria2016-08-087-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* | | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-071-1/+0
| | |
* | | Merge pull request #26060 from siong1987/minor/puma-configGuillermo Iguaran2016-08-061-1/+1
|\ \ \ | | | | | | | | .to_i is unnecessary for puma threads.
| * | | .to_i is unnecessary.Teng Siong Ong2016-08-041-1/+1
| | | |
* | | | applies remaining conventions across the projectXavier Noria2016-08-0611-35/+27
| | | |
* | | | normalizes indentation and whitespace across the projectXavier Noria2016-08-064-48/+48
| | | |
* | | | remove redundant curlies from hash argumentsXavier Noria2016-08-061-1/+1
| | | |
* | | | applies new string literal convention in railties/libXavier Noria2016-08-0637-243/+243
|/ / / | | | | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* | | Show supported DBs first in `rails new --help`Akira Matsuda2016-08-031-5/+5
| | |
* | | A generated app should not include Uglifier with `--skip-javascript` option.Ben Pickles2016-07-262-3/+9
| | |
* | | Enforce minimal web-console version for Rails 5Genadi Samokovarov2016-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I dropped the version constraint in web-console with the idea it will be easier to upgrade the console between Rails releases. However, issues like #25899 started popping up. I'm reintroducing the constraint, but this time, I don't set an upper limit to the major version. This will keep the web-console in a version that always works for the current Rails version and can be easily upgraded to the last one with `bundle update`. We may need to backport this for Rails 5.0.1. Fixes #25899.
* | | Merge pull request #25438 from prathamesh-sonpatki/rm-session-store-initializerRafael Mendonça França2016-07-202-4/+0
|\ \ \ | | | | | | | | | | | | Setup default session store internally, no longer through an initializer
| * | | Setup default session store internally, no longer through an application ↵Prathamesh Sonpatki2016-07-172-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | initializer - By default the session store will be set to cookie store with application name as session key. - Older apps are not affected as they will have the session store initializer generated by Rails in older versions, and Rails will not overwrite the session store if it is already set or disabled. - But new apps will not have the initializer, instead the session store will be set to cookie store by default. - Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
* | | | Merge pull request #25795 from mechanicles/command-importanceGuillermo Iguaran2016-07-131-1/+1
|\ \ \ \ | | | | | | | | | | Give importance to rails command [ci skip]
| * | | | Give importance to rails command in the comment section.Santosh Wadghule2016-07-131-1/+1
| |/ / /