| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
mtsmfm/fix-generator-command-for-nested-rails-engine"
This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing
changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1.
Reason: It breaks the public API
|
|\
| |
| |
| |
| | |
mtsmfm/fix-generator-command-for-nested-rails-engine
Fix generator command for nested (namespaced) rails engine
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
|\ \
| |/
|/| |
Active Record supports MySQL >= 5.1.10
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Follow up to #25307 and #23458. Related with #27422.
We are using `information_schema.referential_constraints` since #25307.
The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is
enough to support >= 5.1.10 at least.
MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011.
MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013.
|
| |
| |
| |
| |
| |
| | |
- No need to remove bin/yarn separately for API only apps because
:skip_yarn is set to true for API only apps.
- Added a test for :skip_yarn config.
|
| |
| |
| |
| |
| |
| | |
It deletes the `app/mailers` directory itself, it is not necessary to delete
the file individually.
https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/app_generator.rb#L329
|
| |
| |
| |
| |
| |
| |
| | |
Because `bundle install` is not executed regardless of whether the option
is specified or not.
Ref: fbd1e98cf983572ca9884f17f933ffe92833632a
|
| | |
|
| |
| |
| |
| |
| |
| | |
Fixes #27447
[Matthew Draper & Yuuji Yaginuma]
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
| |
```
$ git grep namespaced_file_path
railties/lib/rails/generators/named_base.rb: def namespaced_file_path
railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/")
```
|
|
|
|
|
|
|
| |
Unintentionally makes `--webpack` implied on `rails new apper`.
If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`,
so we can check for that instead of `"base"`.
|
|
|
|
| |
setup
|
|
|
|
| |
namespace_ladder can be nil here
|
|
|
|
| |
Don't expect the caller of this method to know that the return value has an extra " "
|
| |
|
|
|
|
|
|
|
|
|
| |
This fixes the following error when executing rails new command.
```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```
Follow up to #27288
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
| |
Clarifying some of the language/punctuation and removing a couple comma splices.
|
| |
|
|
|
|
| |
Follow up to 3dac36bd8e26363bb10f4d2a7b21efa75d200e26
|
|
|
| |
Move node_modules, package.json, and yarn.lock file to vendor
|
|
|
|
|
| |
`Gem.win_platform?` check if it is Windows more accurately.
Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952
|
| |
|
|\
| |
| | |
Add Yarn support in new apps using --yarn option
|
| | |
|
| | |
|
| | |
|
| | |
|
|/ |
|
| |
|
|
|
|
| |
if turbolinks is present in gemfile list
|
|
|
|
|
|
|
| |
- New apps generated on master and latest bundler give warning about
"github" source being insecure.
- Use the same solution used for Rails master in the generated app's
Gemfile to fix this issue.
|
|
|
|
|
|
|
|
|
|
|
|
| |
`rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`.
```
% rails plugin new my_engine -S --full --skip-gemspec
% cd my_engine
% bin/rails test
rails aborted!
NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100>
```
|
|\
| |
| |
| | |
Add --skip-coffee generating option
|
| |
| |
| |
| |
| |
| | |
Usage
`rails new awesome-project --skip-coffee`
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
meinac/add_missing_types_into_ar_model_generator_usage"
This reverts commit aaf561d26cf9a879ff40190b625155015c6225da, reversing
changes made to 83776676e54b387fc52081ff31cfd7710bae9e03.
Reason: It is not a good idea to connect to the database on generators
|
|\ \
| | |
| | |
| | |
| | | |
meinac/add_missing_types_into_ar_model_generator_usage
Dynamically show available sql types [ci skip]
|
| | |
| | |
| | |
| | | |
Dynamically list available sql data types based on current database adapter.
|
| | |
| | |
| | |
| | |
| | |
| | | |
I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets.
So I'm adding them to the help message.
I'm still not sure how to show `--no-test-framework` though.
|