| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
Add basic support for access control headers to ActionDispatch::Static
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Now ActionDispatch::Static can accept HTTP headers so that developers
will have control of returning arbitrary headers like
'Access-Control-Allow-Origin' when a response is delivered. They can
be configured through `#config.public_file_server.headers`:
config.public_file_server.headers = {
"Cache-Control" => "public, max-age=60",
"Access-Control-Allow-Origin" => "http://rubyonrails.org"
}
Also deprecate `config.static_cache_control` in favor of
`config.public_file_server.headers`.
|
| |
| |
| |
| | |
Since the plugin generator do not generate assets, I think manifest.js also that it unnecessary.
|
|\ \
| | |
| | | |
change `prepare_destination` to public API [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`prepare_destination` has been used in the template file for the generator,
I think it should be a public API
ref: https://github.com/rails/rails/blob/master/railties/lib/rails/generators/test_unit/generator/templates/generator_test.rb#L8
|
|/ /
| |
| |
| | |
`shellwords` is no longer needed from #20605.
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | | |
using string for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Move `app/assets/manifest.js` to `app/assets/config/manifest.js`.
Avoid the suggestion that you can/should deep-link `stylesheets/foo`.
* Pull in all toplevel stylesheets and JavaScripts, not just
`application.js` and `.css`. Demonstrate how to use `link_directory`
with a specified `.js`/`.css` type.
* Fix RAILS_ENV handling in assets tests.
* Shush warnings spam from third-party libs that distract from tests.
|
|/ /
| |
| |
| |
| |
| |
| | |
generator
This is follow up to #6643.
In #6643, the controller generator only had been fixed, in this commit to fix the scaffold generator.
|
| | |
|
|\ \
| | |
| | | |
Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
|
| | |
| | |
| | |
| | |
| | | |
skip]
Bumps from `5.6` to `5.7`
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
I do not know why files under the support has been require.
However, under the support even rails application does not use.
In addition, since the default under the support file nor is generated, it requires I think not necessary
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
The semantic versioning specification uses MAJOR.MINOR.PATCH – it would
make more sense to set the version to 0.1.0 for initial development
since a patch release cannot be created before a minor feature release.
|
|\ \
| | |
| | | |
Replace the giant comment in routes.rb with a link to the guides
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This comment not only serves no purpose, but in my experience is
actively detrimental to new developers getting started with Rails.
Expereinced developers just end up deleting this comment, and are
annoyed that they had to take this step. I also spend a lot of time
mentoring brand new developers, and a consistent theme I've seen is that
this comment just ends up intimidating them, and making them think it's
dangerous to edit this file.
One of my students just said this (due to the number of comments which
even new developers don't actually read, they just see it as a sign that
this thing is "dangerous").
> I don't edit any file that Rails generates for me, until my instructor
> says that it's OK to do so.
Realistically, this comment adds 0 value. We have very good
documentation, which we can just link to instead. If someone is truly
new enough to benefit from this info, they presumably just ran `gem
install rails`, and have an internet connection that they can use to
read the routing guide.
The choice of language here was very specific. I chose "the DSL
available" over "what is possible", because a consistent theme I've
noticed among my students is that they aren't aware that this is
actually a Ruby file, and can write any Ruby code here that they want.
This file is not the only offender, but is by far the biggest point of
pain that I've seen, and felt it was a good spot to open this
discussion.
|
|\ \ \
| | | |
| | | | |
make generated scaffold functional tests work inside API engines
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* set engine's route in setup
* use fixture with engine namespace
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
use system!
fix changelog
use bundle check first and use rake
use system instead system! for bundle check
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/loading_fixtures_in_engine_integration_tests
set the correct path to `ActionDispatch::IntegrationTest.fixture_path`
|
| |/ /
| | |
| | |
| | |
| | | |
`ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine,
path under the dummy is will be set, fixtures under test was not loaded.
|
|\ \ \
| | | |
| | | | |
Add dev caching toggle / server options
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Taken from @Sonopa's commits on PR #19091.
Add support for dev caching via "rails s" flags.
Implement suggestions from @kaspth.
Remove temporary cache file if server does not have flags.
Break at 80 characters in railties/CHANGELOG.md
Remove ability to disable cache based on server options.
Add more comprehensive options: --dev-caching / --no-dev-caching
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
manifest file [ci skip]
use it
change the warning
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Inform user to add styles in correct location in application.css
[ci skip]
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Don't fail when checking dependencies in bin/setup script
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Change wrong usage in documentation about autoload_paths [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
We can't use this configuration outside of the application.rb
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This way, running a generator inside the plugin's directory, files that
are not relevant won't be generated (e.g. views or assets).
This won't interfere with the application's generators configuration.
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
add system! to fail fast in bin/setup
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
remove `web-console` from API app generated Gemfile
|
| | | | | |
|
| |/ / /
|/| | | |
|
|/ / /
| | |
| | |
| | | |
Various grammar corrections and wrap to 80 characters.
|
|\ \ \
| | | |
| | | | |
remove unnecessary loading fixtures from `navigation_test.rb`
|