aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails/generators
Commit message (Collapse)AuthorAgeFilesLines
* remove `skip_bundle` option from plugin generatoryuuji.yaginuma2016-12-312-3/+3
| | | | | | | Because `bundle install` is not executed regardless of whether the option is specified or not. Ref: fbd1e98cf983572ca9884f17f933ffe92833632a
* Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-291-0/+1
|
* Correct indent-accounting in controller route generationMatthew Draper2016-12-251-11/+14
| | | | | | Fixes #27447 [Matthew Draper & Yuuji Yaginuma]
* Privatize unneededly protected methods in RailtiesAkira Matsuda2016-12-2516-86/+90
|
* Describe what we are protectingAkira Matsuda2016-12-232-0/+4
|
* Remove unused method `namespaced_file_path`Fumiaki MATSUSHIMA2016-12-141-4/+0
| | | | | | | | ``` $ git grep namespaced_file_path railties/lib/rails/generators/named_base.rb: def namespaced_file_path railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/") ```
* Don't assign a default to `webpack`.Kasper Timm Hansen2016-12-121-2/+2
| | | | | | | Unintentionally makes `--webpack` implied on `rails new apper`. If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`, so we can check for that instead of `"base"`.
* Add option to trigger JS framework-specific installation as part of webpack ↵David Heinemeier Hansson2016-12-121-2/+5
| | | | setup
* Oops!Akira Matsuda2016-12-121-1/+1
| | | | namespace_ladder can be nil here
* :nail_care:Akira Matsuda2016-12-121-2/+2
| | | | Don't expect the caller of this method to know that the return value has an extra " "
* run `webpack` command only when webpack option is specifiedyuuji.yaginuma2016-12-101-1/+1
|
* gemfile entry method need to return an empty array rather than nil (#27318)Yuji Yaginuma2016-12-091-4/+4
| | | | | | | | | This fixes the following error when executing rails new command. ``` (erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError) ``` Follow up to #27288
* Use GitHub webpacker until closer to releaseDavid Heinemeier Hansson2016-12-091-1/+1
|
* Basic --webpack delegation to new webpacker gem (#27288)David Heinemeier Hansson2016-12-092-1/+16
|
* Show message if Yarn is not installed (#27312)Guillermo Iguaran2016-12-091-1/+8
|
* Only have Yarn bundling commented out as we cant be sure Yarn is installedDavid Heinemeier Hansson2016-12-082-5/+2
|
* specify `skip_yarn` option in API-only Application (#27309)Yuji Yaginuma2016-12-081-2/+8
|
* Make Yarn the default, drop default vendor/asset directories (#27300)David Heinemeier Hansson2016-12-088-84/+22
|
* Update puma.rbbrchristian2016-12-051-6/+6
| | | Clarifying some of the language/punctuation and removing a couple comma splices.
* Add fullstop following the pattern used in rest of the filePrathamesh Sonpatki2016-12-051-1/+1
|
* use yarn binstub in `bin/update`yuuji.yaginuma2016-12-021-1/+1
| | | | Follow up to 3dac36bd8e26363bb10f4d2a7b21efa75d200e26
* Yarn: Move node_modules, package.json, and yarn.lock file to vendor (#27245)David Heinemeier Hansson2016-12-016-9/+13
| | | Move node_modules, package.json, and yarn.lock file to vendor
* use `Gem.win_platform?` to check windows Ruby platformsyuuji.yaginuma2016-11-303-4/+4
| | | | | `Gem.win_platform?` check if it is Windows more accurately. Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952
* Let's use only vendored rails-ujs while we start to publish it to npm registryGuillermo Iguaran2016-11-291-3/+1
|
* Merge pull request #26836 from Liceth/npmGuillermo Iguaran2016-11-297-3/+82
|\ | | | | Add Yarn support in new apps using --yarn option
| * Run yarn on setup and update scripts.Liceth Ovalles2016-11-282-2/+8
| |
| * Add node_modules to default gitignoreLiceth Ovalles2016-11-281-0/+5
| |
| * Add node_modules path to assets load paths when --yarn option is usedLiceth Ovalles2016-11-281-0/+4
| |
| * Add package.json for Yarn if --yarn option is addedLiceth Ovalles2016-11-283-1/+65
| |
* | rails-ujs is now shipped with Action ViewGuillermo Iguaran2016-11-291-3/+0
|/
* Don't add jQuery by default in new apps and use rails-ujs as UJS adapter insteadGuillermo Iguaran2016-11-212-4/+11
|
* Use existing --skip-turbolinks option for conditionals instead of checking ↵Guillermo Iguaran2016-11-192-2/+2
| | | | if turbolinks is present in gemfile list
* Use secure source for gems referencing "github" in the generated appsPrathamesh Sonpatki2016-11-181-0/+5
| | | | | | | - New apps generated on master and latest bundler give warning about "github" source being insecure. - Use the same solution used for Rails master in the generated app's Gemfile to fix this issue.
* Add `:skip_sprockets` to `Rails::PluginBuilder::PASSTHROUGH_OPTIONS`Tsukuru Tanimichi2016-11-141-1/+1
| | | | | | | | | | | | `rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`. ``` % rails plugin new my_engine -S --full --skip-gemspec % cd my_engine % bin/rails test rails aborted! NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100> ```
* Merge pull request #25248 from bluesh55:features/skip-coffeeSean Griffin2016-11-121-1/+6
|\ | | | | | | Add --skip-coffee generating option
| * Add --skip-coffee generating optionseunghwan oh2016-06-021-1/+6
| | | | | | | | | | | | Usage `rails new awesome-project --skip-coffee`
* | Use tr instead of gsubAkira Matsuda2016-11-021-1/+1
| |
* | Don't put db:migrate and db:setup in binfiles if activerecord is excludedBouke van der Bijl2016-11-012-0/+4
| |
* | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-299-26/+26
| |
* | Revert "Merge pull request #23698 from ↵Rafael Mendonça França2016-10-281-1/+11
| | | | | | | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage" This reverts commit aaf561d26cf9a879ff40190b625155015c6225da, reversing changes made to 83776676e54b387fc52081ff31cfd7710bae9e03. Reason: It is not a good idea to connect to the database on generators
* | Merge pull request #23698 from ↵Arthur Nogueira Neves2016-10-281-11/+1
|\ \ | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage Dynamically show available sql types [ci skip]
| * | Dynamically show available sql types [ci skip]Mehmet Emin İNAÇ2016-02-161-11/+1
| | | | | | | | | | | | Dynamically list available sql data types based on current database adapter.
* | | Explicitly show --no-helper and --no-assets options in help messageAkira Matsuda2016-10-281-0/+2
| | | | | | | | | | | | | | | | | | I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets. So I'm adding them to the help message. I'm still not sure how to show `--no-test-framework` though.
* | | remove assets config from `new_framework_defaults` if `--skip-sprockets` is trueyuuji.yaginuma2016-10-251-0/+2
| | | | | | | | | | | | If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
* | | don't create db directory when skip active_recordJosé Gomes Júnior2016-10-211-0/+1
| | |
* | | Allow the use of listen's 3.1.x branch.Esteban Santana Santana2016-10-031-1/+1
| | | | | | | | | | | | | | | | | | When the initial evented monitor feature was written, the latest version of listen was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series. This patch allows the use of the new versions.
* | | use `active_support/testing/autorun` in `bin/test` scriptyuuji.yaginuma2016-09-271-1/+3
| | | | | | | | | | | | | | | | | | | | | 29f0fbd5db643b885665e4a14c7de3bf6c0d9c96 has changed that always call `Minitest.autorun` in `active_support/testing/autorun`. Therefore, when used directly `Minitest.run`, tests are performed twice.
* | | remove unnecessary `RAILS_ENV` settingyuuji.yaginuma2016-09-222-4/+0
| | | | | | | | | | | | | | | | | | | | | `RAILS_ENV` is always set in the initialization process of test runner. https://github.com/rails/rails/blob/9fa07095a35be2d8cb5adcc992b988e73a6d9719/railties/lib/rails/test_unit/minitest_plugin.rb#L74 Therefore, it is not necessary to set in `test_helper`.
* | | Move comment about disconnecting pool close to comment about preloadPrathamesh Sonpatki2016-09-141-7/+8
| | | | | | | | | | | | - These two comments are connected to each other so kept them back to back.
* | | Do not point to the 5-0-stable branchRafael Mendonça França2016-09-131-1/+1
| | | | | | | | | | | | Master based applications should be pointing to master