Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Change `platform` to `platforms` | Junichi Ito | 2017-01-18 | 1 | -1/+1 |
| | |||||
* | Install Byebug gem as default in Windows (mingw and x64_mingw) platform. | Junichi Ito | 2017-01-18 | 1 | -1/+1 |
| | |||||
* | Merge pull request #27601 from y-yagi/make_work_all_commands_from_engine | Kasper Timm Hansen | 2017-01-15 | 1 | -0/+1 |
|\ | | | | | Make all rails commands work in engine | ||||
| * | make all rails commands work in engine | yuuji.yaginuma | 2017-01-09 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | Currently, all rails commands can be executed in engine, but `server`, `console`, `dbconsole` and `runner` do not work. This make all rails commands work in engine. Related to #22588 | ||||
* | | remove unnecessary addition of `lib` | yuuji.yaginuma | 2017-01-15 | 1 | -1/+0 |
| | | | | | | | | | | `TestTask` add `lib` directory by default. Ref: https://github.com/ruby/rake/blob/master/lib/rake/testtask.rb#L39..L41 | ||||
* | | Rails::Generators::AppBase::GemfileEntry needs anonymous superclass | Akira Matsuda | 2017-01-13 | 1 | -1/+1 |
| | | | | | | | | | | | | it has some methods that override the accessors and calls the original accessors via `super` this partially reverts 9360b6be63b7a452535699bcf6ae853df7f5eea7 | ||||
* | | class Foo < Struct.new(:x) creates an extra unneeded anonymous class | Akira Matsuda | 2017-01-13 | 1 | -1/+1 |
| | | | | | | | | because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it | ||||
* | | Reduce string objects by using \ instead of + or << for concatenating strings | Akira Matsuda | 2017-01-12 | 3 | -5/+5 |
|/ | | | | (I personally prefer writing one string in one line no matter how long it is, though) | ||||
* | Don't generate HTML/ERB templates for scaffold controller with --api flag | Prathamesh Sonpatki | 2017-01-07 | 1 | -1/+6 |
| | | | | - Fixes #27591. | ||||
* | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 5 | -5/+5 |
| | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | ||||
* | Revert "Merge pull request #27550 from ↵ | Rafael Mendonça França | 2017-01-03 | 5 | -6/+6 |
| | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API | ||||
* | Merge pull request #27550 from ↵ | Rafael França | 2017-01-03 | 5 | -6/+6 |
|\ | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine Fix generator command for nested (namespaced) rails engine | ||||
| * | Fix generator command for nested (namespaced) rails engine | Fumiaki MATSUSHIMA | 2017-01-03 | 5 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not. | ||||
* | | Merge pull request #27435 from kamipo/follow_up_25307 | Sean Griffin | 2017-01-03 | 2 | -2/+2 |
|\ \ | |/ |/| | Active Record supports MySQL >= 5.1.10 | ||||
| * | Active Record supports MySQL >= 5.1.10 | Ryuta Kamizono | 2016-12-22 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | Follow up to #25307 and #23458. Related with #27422. We are using `information_schema.referential_constraints` since #25307. The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is enough to support >= 5.1.10 at least. MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011. MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013. | ||||
* | | Remove bin/yarn if yarn is skipped, tidy up tests | Prathamesh Sonpatki | 2017-01-01 | 1 | -2/+2 |
| | | | | | | | | | | | | - No need to remove bin/yarn separately for API only apps because :skip_yarn is set to true for API only apps. - Added a test for :skip_yarn config. | ||||
* | | remove unnecessary `remove_file` | yuuji.yaginuma | 2017-01-01 | 1 | -1/+0 |
| | | | | | | | | | | | | It deletes the `app/mailers` directory itself, it is not necessary to delete the file individually. https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/app_generator.rb#L329 | ||||
* | | remove `skip_bundle` option from plugin generator | yuuji.yaginuma | 2016-12-31 | 2 | -3/+3 |
| | | | | | | | | | | | | | | Because `bundle install` is not executed regardless of whether the option is specified or not. Ref: fbd1e98cf983572ca9884f17f933ffe92833632a | ||||
* | | Remove deprecated support to passing a column to #quote | Rafael Mendonça França | 2016-12-29 | 1 | -0/+1 |
| | | |||||
* | | Correct indent-accounting in controller route generation | Matthew Draper | 2016-12-25 | 1 | -11/+14 |
| | | | | | | | | | | | | Fixes #27447 [Matthew Draper & Yuuji Yaginuma] | ||||
* | | Privatize unneededly protected methods in Railties | Akira Matsuda | 2016-12-25 | 16 | -86/+90 |
| | | |||||
* | | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 2 | -0/+4 |
|/ | |||||
* | Remove unused method `namespaced_file_path` | Fumiaki MATSUSHIMA | 2016-12-14 | 1 | -4/+0 |
| | | | | | | | | ``` $ git grep namespaced_file_path railties/lib/rails/generators/named_base.rb: def namespaced_file_path railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/") ``` | ||||
* | Don't assign a default to `webpack`. | Kasper Timm Hansen | 2016-12-12 | 1 | -2/+2 |
| | | | | | | | Unintentionally makes `--webpack` implied on `rails new apper`. If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`, so we can check for that instead of `"base"`. | ||||
* | Add option to trigger JS framework-specific installation as part of webpack ↵ | David Heinemeier Hansson | 2016-12-12 | 1 | -2/+5 |
| | | | | setup | ||||
* | Oops! | Akira Matsuda | 2016-12-12 | 1 | -1/+1 |
| | | | | namespace_ladder can be nil here | ||||
* | :nail_care: | Akira Matsuda | 2016-12-12 | 1 | -2/+2 |
| | | | | Don't expect the caller of this method to know that the return value has an extra " " | ||||
* | run `webpack` command only when webpack option is specified | yuuji.yaginuma | 2016-12-10 | 1 | -1/+1 |
| | |||||
* | gemfile entry method need to return an empty array rather than nil (#27318) | Yuji Yaginuma | 2016-12-09 | 1 | -4/+4 |
| | | | | | | | | | This fixes the following error when executing rails new command. ``` (erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError) ``` Follow up to #27288 | ||||
* | Use GitHub webpacker until closer to release | David Heinemeier Hansson | 2016-12-09 | 1 | -1/+1 |
| | |||||
* | Basic --webpack delegation to new webpacker gem (#27288) | David Heinemeier Hansson | 2016-12-09 | 2 | -1/+16 |
| | |||||
* | Show message if Yarn is not installed (#27312) | Guillermo Iguaran | 2016-12-09 | 1 | -1/+8 |
| | |||||
* | Only have Yarn bundling commented out as we cant be sure Yarn is installed | David Heinemeier Hansson | 2016-12-08 | 2 | -5/+2 |
| | |||||
* | specify `skip_yarn` option in API-only Application (#27309) | Yuji Yaginuma | 2016-12-08 | 1 | -2/+8 |
| | |||||
* | Make Yarn the default, drop default vendor/asset directories (#27300) | David Heinemeier Hansson | 2016-12-08 | 8 | -84/+22 |
| | |||||
* | Update puma.rb | brchristian | 2016-12-05 | 1 | -6/+6 |
| | | | Clarifying some of the language/punctuation and removing a couple comma splices. | ||||
* | Add fullstop following the pattern used in rest of the file | Prathamesh Sonpatki | 2016-12-05 | 1 | -1/+1 |
| | |||||
* | use yarn binstub in `bin/update` | yuuji.yaginuma | 2016-12-02 | 1 | -1/+1 |
| | | | | Follow up to 3dac36bd8e26363bb10f4d2a7b21efa75d200e26 | ||||
* | Yarn: Move node_modules, package.json, and yarn.lock file to vendor (#27245) | David Heinemeier Hansson | 2016-12-01 | 6 | -9/+13 |
| | | | Move node_modules, package.json, and yarn.lock file to vendor | ||||
* | use `Gem.win_platform?` to check windows Ruby platforms | yuuji.yaginuma | 2016-11-30 | 3 | -4/+4 |
| | | | | | `Gem.win_platform?` check if it is Windows more accurately. Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952 | ||||
* | Let's use only vendored rails-ujs while we start to publish it to npm registry | Guillermo Iguaran | 2016-11-29 | 1 | -3/+1 |
| | |||||
* | Merge pull request #26836 from Liceth/npm | Guillermo Iguaran | 2016-11-29 | 7 | -3/+82 |
|\ | | | | | Add Yarn support in new apps using --yarn option | ||||
| * | Run yarn on setup and update scripts. | Liceth Ovalles | 2016-11-28 | 2 | -2/+8 |
| | | |||||
| * | Add node_modules to default gitignore | Liceth Ovalles | 2016-11-28 | 1 | -0/+5 |
| | | |||||
| * | Add node_modules path to assets load paths when --yarn option is used | Liceth Ovalles | 2016-11-28 | 1 | -0/+4 |
| | | |||||
| * | Add package.json for Yarn if --yarn option is added | Liceth Ovalles | 2016-11-28 | 3 | -1/+65 |
| | | |||||
* | | rails-ujs is now shipped with Action View | Guillermo Iguaran | 2016-11-29 | 1 | -3/+0 |
|/ | |||||
* | Don't add jQuery by default in new apps and use rails-ujs as UJS adapter instead | Guillermo Iguaran | 2016-11-21 | 2 | -4/+11 |
| | |||||
* | Use existing --skip-turbolinks option for conditionals instead of checking ↵ | Guillermo Iguaran | 2016-11-19 | 2 | -2/+2 |
| | | | | if turbolinks is present in gemfile list | ||||
* | Use secure source for gems referencing "github" in the generated apps | Prathamesh Sonpatki | 2016-11-18 | 1 | -0/+5 |
| | | | | | | | - New apps generated on master and latest bundler give warning about "github" source being insecure. - Use the same solution used for Rails master in the generated app's Gemfile to fix this issue. |