| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
I don't know when this changed, checked back up to 3.2 and integration
tests instantiate fixtures just fine.
|
|\
| |
| | |
rake stats for engines
|
| | |
|
|\ \
| | |
| | | |
fixed capitalization [ci skip]
|
| |/ |
|
| | |
|
|\ \
| |/
|/|
| | |
avoid using alias in generators
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Ruby's alias produces public methods, causing a spurious Thor task
to be created. For example, this is the reason MigrationGenerator
currently has two tasks:
> ActiveRecord::Generators::MigrationGenerator.all_tasks.keys
=> ["singular_name", "create_migration_file"]
singular_name was meant to be an attribute, not a task. Because it's
public, it gets called as a task every time the generator is invoked.
The fix is to ensure all generator methods have the correct
visibility.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The fix introduced at 75ba7425f6d235f254c00a45a58f42e88f80301a were
missing this case.
To fix the original issue mentioned at that commit the correct is to
remove update_config_files from the command list since we should not run
both config_files command when creating a new application.
Tests were added to make sure everything is working fine.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were generating this configuration with :json what may break
applications upgrating from Rails 4.0-.
Now we always generate with a safer value and people is free to choose
hybrid if they want.
We don't generate with hybrid by default because there are some cases
that can fail. These cases are explained on the upgrading guide.
|
| | |
|
| |
| |
| |
| |
| | |
Since the generated application’s Gemfile is using single quotation marks, it
seems fair to use it on plugin’s Gemfile as well.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
GeneratedAttribute#column_name checks already for reference? on the
attribute returning the right name to use as symbol for label and field.
|
| |
| |
| |
| |
| | |
The last uses of this variable was removed with the `--builder` option.
2da5ea1c9feb4a7b491bd00bd6ffd931b9203da8
|
| |
| |
| |
| | |
This reverts commit 7f62f30f58fe5f2955e3292ab1f01aa2c9a8f0ee.
|
| | |
|
|\ \
| | |
| | | |
Improve debugging support
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
sprockets-rails 2.1 needs the precompile list to be available in all
environments.
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| | |
In passing, allow multi-word adapters to be referenced in a URL:
underscored_name must become hyphened-name.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll
change to the absolute-path interpretation in 4.2.
The current "correct" spellings for in-memory, relative, and absolute
URLs, respectively, are:
sqlite3::memory:
sqlite3:relative/path
sqlite3:/full/path
Substantially reverses/defers fbb79b517f3127ba620fedd01849f9628b78d6ce.
Uncovered by @guilleiguaran while investigating #14495, though that
sounds like a different issue.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ActiveRecord::Base.pluralize_table_names = false.
Previously, generation a migration like this:
rails g migration add_column_name_to_user name
would not generating the correct table name.
Fixes #13426.
|
| | |
|
| |
| |
| |
| | |
See https://github.com/rails/sass-rails/issues/191 for more information
|
| |
| |
| |
| |
| |
| |
| | |
thor's create_file seems to have a circular dependency on itself when
used with our constant loading stuff.
fixes #14319
|
|\ \
| | |
| | | |
Replace additional instances of map.flatten with flat_map
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
HAML and probably other generators extend this class and invoke
filename_with_extensions with the old signature (without format).
This makes the second argument optional and defaults it to the #format
method which could be overridden as well.
Closes #14132.
|
|\ \
| | |
| | | |
Avoid namespacing routes inside engines
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since #11544, invoking the controller generator, any generated route is
namespaced according to the class_path method. Since a mountable plugin
is namespaced, creating a controller inside would generate a namespaced
route based on the engine's name.
The controller generator now relies on regular_class_path which does not
contain the class hierarchy but the given path.
Fixes #14079.
|
|\ \ \
| | | |
| | | | |
fix test cases
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Bump version of bcrypt gem
|
| |/ / |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
From #14026:
Specific rbx-2 to limit testing on Rubinius 2.x (since there will be
other versions of Rubinius > 2.x soon).
Also, as of Rubinius 2.2.5, it is no longer necessary to bundle the
rubysl gem.
This is what Rails master/4.1 supports, so we don't need to add rubysl to
gemfiles anymore.
|
| |
| |
| |
| |
| |
| | |
This is a follow up to #13515. It includes the name given and
the singularized version in the warning message. This will aide the user
to see wether the detected singular was right or not.
|