| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will
preserve the timezone of the receiver when converting to an instance
of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we
need to introduce a compatibility layer so that apps that upgrade do
not break. New apps will have a config initializer file that defaults
to match the new Ruby 2.4 behavior going forward.
For information about the changes to Ruby see:
https://bugs.ruby-lang.org/issues/12189
https://bugs.ruby-lang.org/issues/12271
Fixes #24617.
|
| |
| |
| |
| |
| |
| |
| |
| | |
`bundler` provides wrapper file to add rask tasks.
https://github.com/bundler/bundler/blob/master/lib/bundler/gem_tasks.rb
Instead of directly call method, by which require this file,
it can be used without updating of Rakefile if task has been added.
|
| | |
|
| |
| |
| |
| |
| |
| | |
With the exception of what is loaded in active_support/rails,
each file is responsible for its own dependencies. You cannot
rely on runtime order of execution.
|
| |
| |
| |
| |
| |
| | |
* Updated syntax
* Updated tests to match syntax
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When generating a plugin without ActiveRecord (-O),
ActionCable wasn't include, which causes problems with the
require action_cable statement in cable.js
add active_job require statement
also updated order of require statements to match with all.rb
|
| | |
|
| | |
|
|/
|
|
|
|
| |
The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features.
We are also matching the stdout logging interface to the default logger in bootstrap https://github.com/rails/rails/blob/f5a5988352b165143f0f9d622707c351c1470882/railties/lib/rails/application/bootstrap.rb#L42-L45.
|
| |
|
|
|
|
|
|
|
|
|
| |
This commit comes from the comments made by @matthewd at https://github.com/rails/rails/pull/23795/files#r54469637
and by @rafaelfranca at https://github.com/rails/rails/pull/23795/files#r54609364
The idea is that if you type (for example) "rake db:migrate" in an AppGenerator,
then this should actually invoke `rake db:migrate` on the command line, whereas
if you type "rails_command db:migrate", this should invoke `rails db:migrate`.
|
|\
| |
| | |
Remove redundant regexp escapes in generators
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the latest version of Web Console, you can call `console` anywhere in
your application and get a console with that binding in it. I think this
is worth advertising, as it may be useful to do outside of controllers
and views.
[ci skip]
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
Between major versions 2 and 3, we hit a bug. It's fixed in version 3,
however, the explicit 2.x requirement of `~> '2.0'` will prevent people
from getting the fix with `bundle update` and they would have to
explicitly set the constraint to `~> '3.0'`.
For more information see: rails/web-console#178.
I propose we drop the explicit version constraints in the Gemfile. Web
Console has been relatively stable for the past couple of years, and I
don't anticipate any major alterations, like we saw between major
versions 1 and 2.
|
|
|
|
| |
Reads much better doesn't it.
|
|
|
|
|
|
| |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
|
|
|
|
|
| |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
|
|
|
|
|
| |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
|
|
|
|
|
| |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
|\
| |
| |
| |
| | |
y-yagi/remove_unnecessary_config_in_sprockets-rails-3
remove config that are no longer needed in sprockets-rails 3
|
| |
| |
| |
| |
| | |
`config.assets.raise_runtime_errors` and `config.assets.digest` are enabled
by default in sprockets-rails 3.
|
|/
|
|
|
| |
Defining paths relative to a file name has always hurt my soul,
with __dir__ we can restore order in the Universe.
|
| |
|
|\
| |
| | |
convert cable.coffee to cable.js
|
| |
| |
| |
| | |
In order to eliminate the dependecy of CoffeeScript.
|
|\ \
| | |
| | | |
do not set Action Cable's config when specify `--skip-action-cable` option
|
| | |
| | |
| | |
| | | |
Also remove duplicated `config.action_cable.url` config.
|
|/ / |
|
|/ |
|
|\
| |
| | |
remove rack cors initializer when updating
|
| |
| |
| |
| | |
Rack cors initializer is only necessary to API-only applications, for when the update is unnecessary.
|
|/ |
|
|
|
|
|
| |
Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
|
|
|
|
|
| |
- We will remove the initializer for old apps which are migrated to
Rails 5 so that they are not affected by this breaking change.
|
|
|
|
|
|
| |
subdomains
- We will reuse config.ssl_options for setting the HSTS settings.
|
|\
| |
| | |
Fix README heading according to Markdown conventions
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The first heading in some README's are indicated using a second level
heading (`##`), which in my opinion is of incorrect structure.
Therefore, in this patch I changed the first heading to a first level
heading (`#`) in README's where this incorrect structure occurs.
[ci skip]
|
| | |
|
| |
| |
| |
| | |
This also marks Action Cable routes as internal to Rails.
|
| | |
|
| |
| |
| |
| | |
Fixes #23855
|
|/
|
|
|
| |
coffee-rails is stable now so we don't need to point to the master
branch.
|
|\
| |
| | |
AppGenerator: Replace 'rake' with 'rails_command'
|
| |
| |
| |
| |
| | |
Follows the convention from Rails 5 of invoking tasks on the command-line
with `rails …` rather than `rake …`.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since Rails 5.0 is switching the Rails command line from 'rake …'
to 'rails …', it makes sense to also replace the `rake` method in
the Rails templates API.
Based on feedback from @matthewd and @kaspth, I chose to replace
`rake` with `rails_command`, which is less confusing than
the alternatives `rails` or `command` or `rails_run` and is not
Thor-reserved word like `task`.
|
|\ \
| | |
| | |
| | |
| | |
| | | |
This is a rebased version of #22825.
Closes #22825.
|