| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
don't package test files in plugin gemspec
|
| |
| |
| |
| |
| |
| |
| |
| | |
In rails engine, there is a dummy application under test,
the size of the test file is increased.
However, there is no need test files for most users,
I think it good to have so as not included by default.
|
| |
| |
| |
| | |
3.0.3 has a bug in OS X.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the implementation of the file update checker written
by Puneet Agarwal for GSoC 2015 (except for the tiny version
of the listen gem, which was 3.0.2 in the original patch).
Puneet's branch became too out of sync with upstream. This is
the final work in one single clean commit.
Credit goes in the first line using a convention understood
by the contrib app.
|
|/
|
|
|
|
|
|
|
| |
generator
In the app generator, regardless of the namespace, it is adapted to read the same `application_controller.rb`,
modified to api generator also be the same behavior.
ref 686966a1861e6761021d45f6795de753e8a62216, 06ac63b4c602e4b26cb3bfbf0dfd2bed8b00e786
|
|
|
|
|
|
| |
It was deprecated in https://github.com/rails/rails/pull/19135.
We're now favoring `public_file_server.headers`.
|
|
|
|
|
|
|
|
| |
As discussed in https://github.com/rails/rails/pull/19135#issuecomment-153385986.
Replaces `serve_static_files` to unify the static options under the `public_file_server` wing.
Deprecates `serve_static_files` accessors, but make them use the newer config internally.
|
|
|
|
|
| |
`config.middleware.insert_before` changes require to restart the server
Also added missing `.` at the EOL.
|
|\
| |
| | |
remove unnecessary `.sass-cache` from plugin's gitignore template
|
| |
| |
| |
| | |
Since the sass cache is output to the `tmp/cache/sass`.
|
|/ |
|
|
|
|
|
|
| |
We are using the same version constraint in the database adapters so
when a new version of the adapter that doesn't work with the version of
rails is released we don't break new applications.
|
| |
|
| |
|
|
|
|
| |
`README` it is changed to `README.rdoc` in 6b126e2, it has been changed to` README.md` further 89a12c9.
|
|
|
|
| |
multiple environments in secrets.yml"
|
|\
| |
| | |
Added an example to show how common secrets can be shared across multiple environments in secrets.yml [ci skip]
|
| | |
|
| | |
|
| |
| |
| |
| | |
`images` method has been deleted in 2bc4856, `create_images_directory` does nothing.
|
| | |
|
|\ \
| | |
| | | |
migrations Class methods have nodoc, fix it for API [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
add application_job.rb to template of mountable engine
|
| | | |
| | | |
| | | |
| | | |
| | | | |
since cb012467214f6e4bb1ac3987554bb75020b4796b, generated job inherents from ApplicationJob,
ApplicationJob is required in the mountable engine.
|
|\ \ \ \
| |_|/ /
|/| | |
| | | | |
Add basic support for access control headers to ActionDispatch::Static
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Now ActionDispatch::Static can accept HTTP headers so that developers
will have control of returning arbitrary headers like
'Access-Control-Allow-Origin' when a response is delivered. They can
be configured through `#config.public_file_server.headers`:
config.public_file_server.headers = {
"Cache-Control" => "public, max-age=60",
"Access-Control-Allow-Origin" => "http://rubyonrails.org"
}
Also deprecate `config.static_cache_control` in favor of
`config.public_file_server.headers`.
|
| | | |
| | | |
| | | |
| | | | |
Since the plugin generator do not generate assets, I think manifest.js also that it unnecessary.
|
|\ \ \ \
| | | | |
| | | | | |
change `prepare_destination` to public API [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`prepare_destination` has been used in the template file for the generator,
I think it should be a public API
ref: https://github.com/rails/rails/blob/master/railties/lib/rails/generators/test_unit/generator/templates/generator_test.rb#L8
|
|/ / / /
| | | |
| | | |
| | | | |
`shellwords` is no longer needed from #20605.
|
|\ \ \ \ |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
using string for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Move `app/assets/manifest.js` to `app/assets/config/manifest.js`.
Avoid the suggestion that you can/should deep-link `stylesheets/foo`.
* Pull in all toplevel stylesheets and JavaScripts, not just
`application.js` and `.css`. Demonstrate how to use `link_directory`
with a specified `.js`/`.css` type.
* Fix RAILS_ENV handling in assets tests.
* Shush warnings spam from third-party libs that distract from tests.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
generator
This is follow up to #6643.
In #6643, the controller generator only had been fixed, in this commit to fix the scaffold generator.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
skip]
Bumps from `5.6` to `5.7`
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I do not know why files under the support has been require.
However, under the support even rails application does not use.
In addition, since the default under the support file nor is generated, it requires I think not necessary
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The semantic versioning specification uses MAJOR.MINOR.PATCH – it would
make more sense to set the version to 0.1.0 for initial development
since a patch release cannot be created before a minor feature release.
|
|\ \ \ \
| | | | |
| | | | | |
Replace the giant comment in routes.rb with a link to the guides
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This comment not only serves no purpose, but in my experience is
actively detrimental to new developers getting started with Rails.
Expereinced developers just end up deleting this comment, and are
annoyed that they had to take this step. I also spend a lot of time
mentoring brand new developers, and a consistent theme I've seen is that
this comment just ends up intimidating them, and making them think it's
dangerous to edit this file.
One of my students just said this (due to the number of comments which
even new developers don't actually read, they just see it as a sign that
this thing is "dangerous").
> I don't edit any file that Rails generates for me, until my instructor
> says that it's OK to do so.
Realistically, this comment adds 0 value. We have very good
documentation, which we can just link to instead. If someone is truly
new enough to benefit from this info, they presumably just ran `gem
install rails`, and have an internet connection that they can use to
read the routing guide.
The choice of language here was very specific. I chose "the DSL
available" over "what is possible", because a consistent theme I've
noticed among my students is that they aren't aware that this is
actually a Ruby file, and can write any Ruby code here that they want.
This file is not the only offender, but is by far the biggest point of
pain that I've seen, and felt it was a good spot to open this
discussion.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
make generated scaffold functional tests work inside API engines
|