aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails/generators
Commit message (Collapse)AuthorAgeFilesLines
* Use reserved domain for example configurationJacob Bednarz2019-07-151-1/+1
| | | | | | | Updates the generator output to use a reserved domain[1] instead of a potentially real world domain. [1]: https://tools.ietf.org/html/rfc2606#section-3
* Adds support for configuring HTTP Feature Policy (#33439)Jacob Bednarz2019-07-101-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A HTTP feature policy is Yet Another HTTP header for instructing the browser about which features the application intends to make use of and to lock down access to others. This is a new security mechanism that ensures that should an application become compromised or a third party attempts an unexpected action, the browser will override it and maintain the intended UX. WICG specification: https://wicg.github.io/feature-policy/ The end result is a HTTP header that looks like the following: ``` Feature-Policy: geolocation 'none'; autoplay https://example.com ``` This will prevent the browser from using geolocation and only allow autoplay on `https://example.com`. Full feature list can be found over in the WICG repository[1]. As of today Chrome and Safari have public support[2] for this functionality with Firefox working on support[3] and Edge still pending acceptance of the suggestion[4]. #### Examples Using an initializer ```rb # config/initializers/feature_policy.rb Rails.application.config.feature_policy do |f| f.geolocation :none f.camera :none f.payment "https://secure.example.com" f.fullscreen :self end ``` In a controller ```rb class SampleController < ApplicationController def index feature_policy do |f| f.geolocation "https://example.com" end end end ``` Some of you might realise that the HTTP feature policy looks pretty close to that of a Content Security Policy; and you're right. So much so that I used the Content Security Policy DSL from #31162 as the starting point for this change. This change *doesn't* introduce support for defining a feature policy on an iframe and this has been intentionally done to split the HTTP header and the HTML element (`iframe`) support. If this is successful, I'll look to add that on it's own. Full documentation on HTTP feature policies can be found at https://wicg.github.io/feature-policy/. Google have also published[5] a great in-depth write up of this functionality. [1]: https://github.com/WICG/feature-policy/blob/master/features.md [2]: https://www.chromestatus.com/feature/5694225681219584 [3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1390801 [4]: https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/33507907-support-feature-policy [5]: https://developers.google.com/web/updates/2018/06/feature-policy
* Merge pull request #36534 from y-yagi/fixes_35137Yuji Yaginuma2019-07-031-0/+3
|\ | | | | Add the ability to set the CSP nonce only to the specified directives
| * Add the ability to set the CSP nonce only to the specified directivesyuuji.yaginuma2019-06-221-0/+3
| | | | | | | | | | | | | | | | | | | | | | I changed to set CSP nonce to `style-src` directive in #32932. But this causes an issue when `unsafe-inline` is specified to `style-src` (If a nonce is present, a nonce takes precedence over `unsafe-inline`). So, I fixed to nonce directives configurable. By configure this, users can make CSP as before. Fixes #35137.
* | Replace the www.robotstxt.org URL with https one [ci skip]Tatsuya Hoshino2019-06-251-1/+1
|/ | | | The robots.txt site is moved permanently to https URL.
* Make `ActionDispatch::Response#content_type` behavior configurableyuuji.yaginuma2019-06-211-0/+3
| | | | | | | | | I changed return value of `ActionDispatch::Response#content_type` in #36034. But this change seems to an obstacle to upgrading. https://github.com/rails/rails/pull/36034#issuecomment-498795893 Therefore, I restored the behavior of `ActionDispatch::Response#content_type` to 5.2 and deprecated old behavior. Also, made it possible to control the behavior with the config.
* Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-1317-18/+0
| | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Remove redundant blank line at the bottom of the generated controller testyuuji.yaginuma2019-06-071-1/+1
|
* Fix rubocop violationyuuji.yaginuma2019-06-051-2/+1
|
* Bring `after_bundle` back to API document [ci skip]yuuji.yaginuma2019-05-291-1/+6
| | | | | At class level `:nodoc:` all elements are prevented. Instead, use `:stopdoc:` / `:startdoc:` to make `after_bundle` appear.
* Skip needless spaces from generated app layout.Kasper Timm Hansen2019-05-261-1/+1
|
* Bump Gemfile entry jbuilder versionAnton Rieder2019-05-231-1/+1
| | | | | | | | | | jbuilder 2.6.4 is the first version that relaxes the version constraint to allow Rails 6. I also did some more tests in #25183, although not with 2.6.4 explicitly. To simplify the version requirement, I went for 2.7. https://github.com/rails/jbuilder/blob/v2.6.4/jbuilder.gemspec https://github.com/rails/rails/issues/25183#issuecomment-494342406
* Update the sqlite db yaml template to match others and mention proper ↵Vipul A M2019-05-122-2/+2
| | | | supported version
* Use a better requirement for sass-rails 6 prereleasesDavid Rodríguez2019-05-091-1/+1
| | | | | | | | This is the behavior I naively expect for the operator when used with a single digit, but it's definitely an edge case for it, and it doesn't seem to work as expected for including prereleases. Using >= works fine and make the intention more clear anyways.
* Make generated test work even when using virtual attributesyuuji.yaginuma2019-05-054-7/+17
| | | | | | | | | The virtual attributes(`attachment` and `rich_text`) can't set value with `fill_in`. So avoid using it. Once #35885 is merged, will be modified to use it. Also, add checking attachment attached or not for avoiding `DelegationError` when attachment didn't attach.
* Bump bootsnap to a version with disables iseq_cache for Ruby 2.5Prathamesh Sonpatki2019-04-261-1/+1
| | | | - Refs https://github.com/Shopify/bootsnap/pull/257
* Merge pull request #36067 from st0012/update-generator-for-api-appRafael França2019-04-232-0/+4
|\ | | | | Remove action_controller.perform_caching from api app's configs
| * Remove action_controller.perform_caching from api app's configsst00122019-04-242-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | As suggested in https://github.com/rails/rails/issues/35602#issuecomment-485833483, because we don't provide view caching and doesn't include `ActionController::Caching` for api apps, we should also avoid generating ```ruby config.action_controller.perform_caching = true ``` for those api apps. So it won't confuse people. **But because `perform_caching` will be `true` if not set, the behavior of the app would still be the same without these configs.**
* | Merge pull request #35852 from larouxn/resurrectionRafael França2019-04-231-0/+7
|\ \ | |/ |/| Resurrect external JS/CS generation
| * Burn unnecessary files 🔥Nicholas La Roux2019-04-053-19/+0
| |
| * Style fixesNicholas La Roux2019-04-051-3/+3
| |
| * Resurrect generator templatesNicholas La Roux2019-04-052-0/+4
| |
| * Resurrect js/js engine options and generatorsNicholas La Roux2019-04-052-0/+22
| |
* | Allow sass-rails greater than 5.x in new appsGuillermo Iguaran2019-04-221-1/+1
| |
* | Add `null: false` constraint by default for `belongs_to` associationsPrathamesh Sonpatki2019-04-191-2/+8
| | | | | | | | | | | | - Also deprecate passing {required} to the model generator. - Also made sure the global config `belongs_to_required_by_default` is applied correctly to the model generator for `null: false` option.
* | Factorize bin/update in bin/setup, and make bin/setup idempotentDavid Stosik2019-04-172-35/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `bin/setup` and `bin/update` are currently almost the same file. The only thing that keeps them apart is that one is running `bin/rails db:setup` and the other `bin/rails db:migrate`. I'm suggesting here that they should be a unique script, which needs to be idempotent. - New to a project, need to get started? `bin/setup` - Need to install new dependencies that were added recently? `bin/setup`. Before deprecating `bin/update`, I'm suggesting we just have it call `bin/setup`.
* | generate config.cache_classes = false if SpringXavier Noria2019-04-141-5/+10
| |
* | Delete not user method for plugin_generatorsoartec-lab2019-04-091-15/+0
|/
* Use `execute_batch2` rather than `execute_batch` to fix performance ↵Ryuta Kamizono2019-04-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | regression for fixture loading d8d6bd5 makes fixture loading to bulk statements by using `execute_batch` for sqlite3 adapter. But `execute_batch` is slower and it caused the performance regression for fixture loading. In sqlite3 1.4.0, it have new batch method `execute_batch2`. I've confirmed `execute_batch2` is extremely faster than `execute_batch`. So I think it is worth to upgrade sqlite3 to 1.4.0 to use that method. Before: ``` % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids Using sqlite3 Run options: -n test_eager_loading_too_may_ids --seed 35790 # Running: . Finished in 202.437406s, 0.0049 runs/s, 0.0049 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips ARCONN=sqlite3 bundle exec ruby -w -Itest -n test_eager_loading_too_may_ids 142.57s user 60.83s system 98% cpu 3:27.08 total ``` After: ``` % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids Using sqlite3 Run options: -n test_eager_loading_too_may_ids --seed 16649 # Running: . Finished in 8.471032s, 0.1180 runs/s, 0.1180 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips ARCONN=sqlite3 bundle exec ruby -w -Itest -n test_eager_loading_too_may_ids 10.71s user 1.36s system 95% cpu 12.672 total ```
* Don't normalize `original_app_name`Ryuta Kamizono2019-04-031-2/+2
| | | | | `original_app_name` is used to show error message if giving app name is invalid, it should be shown raw app name.
* Merge pull request #35805 from excid3/attachments-field-generatorsRafael França2019-04-027-20/+51
|\ | | | | Add attachment and attachments field generators
| * Add attachment and attachments field generatorsChris Oliver2019-03-307-20/+51
| |
* | Include final newline in generated .ruby-versionOrhan Toy2019-04-011-1/+1
|/
* Add rich_text field to model generatorsChris Oliver2019-03-282-10/+19
|
* bumps Zeitwerk and BootsnapXavier Noria2019-03-261-1/+1
|
* Use webdrivers instead of chromedriver-helper in new appsGuillermo Iguaran2019-03-241-2/+2
|
* Indentation >>Akira Matsuda2019-03-131-3/+3
|
* Fix links in gemspec and docs from http to https.Abhay Nikam2019-03-091-1/+1
|
* Don't lock the webpacker gem by its patch versionSharang Dashputre2019-03-091-1/+1
|
* Use the latest stable release of webpackerSharang Dashputre2019-03-091-1/+1
|
* Add version awareness to rails db:system:changeGannon McGibbon2019-03-081-2/+12
|
* Correctly escape ERB tagyuuji.yaginuma2019-03-041-1/+1
| | | | Ref: https://travis-ci.org/rails/rails/jobs/501220262#L1194
* Add an example about how to load images under app/javascript/imagesGuillermo Iguaran2019-03-031-0/+8
| | | Similarly to https://github.com/rails/webpacker/pull/1976
* Depend on bootsnap 1.4.1Rafael Mendonça França2019-02-251-1/+1
| | | | This is needed to fix #35278.
* Let Zeitwerk be a dependency of Active SupportXavier Noria2019-02-131-3/+1
| | | | | Zeitwerk is a strong dependency, planned to replace AS::Dependencies. A line in the generated Gemfile does not convey this as much.
* Zeitwerk integrationXavier Noria2019-02-121-2/+4
|
* Rename database_operations config to *_contextJohn Hawthorn2019-02-071-4/+5
|
* Remove finalizer and configurationAaron Patterson2019-02-061-3/+0
|
* Set sqlite3 gem version explicitly in generated GemfileSergey Ponomarev2019-02-051-0/+1
|
* Enable `Lint/ErbNewArguments` cop to avoid the deprecated arguments warningRyuta Kamizono2019-02-011-2/+1
| | | | | | Related 5754a29a974d31cab2b4392716b9825a3d910a69. And follows Ruby standard library style https://github.com/ruby/ruby/commit/3406c5d.
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-06 11:25:18 +0000