| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
In #11088, `#to_a` was added to remove a deprecation around using
`#all`. I merged, but it really should have been `#scoped` instead, as
that's the preferred replacement.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Is it more suitable that using ```<th colspan="3">``` instead of three empty ```<th>```? It is simple, but what i am missing about it?
Change repetitive th tags to use colspan attribute
Update CHANGELOG.md
Update CHANGELOG.md
|
|
|
|
| |
all directives
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, ActiveModel is only loaded by ActiveRecord. If you skip ActiveRecord, ActiveModel will not be required (or even autoloaded) and including `ActiveModel::Model` into a plain Ruby class will raise `NameError`.
To reproduce this:
- create a new app with `rails new my_app -O`
- create a Ruby class that includes `ActiveModel::Model` in `app/models`
- load up a Rails console and try to do anything with the class :-)
Since ActionPack relies so heavily on the ActiveModel API, this should probably be considered a dependency of the app. Another possibility would be to make it a dependency of ActionController.
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When bundling a gem created with
rails plugin new
Bundler outputs the following warning when building the gem:
WARNING: licenses is empty
modified: railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec
|
| | |
|
| |
| |
| |
| |
| |
| | |
If you generate a fresh app without ActiverRecord, this template
exhibited a lone trailing line break. My watchful pre-commit hook
told me about it so I've fixed it here.
|
| |
| |
| |
| | |
stub command description
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prior to this change, for the following command:
$ rails new
we received "Options should be given after the application name" as an error message.
This is outdated and should be "Application name should be provided in arguments".
|
|\ \
| |/
|/| |
Remove jruby-openssl from default Gemfile
|
| | |
|
|\ \
| |/
|/|
| |
| | |
Conflicts:
activesupport/lib/active_support/callbacks.rb
|
| | |
|
| | |
|
| |
| |
| |
| | |
- http://help.github.com/ignore-files redirects to https://help.github.com/articles/ignoring-files
|
| | |
|
| |
| |
| |
| |
| |
| | |
Scaffold generator with --assets=false option
outputs an error
See #9525
|
|\ \
| | |
| | | |
generate 'app/assets/images' directory when creating new rails app. Fixes #10434
|
| |/ |
|
|\ \
| |/
|/| |
Relaxed jbuilder dependency in Gemfile template
|
| | |
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
pabloh/extract_regexp_at_generators_testing_assertion"
This reverts commit 81f243375b9d3cfd431c1ca904c5c1efc9a41ae8, reversing
changes made to c7673b0981d961e5510c85d958c944876d543314.
|
| |\ \
| | | |
| | | |
| | | |
| | | | |
pabloh/extract_regexp_at_generators_testing_assertion
Extract method declaration regexp for assert_method into a constant
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
syntax. This helps removing the class level abstraction of an
application.
|
| | | | |
|
| | | | |
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Otherwise we get extra indent for the <td> elements due to the extra
spaces at the beginning of the lines, like this:
<tr>
<td><%= author.name %></td>
<td><%= link_to 'Show', author %></td>
<td><%= link_to 'Edit', edit_author_path(author) %></td>
|
|/ / / / |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 575838795019f7402992e3bfa83a0c5048cf143d.
Conflicts:
railties/lib/rails/generators/app_base.rb
Reason: sprockets 2.9.1 fixes this issue
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
applications
This gem will not change often to explain it be included in the
application Gemfile
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Following up on an observation by @rafaelfranca
https://github.com/rails/rails/pull/10170/files#r3753963
Reduce the number of gsub calls to the two cases where inputs are concatenated
from various sources and with inconsistent indentation.
Also zap extraneous spacing from the sass-rails line... presumably this is a
holdover from a previous time where this aligned the version string with an
adjacent line.
|
|/ /
| |
| |
| |
| |
| | |
* When run with default options, no repeated blank lines
* Every gem has a comment, perhaps a generic one, but a comment nonetheless
* Most comments used to start with "Use", some with "To use" => made consistent
|
| |
| |
| |
| |
| |
| | |
See https://travis-ci.org/rails/rails/jobs/6110543#L1285 for the failure
cc @josh
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* master: (44 commits)
Improve the changelog entry [ci skip]
Fix explicit names on multiple file fields
Correctly parse bigint defaults in PostgreSQL
Move changelog to the top [ci skip]
Fix indent and remove extra white spaces
Fix scope chaining + STI
failing test for #9869
Improve `belongs_to touch: true` timestamp test
Sort modules in alphabetical order.
Avoid an attempt to fetch old record when id was not present in touch callback
Use the correct pk field from the reflected class to find the old record
Refactor mail_to to not generate intermediate hashes when adding href
Ensure mail_to helper does not modify the given html options hash
Use inspect when writing the foreign key from the reflection
Use a space after the comment sign when showing the result of commands
Exclude template files for rdoc API [ci skip]
template should have generic name
use | to have more intent revealing code
Revert "Merge pull request #10034 from benofsky/fix_skipping_object_callback_filters"
stop depending on callbacks
...
Conflicts:
railties/test/application/rake_test.rb
|
| | |
| | |
| | |
| | |
| | |
| | | |
* Added information about syntax for precision/scale of decimals
* Removed incorrect information about being able to set `default`
* Added more examples of usage
|