| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| | |
Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps.
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This stems from [a comment](rails#17227 (comment)) by @dhh.
In summary:
* New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning.
* Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning.
For this purpose, this commit introduces a Rails configuration option:
```ruby
config.active_support.halt_callback_chains_on_return_false
```
For new Rails 5.0 apps, this option will be set to `false` by a new initializer
`config/initializers/callback_terminator.rb`:
```ruby
Rails.application.config.active_support.halt_callback_chains_on_return_false = false
```
For existing apps ported to Rails 5.0, the initializers above will not exist.
Even running `rake rails:update` will not create this initializer.
Since the default value of `halt_callback_chains_on_return_false` is set to
`true`, these apps will still accept `return true` as a way to halt callback
chains, displaying a deprecation warning.
Developers will be able to switch to the new behavior (and stop the warning)
by manually adding the line above to their `config/application.rb`.
A gist with the suggested release notes to add to Rails 5.0 after this
commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
|
|/
|
|
| |
Fix #18301
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes `rails g model Post user:references` from
def change
create_table :posts do |t|
t.references :user, index: true
end
add_foreign_key :posts, :users
end
to
def change
create_table :posts do |t|
t.references :user, index: true, foreign_key: true
end
end
Changes `rails g migration add_user_to_posts user:references` from
def change
add_reference :posts, :users, index: true
add_foreign_key :posts, :users
end
to
def change
add_reference :posts, :users, index: true, foreign_key: true
end
|
|
|
|
|
|
| |
The changes in #18149 added tests for the app generator, but only fixed
it for the plugin generator (I should have let CI finish though I think
it would have failed as an allowed failure).
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Allow static asset serving from env variable (enhanced!)
Conflicts:
railties/CHANGELOG.md
|
| |
|
| |
|
| |
|
|
|
|
| |
See 63462ec
|
| |
|
|
|
|
|
|
| |
Fixes:
http://intertwingly.net/projects/AWDwR4/checkdepot-215/makedepot.log
|
|\
| |
| | |
Don't remove mailer layouts files
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes https://github.com/rails/rails/issues/17340.
Use Minitest::BacktraceFilter instead of removing all silencers. This
will allow the backtrace for all libraries in the plugin to be shown
while removing noise generated by Minitest's backtrace.
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
This reverts commit 2a4e14db981e38611667d407a975600ee720ada7.
|
| |
|
| |
|
|\
| |
| | |
Use web_console 2.0 for 4.2.0.rc1 release
|
| |
| |
| |
| |
| | |
This one replaces the notable web-console mentions in guide and the
default Gemfile.
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Creating mailer layouts by default, including html and body tags
|
| | |
|
| |
| |
| |
| | |
tags to reduce spam score
|
| |
| |
| |
| |
| |
| | |
- Remove sprockets-rails from generated Gemfile as rails has a hard-dependency on it
- Also allow sprockets-rails >= 2.0.0
|
| |
| |
| |
| | |
I put the wrong path in my last PR by accident. Fixed here. Related to #17742
|
| |
| |
| |
| |
| |
| | |
Currently, the docs uses a syntax that is unclear and not general
American English. I've switched it to be clearer wording. Not a big
fix, but may be helpful.
|
| |
| |
| |
| |
| |
| |
| |
| | |
We generate a `.keep` file inside the log directory to make
sure the directory itself is under version control. let's keep
it that way.
/cc @matthewd
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Skip spring install in Cygwin due to fork() bad support.
|
| |/
| |
| |
| | |
See also: https://www.cygwin.com/faq.html#faq.using.fixing-fork-failures
|
| | |
|
| |
| |
| |
| |
| |
| | |
This is a more conservative approach to 2602a49. Also changed the comment to be
more inline with everything else in the file (describing what the config value
is doing and why). People should just read the docs for alternatives.
|