aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails/generators
Commit message (Collapse)AuthorAgeFilesLines
* Force generated route to be insertedAndrew White2015-02-051-1/+1
| | | | | | | Thor isn't very discerning over whether some content is present when passed to `inject_into_file`, e.g. a commented out route is detected as being present. So to prevent people scratching their heads as to why a route hasn't appeared it's better to fall on the side of having duplicate routes.
* Don't remove all line endings from routes.rbAndrew White2015-02-031-2/+2
| | | | | | | | | | | | When there is a single scaffold in the routes.rb with no other lines then revoking/destroying it will create a routes.rb file with a syntax error. This is because the sentinel for the Thor `route` action didn't include the newline but the logged route code did. The fix is to add the newline to the sentinel and remove it from the the logged route code. Fixes #15913.
* Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846robertomiranda2015-01-312-2/+2
| | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
* Fixed a few things from ee9e4c3Godfrey Chan2015-01-304-5/+5
| | | | | Mostly cosmetics, except that `isolate_namespace` should be applied to the last module in the chain.
* Allow hyphenated names for `rails plugin new` generator.Robin Böning2015-01-3020-63/+92
| | | | | | It was not possible to create a new gem with a hyphenated name via the `rails plugin new` generator. The naming guide of rubygems clearly says dashes should be used for gems that extend other gems. http://guides.rubygems.org/name-your-gem/
* scaffold controller_test template should use kwargs. refs #18323.Yves Senn2015-01-301-5/+5
| | | | This prevents a flood of warnings when generating a new scaffold.
* Add a margin to body and padding to th, td.Adrien Lamothe2015-01-291-0/+11
| | | | Add space to new css defs.
* Merge pull request #18705 from mrgilman/skip-testRafael Mendonça França2015-01-297-11/+11
|\ | | | | Update option to skip test in generators
| * Change option description and update test namesMelanie Gilman2015-01-291-1/+1
| |
| * Update option to skip test in generatorsMelanie Gilman2015-01-277-11/+11
| | | | | | | | Rails no longer generates Test::Unit files by default.
* | Merge pull request #18719 from ↵Yves Senn2015-01-291-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 5t111111/add-fix-for-loading-fixtures-in-engine-tests Add fix for loading fixtures in engine tests (additional fix for #4971) Conflicts: railties/lib/rails/generators/rails/plugin/templates/test/test_helper.rb
| * | Add fix for loading fixtures in engine testsWAKASUGI 5T1111112015-01-291-0/+1
| | |
* | | reassign `file_fixture_path` in plugins `test_helper.rb`. refs #18658.Yves Senn2015-01-291-0/+1
|/ /
* | table name should be plural [ci skip]Jian Weihang2015-01-291-1/+1
| |
* | introduce `ActiveSupport::Testing::FileFixtures`.Yves Senn2015-01-281-0/+1
|/ | | | | | It's a thin layer to provide easy access to sample files throughout test-cases. This adds the directory `test/fixtures/files` to newly generated applications.
* Fix typo 'has' => 'have'Sean Collins2015-01-251-1/+1
|
* Fix typo 'another frameworks' => 'other frameworks'Sean Collins2015-01-251-1/+1
|
* fix wording of CSS manifest instructionsRachel Warbelow2015-01-222-6/+4
|
* Merge pull request #18546 from brainopia/action_view_renderRafael Mendonça França2015-01-221-0/+6
|\ | | | | A shortcut to setup controller environment
| * Add ApplicationController.renderer initializer [ci skip]brainopia2015-01-221-0/+6
| |
* | use two spaces instead of one for include root in jsonBen A Morgan2015-01-211-1/+1
| |
* | bring back unintentionally removed blank line [ci skip]Yves Senn2015-01-171-0/+1
| | | | | | | | Thanks @carlosantoniodasilva :yellow_heart:
* | Merge pull request #18558 from robertomiranda/patch-3 [ci skip]Yves Senn2015-01-171-2/+6
|\ \ | |/ |/| | | Update Molde Generator Usage
| * Update Molde Generator UsageRoberto Miranda2015-01-161-0/+5
|/ | | Including has_secure_token generator
* require 'rails' if not include_all_railties, just as 'rails/all' doesAkira Matsuda2015-01-141-0/+1
|
* Merge pull request #18476 from Alamoz/scaffold_index_view_grammarDavid Heinemeier Hansson2015-01-131-1/+1
|\ | | | | Clean up grammar in scaffold index view, by removing the word 'Listing' ...
| * Clean up grammar in scaffold index view, by removing the word 'Listing' from ↵Adrien Lamothe2015-01-121-1/+1
| | | | | | | | list title.
* | Add the `method_source` gem to the default GemfileSean Griffin2015-01-131-0/+4
| | | | | | | | Fixes #18473
* | Stop promoting rack-cache usage at the moment (not so common or important to ↵David Heinemeier Hansson2015-01-131-6/+0
| | | | | | | | deserve that billing)
* | Show how to change the queuing backend for ActiveJob in productionDavid Heinemeier Hansson2015-01-131-0/+4
| |
* | Set all asset options togetherDavid Heinemeier Hansson2015-01-131-3/+3
|/
* Add Secure Token Generatorrobertomiranda2015-01-111-1/+5
|
* No need of requiring `rbconfig`, it is by-default loadedKuldeep Aggarwal2015-01-101-1/+0
|
* Merge pull request #18378 from ↵Carlos Antonio da Silva2015-01-072-2/+2
|\ | | | | | | | | shunsukeaida/avoid_orm_being_humanized_in_generator_help_message Overwrite descriptions generated by Generators::Base to respect acronym.
| * acronyms like ORM should be in uppercase, so overwrite the desc generated by ↵shunsukeaida2015-01-072-2/+2
| | | | | | | | hook_for
* | Add mailer suffix to generated files and classesCarlos Souza2015-01-063-6/+6
| | | | | | | | | | Following the same naming convention used in controllers and jobs.
* | Remove debugger supportRafael Mendonça França2015-01-042-9/+0
| | | | | | | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore
* | Change transaction callbacks to not swallowing errors.Rafael Mendonça França2015-01-041-5/+0
| | | | | | | | | | | | | | | | Before this change any error raised inside a transaction callback are rescued and printed in the logs. Now these errors are not rescue anymore and just bubble up, as the other callbacks.
* | Merge pull request #13434 from tanraya/local_variablesCarlos Antonio da Silva2015-01-033-6/+6
|\ \ | | | | | | | | | | | | | | | | | | Use local variables in _form.html.erb generated by scaffold. Conflicts: railties/CHANGELOG.md
| * | Use local variables in _form.html.erb generated by scaffold generator.tanraya2014-07-263-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems a good idea to use local variables in generated partials instead of using instance variables. Before <%= render 'form' %> After <%= render 'form', product: @product %>
* | | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-032-0/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | | Add config to halt callback chain on return falseclaudiob2015-01-022-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
* | | | Generated fixtures won't use parent_id when generated with parent:referencesPablo Olmos de Aguilera Corradini2015-01-021-0/+2
|/ / / | | | | | | | | | Fix #18301
* | | Add --skip-action-mailer (or -M) to rails generateclaudiob2015-01-017-4/+15
| | |
* | | Fix scaffold generator with --helper=false optionRafael Mendonça França2015-01-011-0/+1
| | |
* | | Fix description for application_name method - change simple to simplyPrathamesh Sonpatki2014-12-301-1/+1
| | | | | | | | | | | | [ci skip]
* | | plugin's gemfile also needs tzinfo-data in WindowsShunsukeAida2014-12-301-0/+4
| | |
* | | Remove unnecessary double spaceKenta Okamoto2014-12-261-1/+1
| |/ |/|
* | Use the new `foreign_key` option on `references` in generatorsSean Griffin2014-12-221-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes `rails g model Post user:references` from def change create_table :posts do |t| t.references :user, index: true end add_foreign_key :posts, :users end to def change create_table :posts do |t| t.references :user, index: true, foreign_key: true end end Changes `rails g migration add_user_to_posts user:references` from def change add_reference :posts, :users, index: true add_foreign_key :posts, :users end to def change add_reference :posts, :users, index: true, foreign_key: true end
* | Skip byebug on all non-MRI rubies, fix testsSean Griffin2014-12-221-1/+1
| | | | | | | | | | | | The changes in #18149 added tests for the app generator, but only fixed it for the plugin generator (I should have let CI finish though I think it would have failed as an allowed failure).