| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Is this usage correct? cc/ @prathamesh-sonpatki
|
| | | | |
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Consistent examples and template for assets#precompile
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.
This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.
Re-add spaces inside array parentheses.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
y-yagi/remove_test_mailers_when_skipping_action-mailer
remove "test/mailers" directory when skipping action-mailer
|
| |/ / /
| | | |
| | | |
| | | | |
Related to #26146
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
| | |
| | |
| | |
| | | |
Closes #26145
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A few have been left for aesthetic reasons, but have made a pass
and removed most of them.
Note that if the method `foo` returns an array, `foo << 1`
is a regular push, nothing to do with assignments, so
no self required.
|
| | | |
|
|\ \ \
| | | |
| | | | |
.to_i is unnecessary for puma threads.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.
I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.
We may need to backport this for Rails 5.0.1.
Fixes #25899.
|
|\ \ \
| | | |
| | | |
| | | | |
Setup default session store internally, no longer through an initializer
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
initializer
- By default the session store will be set to cookie store with
application name as session key.
- Older apps are not affected as they will have the session store
initializer generated by Rails in older versions, and Rails will not
overwrite the session store if it is already set or disabled.
- But new apps will not have the initializer, instead the session store
will be set to cookie store by default.
- Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
|
|\ \ \ \
| | | | |
| | | | | |
Give importance to rails command [ci skip]
|
| |/ / / |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The options used in this file are *not* directly described in the Rails 5.0
release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but
instead in section 2 of the Guide for Upgrading Ruby on Rails document
(http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).
|
| | | |
|
| | |
| | |
| | |
| | | |
Follow up to #25431
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update
Display link to Rails upgrade guide at the end of `rails app:update` task.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
- This will nudge people in the direction of going through upgrade
guides.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Update to Turbolinks 5.0.0 final
|
| |/ / / |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will fix the failures fixed by
41488adbb89a09fa96188486f8414842ff28c848
and keep this new option that is semi-private
outside of the generated configurations
|
| | |
| | |
| | |
| | |
| | | |
Railties tests didn't know about the new config option added in 80b416f so
it needed to be added to the railties generators for configs.
|
| | |
| | |
| | |
| | |
| | |
| | | |
- As assets are removed for API only apps anyways, so we don't need any
conditional upfront.
- assets are removed for API apps here - https://github.com/rails/rails/blob/94ef224aa61ace3fa643eab161ff9056b7d90a62/railties/lib/rails/generators/rails/app/app_generator.rb#L266-L273.
|
| | |
| | |
| | |
| | |
| | | |
This option is used in a initializer hook that runs before the
config/initializers files so it will not work if it is set there.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/generate_mailer_layout_files_if_it_does_not_already_exist
generate mailer layout files if it does not already exist
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, if `ApplicationMailer` does not exist, it is generated when
run the mailer generator, but layouts files does not generate.
However, because it uses the layouts in `ApplicationMailer`,
layouts are required.
Follow up to #24161
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix API controller tests by assigning them the encoding type
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Fixes #25183.
- The `as: :json` feature was added in
https://github.com/rails/rails/pull/21671 and recommended to use for
JSON endpoints so let's use it by default for API controller tests.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since Ruby 2.4 isn't out yet, the fact that it will make `to_time` preserve the
time zone should be toggled with a update flag.
Second, remove the flipping on what version had what defaults. It's called new
framework defaults, so it's from the future looking. Thus keep the line that
mentions past versions.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
about old apps and how you can upgrade to new defaults.
[Kasper Timm Hansen, Prathamesh Sonpatki]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
request_forgery_protection configs
- Earlier per_form_csrf_tokens and request_forgery_protection config
files were generated for old apps upgraded to Rails 5.
- But when we collapsed all initializers into one file, the entire file
does not get created for old apps.
- This commit fixes it and also changes values for all new defaults for
old apps so that they will not break.
- Also added a test for `rails app:update`.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Move real new default options to the top of the file.
- After that club together all the options which were added to keep
backward compatibility. So all of them will get only one header.
- Based on https://github.com/rails/rails/pull/25231#issuecomment-222945173.
|