Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Privatize unneededly protected methods in Railties | Akira Matsuda | 2016-12-25 | 1 | -12/+12 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -5/+5 |
| | |||||
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -2/+2 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -1/+1 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -2/+2 |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | |||||
* | applies new string literal convention in railties/lib | Xavier Noria | 2016-08-06 | 1 | -9/+9 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Renamed ‘Return’ to ‘Returns’ [ci skip] | Ronak Jangir | 2015-09-28 | 1 | -2/+2 |
| | |||||
* | [skip ci] Lookup can be a noun but it is not a verb | Jon Atack | 2015-07-17 | 1 | -3/+3 |
| | | | | Various grammar corrections and wrap to 80 characters. | ||||
* | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -1/+1 |
| | |||||
* | Replace :base with :in [ci skip] | Marcio Junior | 2014-05-11 | 1 | -2/+2 |
| | |||||
* | Typos. return -> returns. [ci skip] | Lauro Caetano | 2013-12-03 | 1 | -1/+1 |
| | |||||
* | Require the top file and autoload Base class | Rafael Mendonça França | 2013-11-09 | 1 | -2/+0 |
| | | | | | | | The generators entry point file is rails/generators so we need to make sure uers will be able to use the generators when requiring that file. Fixes #12802 | ||||
* | Merge pull request #12733 from robin850/fix-railties-build | Rafael Mendonça França | 2013-11-01 | 1 | -1/+0 |
|\ | | | | | Fix railties build | ||||
| * | Remove "circular require considered harmful" error | Robin Dupret | 2013-11-01 | 1 | -1/+0 |
| | | | | | | | | | | rails/generators should not load rails/generators/base since the latter is loading it. | ||||
* | | More Warnings removed for ruby trunk | Arun Agrawal | 2013-11-01 | 1 | -3/+3 |
|/ | | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb | ||||
* | rename AppPreparer | Aaron Patterson | 2013-10-30 | 1 | -0/+1 |
| | | | | | AppPreparer doesn't actually prepare applications, it scrubs ARGV. Let's also get the class under test while we're at it | ||||
* | Refactoring Generators::Base. | wangjohn | 2013-08-28 | 1 | -14/+17 |
| | | | | | | | The defaults hash isn't used unless the +class_options+ hash has a particular key, so we don't need to compute it unless this is true. Also moving some code for extracting a module into its own method. | ||||
* | Use Ruby 1.9 Hash syntax in railties | Robin Dupret | 2012-10-14 | 1 | -8/+8 |
| | |||||
* | update Rails::Generators docs [ci skip] | Francesco Rodriguez | 2012-10-07 | 1 | -1/+1 |
| | |||||
* | Remove redundant 'the'. | Uģis Ozols | 2012-09-13 | 1 | -1/+1 |
| | |||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -2/+1 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | Require thor 0.15.3 onwards | José Valim | 2012-06-18 | 1 | -0/+1 |
| | |||||
* | Removing ==Examples and last blank lines of docs from railties | Francesco Rodriguez | 2012-05-14 | 1 | -3/+0 |
| | |||||
* | added example, removed blank lines | Hrvoje Šimić | 2012-04-04 | 1 | -10/+0 |
| | |||||
* | Usage file in generators shouldn't be fetched only based on source_root | Piotr Sarnacki | 2012-04-01 | 1 | -4/+17 |
| | | | | | | | | In case `source_roout` is not set, `default_source_root` is used, which includes also `templates` directory. If there is no `templates` directory, `default_source_root` is not available and USAGE will not be displayed. USAGE should be also checked based on default directory excluding `templates`. | ||||
* | Add convenience method to hide a generator from the available ones | Carlos Antonio da Silva | 2012-02-03 | 1 | -0/+6 |
| | | | | | | It is usually useful to be able to hide a generator when running rails generate command. Such generators might be used only to dry up generators code and shouldn't be available to end users. | ||||
* | remove ruby 1.8 support code | Sergey Nartimov | 2012-01-29 | 1 | -6/+2 |
| | |||||
* | Fix rails/generators/base.rb documentation for hook_for | Pavel Gabriel | 2011-12-29 | 1 | -3/+3 |
| | |||||
* | Doc fixes on Rails::Generators::Base.hook_for. | Hendy Tanata | 2011-12-21 | 1 | -3/+3 |
| | |||||
* | treat USAGE as an ERB template | Colin MacKenzie IV | 2011-11-02 | 1 | -1/+1 |
| | |||||
* | Fix rails/generators/base.rb documentation for generator lookup | Ryan Bigg | 2011-10-10 | 1 | -3/+3 |
| | |||||
* | Removed warnings about shadowing variables | Alexey Gaziev | 2011-06-20 | 1 | -3/+3 |
| | |||||
* | Made language consistent with the rest of the comments in the file. | Aditya Sanghi | 2011-05-06 | 1 | -2/+2 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Make sure the Thor generator LoadError does not output --dev twice [#6431 ↵ | Jeff Kreeftmeijer | 2011-02-27 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Make sure that generator's default banner is showing its namespace | Prem Sichanugrist | 2011-01-01 | 1 | -1/+1 |
| | | | | This will make `rails g rspec:install --help` shows "rails generate rspec:install [options]" and not "rails generate install [options]" | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Fixes usage message when running rails without --dev on a cloned rails repo | Santiago Pastorino | 2010-07-26 | 1 | -1/+1 |
| | |||||
* | Changed `ruby /path/to/rails myapp --dev` to `ruby /path/to/rails new myapp ↵ | Jeff Kreeftmeijer | 2010-06-21 | 1 | -1/+1 |
| | | | | | | --dev` in the "Thor is not avalable" message. [#4915 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Removing Metal from Rails 3. | wycats | 2010-05-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | If you have existing Metals, you have a few options: * if your metal behaves like a middleware, add it to the middleware stack via config.middleware.use. You can use methods on the middleware stack to control exactly where it should go * if it behaves like a Rack endpoint, you can link to it in the router. This will result in more optimal routing time, and allows you to remove code in your endpoint that matches specific URLs in favor of the more powerful handling in the router itself. For the future, you can use ActionController::Metal to get a very fast controller with the ability to opt-in to specific controller features without paying the penalty of the full controller stack. Since Rails 3 is closer to Rack, the Metal abstraction is no longer needed. | ||||
* | Update generators to use thor 0.13.6 with simpler source_root handling. | José Valim | 2010-04-30 | 1 | -16/+22 |
| | |||||
* | Load generators from both lib/rails/generators and lib/generators. Using the ↵ | José Valim | 2010-03-23 | 1 | -1/+1 |
| | | | | former since it's less obstrusive. | ||||
* | No -rubygems needed | wycats | 2010-03-22 | 1 | -1/+1 |
| | |||||
* | Provide a better error if thor is missing | wycats | 2010-03-22 | 1 | -1/+9 |
| | |||||
* | fix usage examples and more to use new invocations | RomD | 2010-02-06 | 1 | -4/+4 |
| | | | | Signed-off-by: Carl Lerche <carllerche@mac.com> | ||||
* | Add config.generators.templates to provide alternative paths for template ↵ | José Valim | 2010-02-06 | 1 | -2/+1 |
| | | | | lookup. | ||||
* | Make bin/rails call rails/commands/application, fix generators usage and ↵ | José Valim | 2010-02-03 | 1 | -1/+1 |
| | | | | update .gitignores. |