| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
it has some methods that override the accessors and calls the original accessors via `super`
this partially reverts 9360b6be63b7a452535699bcf6ae853df7f5eea7
|
|
|
|
| |
because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
|
|
|
|
|
|
|
| |
Because `bundle install` is not executed regardless of whether the option
is specified or not.
Ref: fbd1e98cf983572ca9884f17f933ffe92833632a
|
| |
|
| |
|
|
|
|
|
|
|
| |
Unintentionally makes `--webpack` implied on `rails new apper`.
If passed `--webpack` Thor assigns `"webpack"` to `options[:webpack]`,
so we can check for that instead of `"base"`.
|
|
|
|
| |
setup
|
| |
|
|
|
|
|
|
|
|
|
| |
This fixes the following error when executing rails new command.
```
(erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError)
```
Follow up to #27288
|
| |
|
| |
|
| |
|
|
|
| |
Move node_modules, package.json, and yarn.lock file to vendor
|
|
|
|
|
| |
`Gem.win_platform?` check if it is Windows more accurately.
Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952
|
|\
| |
| | |
Add Yarn support in new apps using --yarn option
|
| | |
|
|/ |
|
| |
|
|\
| |
| |
| | |
Add --skip-coffee generating option
|
| |
| |
| |
| |
| |
| | |
Usage
`rails new awesome-project --skip-coffee`
|
| |
| |
| |
| | |
Master based applications should be pointing to master
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Recently, the Rails team made an effort to keep the source code consistent, using Ruboco
(bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case
statements were missed.
This changes the case statements' formatting and is consistent with changes
in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231.
|
| | |
|
| |
| |
| |
| |
| | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|\ \
| | |
| | |
| | | |
Update to Turbolinks 5.0.0 final
|
| |/ |
|
|/ |
|
| |
|
| |
|
|
|
|
|
|
| |
With the exception of what is loaded in active_support/rails,
each file is responsible for its own dependencies. You cannot
rely on runtime order of execution.
|
|
|
|
|
| |
Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
|
|
|
|
|
| |
coffee-rails is stable now so we don't need to point to the master
branch.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
on sprockets environment
- Remove jquery-rails if --skip-sprockets is true
Fixes #23431
|
|
|
|
| |
All grown up and shit!
|
|
|
|
| |
So no need to have it on by default in the Gemfile.
|
|\
| |
| | |
Add Default Puma Config
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When the `puma` command is run without any configuration options it will detect presence of a `config/puma.rb` file and use that. Currently there is discrepancy between `puma` command and `rails server` but Evan said it would be reasonable to add in reading in config from the default location. I am working on that right now as a feature in puma/puma.
Why do we need this? By default Puma uses 16 threads, and by default ActiveRecord only has 5 threads. Due to the architecture of AR it is guaranteed that if you're running with fewer DB connections than your server has threads you will hit `ActiveRecord::ConnectionTimeoutError ` eventually if your app gets modest amounts of traffic. Since we are providing a default webserver, we should provide reasonable configuration for that webserver.
This PR does a few things, first it sets the default Puma thread count to 5 to mach ActiveRecord's default. It sets the default environment to `"development"` and the default port to 300 so that booting the server with `$ puma` will give you the same default port as `rails server`. It is worth mentioning that by reading in from `PORT` environment variable this config can work with containerized deployments, such as on Heroku.
We are not using worker processes by default, that way JRuby and windows devs can use this configuration without modification. I went ahead and included a default `on_worker_boot`. It won't be used unless a worker count is specified, that means this config will not use it. Even though it's not being used now It will make someone who wants to try modifying their config to run extra workers easier.
cc/ @pixeltrix
|
|/
|
|
|
|
| |
This new adapter does get a little more intimate with the redis-rb gem's
implementation than I would like, but it's the least bad of the
approaches I've come up with.
|
| |
|
|
|
|
| |
It was removed by mistake at 877a411d0c16baa4e670dae9a28f5cfcc201adc1
|
|
|
|
|
|
|
| |
- This fixes an error thrown by Thor because type of default value of
`:rc` option which is `:boolean` does not match with it's default type
which is `string`.
- Ref - https://github.com/erikhuda/thor/blob/master/lib/thor/parser/option.rb#L125
|
|\
| |
| |
| | |
Allow normal version updates within a release series
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We originally chose to apply very strict versioning on the `rails` entry
in the Gemfile, because our future versioning policy was not strongly
defined.
Now it is, and our policy is very much designed on the expectation that
people will regularly update to the latest patch level in their release
series... so we should encourage that.
Of course, Gemfile.lock will do its job and prevent unplanned updates,
just as it does for every other gem in the bundle... but if you run
`bundle update`, we want to get you the latest bug/security fixes
without requiring a manual edit of the Gemfile entry.
Our current version could be a few different shapes, so it takes a bit
of work to find the right specifier, but in principle, we match anything
of the form x.y.*, where x.y matches our current release series.
|