Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Zeitwerk integration | Xavier Noria | 2019-02-12 | 1 | -6/+20 |
| | |||||
* | Convert path to string before call `length` | yuuji.yaginuma | 2019-01-28 | 1 | -1/+1 |
| | | | | | | | | Because eager load paths support to using `Pathname`, and `Pathname` doesn't have `length` method. Ref: https://travis-ci.org/rails/rails/jobs/485088071#L5140-L5143 Follow up aadeed1518b9092ea21adf49c728172368129f0e. | ||||
* | Simplify path prefix extraction | Xavier Noria | 2019-01-27 | 1 | -2/+3 |
| | |||||
* | Seed database with inline ActiveJob job adapter | Gannon McGibbon | 2019-01-17 | 1 | -1/+13 |
| | |||||
* | Revert "Merge pull request #33970 from rails/eager-url-helpers" | schneems | 2018-10-03 | 1 | -13/+3 |
| | | | | | | | Until #34050 can be resolved This reverts commit 7f870a5ba2aa9177aa4a0e03a9d027928ba60e49, reversing changes made to 6556898884d636c59baae008e42783b8d3e16440. | ||||
* | Routes from Engine Railties should not be an infinite loop | Aaron Patterson | 2018-09-26 | 1 | -0/+6 |
| | |||||
* | Eager load supports individual files | Aaron Patterson | 2018-09-26 | 1 | -3/+7 |
| | | | | Also we want to eager load routes before anything else. | ||||
* | [Railties] require_relative => require | Akira Matsuda | 2017-10-21 | 1 | -5/+5 |
| | | | | This basically reverts 618268b4b9382f4bcf004a945fe2d85c0bd03e32 | ||||
* | Adding frozen_string_literal pragma to Railties. | Pat Allan | 2017-08-14 | 1 | -0/+2 |
| | |||||
* | [Railties] require => require_relative | Akira Matsuda | 2017-07-01 | 1 | -5/+5 |
| | |||||
* | Define path with __dir__ | bogdanvlviv | 2017-05-23 | 1 | -1/+1 |
| | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f | ||||
* | Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra ↵ | Ryuta Kamizono | 2017-02-12 | 1 | -1/+0 |
| | | | | empty lines | ||||
* | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2017-01-11 | 1 | -4/+4 |
|\ | | | | | | | | | Conflicts: railties/lib/rails/generators.rb | ||||
| * | Capitalize Ruby and small grammar fix | Jon Moss | 2016-12-19 | 1 | -1/+1 |
| | | | | | | | | [ci skip] | ||||
| * | Capitalize Rack gem name | Jon Moss | 2016-12-19 | 1 | -3/+3 |
| | | | | | | | | [ci skip] | ||||
* | | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 1 | -2/+2 |
| | | | | | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | ||||
* | | Privatize unneededly protected methods in Railties | Akira Matsuda | 2016-12-25 | 1 | -13/+13 |
|/ | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -5/+5 |
| | |||||
* | [ci skip] Fixed commas according to Oxford comma in rdoc and guides | Andrey Molchanov | 2016-09-17 | 1 | -1/+1 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -3/+3 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -1/+1 |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -42/+42 |
| | |||||
* | applies new string literal convention in railties/lib | Xavier Noria | 2016-08-06 | 1 | -6/+6 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fix some typos in comments. | Joe Rafaniello | 2016-05-04 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | Merge pull request #20986 from radar/rails-engine-caller-locations | Arthur Nogueira Neves | 2015-10-04 | 1 | -6/+1 |
|\ | | | | | Remove check for caller_locations in Rails::Engine | ||||
| * | Remove check for caller_locations in Rails::Engine | Ryan Bigg | 2015-07-23 | 1 | -6/+1 |
| | | | | | | | | This is no longer necessary, as the minimum version requirement for Ruby is 2.2.2, and the `caller_locations` feature was added in Ruby 2.0.0. Since Rails no longer supports pre 2.0 versions of Ruby, there is no need to check first if the Kernel does respond to `caller_locations`. The answer is: yes it does. | ||||
* | | only construct one request in an engine | Aaron Patterson | 2015-09-30 | 1 | -5/+10 |
| | | |||||
* | | call `default_middleware_stack` before merging stacks | Aaron Patterson | 2015-09-29 | 1 | -1/+2 |
| | | | | | | | | | | | | | | `default_middleware_stack` seems to kick off the `on_load` calls that may mutate the middleware stack. We have to call that method before merging middleware stacks, otherwise the middleware stacks get mutated *after* the app middleware stack is built. | ||||
* | | Engines get different middleware than apps | Aaron Patterson | 2015-09-29 | 1 | -1/+7 |
| | | | | | | | | | | We shouldn't merge the app middleware in to the config middleware for engines. | ||||
* | | Make app building threadsafe | eileencodes | 2015-09-29 | 1 | -4/+8 |
| | | |||||
* | | Stop modifying global variables | eileencodes | 2015-09-29 | 1 | -1/+1 |
| | | | | | | | | | | | | Allocating a new middleware proxy in each application configuration and then merging the app specific config with the global config when the app is built. | ||||
* | | Merge pull request #21124 from kirs/feature/reload-i18n | Kasper Timm Hansen | 2015-08-10 | 1 | -1/+1 |
|\ \ | | | | | | | Reload I18n.load_path in development | ||||
| * | | Reload I18n locales in development | Kir Shatrov | 2015-08-10 | 1 | -1/+1 |
| |/ | |||||
* | | routes in the env via the request object | Aaron Patterson | 2015-08-05 | 1 | -3/+2 |
| | | |||||
* | | allocate a request object to avoid hash allocations | Aaron Patterson | 2015-08-05 | 1 | -3/+2 |
|/ | | | | | This decouples the `call` method from knowing the SCRIPT_NAME key and offloads decisions about how to access script_name | ||||
* | [ci skip] Remove comments about Rails 3.1 | claudiob | 2015-05-11 | 1 | -9/+7 |
| | | | | | | | | | Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939 where @senny said: > From my point of view, all the docs (guides, API) are version bound. > They should describe that version and continue to be available when newer versions are released. > The cross referencing can be done by the interested user. | ||||
* | Merge pull request #19756 from georgemillo/docs | Robin Dupret | 2015-05-05 | 1 | -17/+26 |
|\ | | | | | fixing English in Rails::Engine docs | ||||
| * | fixing English in Rails::Engine docs | George Millo | 2015-04-23 | 1 | -17/+26 |
| | | | | | | | | [ci skip] | ||||
* | | Added missing fullstop in engine API docs [ci skip] | Prathamesh Sonpatki | 2015-05-02 | 1 | -2/+2 |
|/ | |||||
* | pass a config to the route set | Aaron Patterson | 2015-03-05 | 1 | -1/+1 |
| | | | | | This way we can get the relative_url_root from the application without setting another global value | ||||
* | ask the routes objects for its Rack env key | Aaron Patterson | 2015-03-02 | 1 | -1/+1 |
| | | | | | | this centralizes the logic for determining the script name key and drops object allocations when calling `engine_script_name` (which is called on each `url_for`). | ||||
* | Fix some typos in railties/lib/rails/engine.rb [ci-skip] | RobertZK | 2015-02-10 | 1 | -4/+4 |
| | |||||
* | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 | robertomiranda | 2015-01-31 | 1 | -1/+1 |
| | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769 | ||||
* | Remove config.assets | Joshua Peek | 2015-01-21 | 1 | -6/+0 |
| | | | | Provided by sprockets-rails plugin | ||||
* | - Changed `paths` to `routing_paths` to avoid warning `possible reference to ↵ | Vipul A M | 2014-12-26 | 1 | -3/+3 |
| | | | | past scope` | ||||
* | FIX: absolute_path may be nil for code added via instance_eval | Sam | 2014-12-01 | 1 | -1/+1 |
| | |||||
* | Use absolute_path of caller_locations to infer engine root | Alexander Mankuta | 2014-11-26 | 1 | -1/+1 |
| | | | | | According to documentation `path` only returns file names. On MRI it's not the case but it's likely a bug in MRI. | ||||
* | Minor English fixes in docs [ci skip] | George Millo | 2014-11-17 | 1 | -2/+2 |
| | |||||
* | add lib to $LOAD_PATH on application inhertence. fixes #17106 | Aaron Patterson | 2014-11-04 | 1 | -3/+6 |
| | |||||
* | save a hash allocation per request. | Aaron Patterson | 2014-08-08 | 1 | -1/+1 |
| |