Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use backtrace cleaner to clean up backtrace for verbose query logs | Lachlan Sylvester | 2018-08-14 | 1 | -12/+0 |
| | |||||
* | update BacktraceCleaner::RENDER_TEMPLATE_PATTERN to match the ↵ | Lachlan Sylvester | 2018-08-07 | 1 | -1/+1 |
| | | | | ActionView::Template method names | ||||
* | Adding frozen_string_literal pragma to Railties. | Pat Allan | 2017-08-14 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Update backtrace cleaner to use `Regexp#match?` | Bart de Water | 2017-02-13 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in railties/lib | Xavier Noria | 2016-08-06 | 1 | -4/+4 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fixes #25219 | Vipul A M | 2016-07-01 | 1 | -1/+1 |
| | | | | Add handling of cleaning up backtrace from IRB console in case of errors | ||||
* | Move object allocation out of loop | Richard Schneeman | 2014-09-27 | 1 | -4/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now BenchmarkCleaner allocates hundreds of strings on every request with an exception. This patch moves those strings to be generated at boot once and re-used. ## Bench Methods I took a modified form of CodeTriage https://github.com/schneems/codetriage-ko1-test-app/blob/master/perf.rake and ran given rake tasks with and without the patch to BacktraceCleaner. I made an endpoint results in exception ``` def index raise “foo" end ``` The gem `memory_profiler` was used to capture objects allocated for a single request. Then `benchmark/ips` was used to test the speed of the patch. You will see that we use less objects and the code becomes measurably faster with this patch. ## With patch: Memory for one request: ``` Total allocated 7441 Total retained 37 ``` Requests per second: ``` Calculating ------------------------------------- ips 4 i/100ms ------------------------------------------------- ips 43.0 (±4.7%) i/s - 216 in 5.037733s ``` ## Without patch: Memory used for one request: ``` Total allocated 11599 Total retained 35 ``` Requests per second: ``` Calculating ------------------------------------- ips 3 i/100ms ------------------------------------------------- ips 39.4 (±7.6%) i/s - 198 in 5.052783s ``` ## Analysis The patch is faster: ``` (43.0 - 39.4 ) / 39.4 * 100 # => 9 # % ~ speed bump ``` It also allocates less objects: ``` 11599 - 7441 # => 4158 ``` These strings are allocated on __EVERY SINGLE REQUEST__. This patch saves us 4158 objects __PER REQUEST__ with exception. Faster errors == Faster applications | ||||
* | Gem cont presence checking has been removed | Roman V. Babenko | 2012-05-02 | 1 | -2/+0 |
| | |||||
* | Unnecessary uniqueness & force mapping has been removed at ↵ | Roman V. Babenko | 2012-04-03 | 1 | -1/+1 |
| | | | | BacktraceCleaner#add_gem_filters | ||||
* | Remove unneeded code | Rafael Mendonça França | 2012-01-06 | 1 | -13/+0 |
| | |||||
* | in regexps, the dot in a character class is not a metacharacter | Xavier Noria | 2010-10-15 | 1 | -1/+1 |
| | |||||
* | Make backtrace_cleaner work as expected. Prior to this patch, the Full Trace ↵ | José Valim | 2010-05-03 | 1 | -12/+11 |
| | | | | rarely showed the full trace. Also, increase performance considerably. | ||||
* | It seems the test directory backtrace line is output with a / before it, ↵ | Ryan Bigg | 2010-04-05 | 1 | -1/+1 |
| | | | | | | thereby previously making it not match the regex. Support APP_DIRS that have backtrace lines maybe beginning with /. [#4277 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove backtrace cleaner specific to Bundler. Bundler just uses Gem.dir and ↵ | Carl Lerche | 2010-02-11 | 1 | -11/+0 |
| | | | | Gem.path now. | ||||
* | Use backtrace cleaner for dev mode exception page | Joshua Peek | 2010-01-16 | 1 | -15/+16 |
| | |||||
* | Exclude gem backtrace filter if rubygems is not loaded | Joshua Peek | 2009-10-20 | 1 | -2/+2 |
| | |||||
* | Remove config.gem in favor of using the bundler. This makes config/boot.rb ↵ | Carl Lerche | 2009-10-16 | 1 | -4/+0 |
| | | | | | | obsolete. The bundler library is at: http://github.com/wycats/bundler/ and is a rubygem. | ||||
* | Deprecate RAILS_ROOT in favor of Rails.root (which proxies to the ↵ | Carl Lerche | 2009-10-16 | 1 | -2/+2 |
| | | | | application's object root) | ||||
* | Add gem filter for default gem path since it maybe different than the set of ↵ | Joshua Peek | 2009-09-26 | 1 | -1/+1 |
| | | | | gem paths | ||||
* | Rejig active support dependencies to behave better with the boot process | Jeremy Kemper | 2009-04-28 | 1 | -0/+3 |
| | |||||
* | Correctly clean backtraces from vendor/gems and gems in alternate install ↵ | Matt Jones | 2009-03-09 | 1 | -4/+16 |
| | | | | | | locations Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Make sure that Rails frameworks are silenced when running in gem mode too | David Heinemeier Hansson | 2009-03-05 | 1 | -0/+3 |
| | |||||
* | Only silence backtrace from plugin lib dirs | Jeremy Kemper | 2008-12-30 | 1 | -1/+2 |
| | |||||
* | Clean trailing / after rails root from backtraces | Jeremy Kemper | 2008-12-30 | 1 | -1/+1 |
| | |||||
* | Added gem backtrace pretty priting (Juan Lupión) [#1497 state:committed] | David Heinemeier Hansson | 2008-12-15 | 1 | -0/+3 |
| | |||||
* | Silence server backtrace in rescue templates and log files. Also remove some ↵ | Joshua Peek | 2008-12-05 | 1 | -2/+4 |
| | | | | noise from missing template errors. | ||||
* | Include Rack in the server noise | David Heinemeier Hansson | 2008-11-29 | 1 | -2/+2 |
| | |||||
* | Strip out the ./ part of the test path so the backtrace align perfectly | David Heinemeier Hansson | 2008-11-24 | 1 | -0/+1 |
| | |||||
* | Accept a prefix argument to filter_backtrace_with_cleaning [#1456 ↵ | Manfred Stienstra | 2008-11-24 | 1 | -6/+4 |
| | | | | | | | | | state:committed] Add a prefix argument to filter_backtrace_with_cleaning so it has the same arity as test/unit's filter_backtrace. Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Added ActiveSupport::BacktraceCleaner and Rails::BacktraceCleaner for ↵ | David Heinemeier Hansson | 2008-11-22 | 1 | -0/+34 |
cutting down on backtrace noise (inspired by the Thoughtbot Quiet Backtrace plugin) [DHH] |