aboutsummaryrefslogtreecommitdiffstats
path: root/railties/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
* README.rdoc -> README.md for newly generated applicationsXavier Noria2015-02-061-0/+4
| | | | | | README.rdoc was generated to support the doc:app task. Now that this task is gone we can switch to Markdown, which is nowadays a better default.
* Remove documentation tasksXavier Noria2015-02-061-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the tasks doc:app, doc:rails, and doc:guides. In our experience applications do not generate APIs using doc:app. Methods may be certainly documented for maintainers, annotated with YARD tags, etc. but that is intended to be read with the source code, not in a separate website. Then, teams also have typically selected topics written down in Markdown files, or in a GitHub wiki... that kind of thing. If a team absolutely needs to generate application documentation for internal purposes, they can still easily write their own task. Regarding doc:rails and doc:guides, we live in 2015. We are used to go to online docs all the time. If you really want access to the API offline RubyGems generates it for every Rails component unless you tell it not to, and you can checkout the Rails source code to read the guides as Markdown, or download them for a Kindle reader. All in all, maintaining this code does not seem to be worthwhile anymore. As a consequence of this, guides (+3 MB uncompressed) won't be distributed with the rails gem anymore. Of course, guides and API are going to be still part of releases, since documentation is maintained alongside code and tests. Also, time permitting, this will allow us to experiment with novel ways to generate documentation in the Rails docs server, since right now we were constrained by being able to generate them in the user's environment.
* Force generated route to be insertedAndrew White2015-02-051-0/+4
| | | | | | | Thor isn't very discerning over whether some content is present when passed to `inject_into_file`, e.g. a commented out route is detected as being present. So to prevent people scratching their heads as to why a route hasn't appeared it's better to fall on the side of having duplicate routes.
* Don't remove all line endings from routes.rbAndrew White2015-02-031-0/+6
| | | | | | | | | | | | When there is a single scaffold in the routes.rb with no other lines then revoking/destroying it will create a routes.rb file with a syntax error. This is because the sentinel for the Thor `route` action didn't include the newline but the logged route code did. The fix is to add the newline to the sentinel and remove it from the the logged route code. Fixes #15913.
* Update option to skip test in generatorsMelanie Gilman2015-01-271-0/+4
| | | | Rails no longer generates Test::Unit files by default.
* Add the `method_source` gem to the default GemfileSean Griffin2015-01-131-0/+4
| | | | Fixes #18473
* Drop old test locations from `rake stats`brainopia2015-01-091-0/+6
| | | | | - test/functional - test/unit
* Update `rake counts` to count declarative tests in minitestbrainopia2015-01-091-0/+5
|
* Fix CHANGELOG [ci skip]Rafael Mendonça França2015-01-041-0/+2
|
* Remove deprecated `test:all` and `test:all:db` tasksRafael Mendonça França2015-01-041-0/+2
|
* Remove deprecated `Rails::Rack::LogTailer`Rafael Mendonça França2015-01-041-0/+4
|
* Remove deprecated `RAILS_CACHE` constantRafael Mendonça França2015-01-041-0/+4
|
* Remove deprecated `serve_static_assets` configurationRafael Mendonça França2015-01-041-0/+4
|
* Merge pull request #13434 from tanraya/local_variablesCarlos Antonio da Silva2015-01-031-0/+4
|\ | | | | | | | | | | | | Use local variables in _form.html.erb generated by scaffold. Conflicts: railties/CHANGELOG.md
| * Use local variables in _form.html.erb generated by scaffold generator.tanraya2014-07-261-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | It seems a good idea to use local variables in generated partials instead of using instance variables. Before <%= render 'form' %> After <%= render 'form', product: @product %>
* | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-031-0/+15
|\ \ | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | Add config to halt callback chain on return falseclaudiob2015-01-021-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
* | | Merge pull request #18309 from PaBLoX-CL/fix-fixtures-referencesRafael Mendonça França2015-01-021-0/+4
|/ / | | | | | | | | Generated fixtures won't use parent_id when generated with parent:references
* | Add --skip-action-mailer (or -M) to rails generateclaudiob2015-01-011-0/+4
| |
* | actually autoload all second-level directories called `app/*/concerns`Alex Robbin2014-12-261-0/+4
| |
* | Start Rails 5 development :tada:Rafael Mendonça França2014-11-281-208/+1
| | | | | | | | | | | | | | We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9.
* | Generators add foreign keys on referencesDerek Prior2014-11-251-0/+5
| | | | | | | | | | | | | | | | | | | | | | If you run a generator such as: ``` rails generate model accounts supplier:references ``` The resulting migration will now add the corresponding foreign key constraint unless the reference was specified to be polymorphic.
* | Add a CHANGELOG entry for #16622 and a6de6f5 [ci skip]Zachary Scott2014-11-241-0/+4
| |
* | Merge pull request #17700 from ShunsukeAida/ignore_log_as_a_wholeYves Senn2014-11-211-0/+5
| | | | | | | | | | | | why not gitignore /log as a whole? [ci skip]
* | Improve railties changelog entry and move latest to the top [ci skip]Carlos Antonio da Silva2014-11-121-8/+7
| |
* | Merge pull request #17593 from igas/paths-unshift-arityRafael Mendonça França2014-11-121-0/+5
|\ \ | | | | | | Fix Rails::Paths::Path.unshift interface
| * | Fix Rails::Paths::Path.unshift interfaceIgor Kapkov2014-11-121-0/+5
| | |
* | | Merge pull request #17348 from DavidGeukers/rake_test_allDavid Heinemeier Hansson2014-11-121-0/+6
|\ \ \ | |/ / |/| | simplify rake test vs rake test:all
| * | Simplify rake test vs rake test:allDavid Geukers2014-11-101-0/+6
| | | | | | | | | | | | Renames `rake test:all` to `rake test` by changing old `rake test:run` to previous version of `rake test:all`. Removes old definition of `rake test`. Also renames `rake test:all:db` to `rake test:db` and deprecates `rake test:all` & `rake test:all:db`
* | | Merge pull request #16535 from bf4/patch-1Rafael Mendonça França2014-11-101-0/+6
|\ \ \ | | | | | | | | | | | | Allow fallback to LegacyKeyGenerator when secret_key_base is not set but secrets.secret_token is
| * | | `secret_token` is now saved in `Rails.application.secrets.secret_token`Benjamin Fleischer2014-11-021-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - `secrets.secret_token` is now used in all places `config.secret_token` was - `secrets.secret_token`, when not present in `config/secrets.yml`, now falls back to the value of `config.secret_token` - when `secrets.secret_token` is set, it over-writes `config.secret_token` so they are the same (for backwards-compatibility) - Update docs to reference app.secrets in all places - Remove references to `config.secret_token`, `config.secret_key_base` - Warn that missing secret_key_base is deprecated - Add tests for secret_token, key_generator, and message_verifier - the legacy key generator is used with the message verifier when secrets.secret_key_base is blank and secret_token is set - app.key_generator raises when neither secrets.secret_key_base nor secret_token are set - app.env_config raises when neither secrets.secret_key_base nor secret_token are set - Add changelog Run focused tests via ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
* | | | Add skip-turbolinks entry to 4.2 release notes and improve changelogCarlos Antonio da Silva2014-11-051-1/+1
|/ / / | | | | | | | | | [ci skip]
* / / Add back --skip-turbolinks and remove --skip-gemsRafael Mendonça França2014-10-261-7/+1
|/ / | | | | | | | | | | | | For the most part of cases --skip-gems option just remove one line in the Gemfile. This is not worth for the complexity it adds. Closes #17196
* | some changelog formatting. [ci skip]Yves Senn2014-10-161-1/+1
| |
* | Remove --skip-action-view option from application generatorDan Olson2014-09-241-0/+6
| |
* | Standardize on `Rails.application` [ci skip]Tamir Duberstein2014-09-191-1/+1
| | | | | | | | This seems to be the style settled on in most of the templates.
* | Merge pull request #16936 from untidy-hair/plugin_test_db_migrate_pathRafael Mendonça França2014-09-181-0/+6
|\ \ | | | | | | | | | | | | | | | | | | Specify dummy app's db migrate path in plugin's test_helper.rb Conflicts: railties/CHANGELOG.md
| * | Specify dummy app's db migrate path in plugin's test_helper.rbYukio Mizuta2014-09-161-0/+6
| | |
* | | inject Rack::Lock if config.eager_load is falseXavier Noria2014-09-181-0/+6
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If code is not eager loaded constants are loaded on demand. Constant autoloading is not thread-safe, so if eager loading is not enabled multi-threading should not be allowed. This showed up in certain Capybara scenarios: Most Capybara drivers other than Rack::Test need a web server. In particular, drivers for JavaScript support. Capybara launches WEBrick in its own thread for those but that per se is fine, because the spec thread and the server thread are coordinated. Problem comes if the page being served in the spec makes Ajax calls. Those may hit WEBrick in parallel, and since WEBrick is multi-threaded and allow_concurrency? returns true in the test environment before this patch, threads are spawned to serve those parallel requests. On the other hand, since eager_load is false by default in the test environment, constants are not preloaded. So the suite is autoloading constants in a multi-threaded set. That's a receipt for paracetamol. The symptom is random obscure errors whose messages point somehow to constant autoloading. As a consequence of this fix for allow_concurrency? WEBrick in Capybara scenarios no longer runs in multi-threaded mode. Fixes #15089.
* | Use dynamic path for dummy app location in plugin's test_helper.rbYukio Mizuta2014-09-141-0/+5
| |
* | Fix spelling. [CI SKIP]Guo Xiang Tan2014-08-271-1/+1
| |
* | fix broken `gem` method with non-String arguments. Closes #16709.Yves Senn2014-08-271-0/+7
| | | | | | | | This was caused by #15327.
* | Fix setting simple values to the new config.xCarlos Antonio da Silva2014-08-191-2/+1
| | | | | | | | | | | | | | | | | | | | Previously setting simple values to the config.x object resulted in the following: config.x.super_debugger = true config.x.super_debugger #=> {} Which was against the examples showed in the changelog/release notes.
* | Revert "Improve custom configuration"Rafael Mendonça França2014-08-191-9/+7
| | | | | | | | | | | | | | | | | | This reverts commit de4891344ccc074f6d5693f4fac6ad610584e336. Conflicts: railties/lib/rails/railtie/configuration.rb It added regression. Will be back after the beta
* | Merge pull request #16561 from gsamokovarov/mention-web-console-in-changelogGuillermo Iguaran2014-08-191-0/+7
|\ \ | | | | | | Mention web-console in 4.2 release notes
| * | Mention web-console in 4.2 release notesGenadi Samokovarov2014-08-201-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | Mention the web-console inclusion in the default Gemfile in the Release notes and the railties changelog. We can eventually mention it in the upgrade guide, if needed. [ci skip]
* | | Improve custom configurationRafael Mendonça França2014-08-191-7/+9
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Hashes can be assigned 2. We don't need a special level anymore The method chain only works in the top level. If users need a second level they need to assign a OrderedOptions to the key: config.resque.server = ActiveSupport::OrderedOptions.new config.resque.server.url = "http://localhost" config.resque.server.port = 3000 [Rafael Mendonça França + Carlos Antonio da Silva]
* | Add a `required` option to the model generatorSean Griffin2014-08-081-0/+4
| | | | | | | | | | | | | | | | | | | | | | Syntax was chosen to follow the passing of multiple options to decimal/numeric types. Curly braces, and allowing any of `,`, `.`, or `-` to be used as a separator to avoid the need for shell quoting. (I'm intending to expand this to all columns, but that's another PR. The `required` option will cause 2 things to change. `required: true` will be added to the association. `null: false` will be added to the column in the migration.
* | Merge pull request #16359 from skanev/after-bundle-in-rails-templatesYves Senn2014-08-061-0/+7
|\ \ | | | | | | | | | | | | | | | | | | Add an after_bundle callback in Rails templates Conflicts: railties/CHANGELOG.md
| * | Add an after_bundle callback in Rails templatesStefan Kanev2014-08-031-0/+7
| | | | | | | | | | | | | | | | | | The template runs before the generation of binstubs – this does not allow to write one, that makes an initial commit to version control. It is solvable by adding an after_bundle callback.