Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | initial commit for collector implementation | Aaron Patterson | 2014-03-25 | 1 | -0/+26 | |
|/ | ||||||
* | Merge branch 'rm_a' into ww2lin-rm_a | Aaron Patterson | 2014-03-25 | 1 | -1/+1 | |
|\ | | | | | | | | | * rm_a: take in to account quoted and translated values | |||||
| * | take in to account quoted and translated values | Aaron Patterson | 2014-03-25 | 1 | -1/+1 | |
| | | ||||||
* | | remove the default parameter and updated comment | Alex Lin | 2014-03-25 | 2 | -3/+3 | |
| | | ||||||
* | | removed the attribute that was left in for testing | Alex Lin | 2014-03-25 | 1 | -1/+1 | |
| | | ||||||
* | | Removed all the fiels in lib/arel/visitors/ which needs dependency on 'a' ↵ | Alex Lin | 2014-03-24 | 15 | -380/+367 | |
|/ | | | | also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a. | |||||
* | build quoted nodes in factory methods | Aaron Patterson | 2014-03-24 | 3 | -15/+24 | |
| | ||||||
* | build quoted strings | Aaron Patterson | 2014-03-24 | 3 | -10/+10 | |
| | ||||||
* | add the casting node to the AST at build time | Aaron Patterson | 2014-03-24 | 6 | -21/+69 | |
| | | | | | If we add the casting node to the ast at build time, then we can avoid doing the lookup at visit time. | |||||
* | Merge pull request #246 from cmohanprasath/assign_value_from_attribute_test | Aaron Patterson | 2014-02-24 | 1 | -2/+7 | |
|\ | | | | | Assign value from attribute test | |||||
| * | Allow assignment right member to reference columns | Loic Nageleisen | 2014-02-11 | 1 | -2/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Such queries become possible for mortals: ```ruby table.where(table[:qux].eq 'zomg').compile_update(table[:foo] => table[:bar]) ``` Arguably much more sane than using `engine.connection.quote_column_name` or `engine.connection.visitor.accept` on the right hand (bar), which is totally leaking the abstraction. | |||||
* | | Remove deprecated Arel::Expression | Rafael Mendonça França | 2014-02-10 | 5 | -13/+0 | |
| | | ||||||
* | | Remove deprecated Arel::SqlLiteral | Rafael Mendonça França | 2014-02-10 | 7 | -14/+2 | |
| | | ||||||
* | | Remove deprecated constant aliases | Rafael Mendonça França | 2014-02-10 | 2 | -5/+0 | |
| | | ||||||
* | | Remove deprecated `SelectManager#joins` | Vipul A M | 2014-02-10 | 1 | -8/+0 | |
| | | ||||||
* | | Remove deprecated `SelectManager#to_a` | Vipul A M | 2014-02-10 | 1 | -6/+0 | |
| | | ||||||
* | | Removed deprecated `Arel::Sql::Engine` and make use of `FakeRecord::Base` ↵ | Vipul A M | 2014-02-10 | 2 | -11/+0 | |
|/ | | | | inplace directly for test helper. | |||||
* | Merge pull request #237 from vipulnsward/extract-array | Rafael Mendonça França | 2014-02-08 | 1 | -2/+4 | |
|\ | | | | | Extract comparison array to a constant for the time being until removing the checks completely. | |||||
| * | Extract comparison array to a constant for the time being until removing the ↵ | Vipul A M | 2014-01-07 | 1 | -2/+4 | |
| | | | | | | | | check completely. | |||||
* | | PostgreSQL bugfix for invalid SQL in subqueries | vanderhoorn | 2014-02-05 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | In commit 68a95542e1a7a79d9777223fbffd2b982fed0268 the last_column feature of ToSql was removed. The visit_Arel_Nodes_Matches and visit_Arel_Nodes_DoesNotMatch methods are overwritten in the PostgreSQL class, but were not updated appropriately. This commit fixes the issue accordingly. This bug affects at least all update_all statements in Rails 4.0.2 that have subqueries with ILIKE statements on PostgreSQL. The bug is present in Arel 4.0.1 and later, so it probably affects most Rails 4.0.2 projects. It would be highly appreciated if Arel 4 could get a point release as well. Thanks for your continued work. | |||||
* | | add bind values to the manager class | Aaron Patterson | 2014-01-14 | 1 | -0/+3 | |
|/ | ||||||
* | Documented the case-insensitive nature of the match feature. | Robb Shecter | 2013-12-05 | 1 | -0/+4 | |
| | | | Documenting the library's behavior. People and other libraries (cf. Squeel) have come to depend on this behavior, and so am submitting this pull request to specify it authoritatively. | |||||
* | Remove joins method | Rafael Mendonça França | 2013-12-05 | 1 | -8/+0 | |
| | ||||||
* | Remove deprecated calls from the tests | Rafael Mendonça França | 2013-12-05 | 1 | -2/+2 | |
| | ||||||
* | Arel master is 5.0.0 | Rafael Mendonça França | 2013-11-18 | 1 | -1/+1 | |
| | ||||||
* | explicitly pass the pk to compile_update | Aaron Patterson | 2013-11-16 | 1 | -2/+2 | |
| | ||||||
* | Merge pull request #216 from iantropov/issue_yaml | Rafael Mendonça França | 2013-11-10 | 1 | -0/+4 | |
|\ | | | | | Add :encode_with to sql_literal for proper YAML serialization | |||||
| * | Add :encode_with for proper YAML serialization | Ivan Antropov | 2013-11-09 | 1 | -0/+4 | |
| | | ||||||
* | | Remove deprecated calls to `SelectManager#wheres` with no replacement | Vipul A M | 2013-11-10 | 1 | -5/+0 | |
| | | ||||||
* | | Remove deprecated calls to `SelectManage#insert` with preference to using ↵ | Vipul A M | 2013-11-10 | 1 | -25/+0 | |
| | | | | | | | | `compile_insert` | |||||
* | | Remove deprecated calls to using `where_clauses` | Vipul A M | 2013-11-10 | 1 | -8/+0 | |
| | | ||||||
* | | Remove deprecated calls to using `UpdateManager` without setting ↵ | Vipul A M | 2013-11-10 | 2 | -11/+2 | |
| | | | | | | | | `UpdateManager#key` | |||||
* | | Remove deprecated calls to `update` with preference to using ↵ | Vipul A M | 2013-11-10 | 1 | -13/+0 | |
| | | | | | | | | `compile_update` and then calling `to_sql` on the resulting object to execute the SQL | |||||
* | | Remove deprecated calls to `insert` with preference to using ↵ | Vipul A M | 2013-11-10 | 1 | -11/+0 | |
| | | | | | | | | `compile_insert` and then calling `to_sql` on the resulting object to execute the SQL | |||||
* | | Remove deprecated calls to `delete` with preference to using ↵ | Vipul A M | 2013-11-10 | 1 | -9/+0 | |
| | | | | | | | | `compile_delete` and then calling `to_sql` on the resulting object to execute the SQL | |||||
* | | Merge pull request #196 from vipulnsward/remove_deprecated | Rafael Mendonça França | 2013-11-09 | 1 | -21/+0 | |
|\ \ | |/ |/| | Remove deprecated | |||||
| * | Remove deprecated `Arel::Table#columns` with no replacement | Vipul A M | 2013-07-04 | 1 | -11/+0 | |
| | | ||||||
| * | Remove deprecated `Arel::Table.table_cache` with no replacement | Vipul A M | 2013-07-04 | 1 | -10/+0 | |
| | | ||||||
* | | Fix warning of shadowing variable | Rafael Mendonça França | 2013-10-24 | 1 | -2/+2 | |
| | | ||||||
* | | Release 4.0.1 | Rafael Mendonça França | 2013-10-22 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #211 from yahonda/support_columns_for_distinct_oracle | Aaron Patterson | 2013-10-21 | 1 | -2/+2 | |
|\ \ | | | | | | | Support `columns_for_distinct` with Oracle adapter | |||||
| * | | Support `columns_for_distinct` | Yasuo Honda | 2013-10-14 | 1 | -2/+2 | |
| | | | ||||||
* | | | fix one deprecation warning | Aaron Patterson | 2013-10-14 | 1 | -1/+1 | |
|/ / | ||||||
* | | Merge pull request #204 from trptcolin/visitor_dispatch_caching | Aaron Patterson | 2013-09-11 | 1 | -3/+6 | |
|\ \ | | | | | | | Cache visitor dispatch on a per-visitor basis | |||||
| * | | Cache visitor dispatch on a per-visitor basis | Colin Jones | 2013-08-14 | 1 | -3/+6 | |
| |/ | ||||||
* / | Improve performance of #uniq across a large number of nodes | Sam | 2013-08-30 | 1 | -1/+4 | |
|/ | ||||||
* | record who created the node when $DEBUG is true | Aaron Patterson | 2013-05-20 | 1 | -1/+8 | |
| | ||||||
* | call super from initialize | Aaron Patterson | 2013-05-17 | 8 | -0/+10 | |
| | ||||||
* | Make visitors threadsafe by removing @last_column | Ernie Miller | 2013-04-28 | 15 | -381/+385 | |
| | | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any. | |||||
* | Release 4.0.0 | Rafael Mendonça França | 2013-04-18 | 1 | -1/+1 | |
| |