aboutsummaryrefslogtreecommitdiffstats
path: root/lib/arel
Commit message (Collapse)AuthorAgeFilesLines
...
* Remove `engine` from `TreeManager` and subclassesSean Griffin2014-11-298-26/+16
| | | | | | This constructor parameter was unused for everything except the convenience methods `to_sql` and `where_sql`. We can pass the engine into those methods directly.
* Remove engine from the constructor arguments `Arel::Table`Sean Griffin2014-11-291-40/+21
| | | | | | | | | | | | | | | It is never used outside of convenience methods which are only used in tests. In practice, it just made constructing tables more complicated on the rails side. This is the minimum possible change to remove the constructor argument, but continue to have the tests passing. I'm not sure if we have a reason to keep `project` and friends, and the solution might actually just be to remove the engine from `SelectManager` and friends. As such I've held off on deleting those methods. We need to figure out what to do with `Table#from`. It's old invocation, which read `table.from(table)` was certainly nonsensical.
* Remove deprecated method "Table#primary_key"Sean Griffin2014-11-262-17/+18
| | | | | | | The only place this method was still used is on the MSSQL visitor. The visitor has all of the objects required to inline this lookup there. Since the `primary_key` method on the connection adapter will perform a query when called, we can cache the result on the visitor.
* remove extra space before 'ORDER BY'Nihad Abbasov2014-11-261-1/+0
|
* Support Oracle bind parameter valueYasuo Honda2014-11-201-0/+4
|
* Use class objects rather than strings for the dispatch cacheSean Griffin2014-11-182-18/+10
| | | | | | | | The only reason we're using strings is to pre-populate the cache, but `Class#name` returns a new string instance on every call. This is a pretty major source of memory usage. We don't technically need to pre-populate the cache, and not doing so allows us to go back to using cache objects
* Add order to BindParams in the ToSql collectorSean Griffin2014-11-176-6/+21
| | | | | | | | | | | | This removes the need for us to do the re-ordering by walking the AST in ActiveRecord. We're using a block to communicate with the collector, since the collector needs to be the thing which knows about the index, while the visitor is the thing that needs to know the syntax. The BindParam needs to know about neither of these things, so it's been changed to stop being a subclass of SqlLiteral I could also see an alternative implementation using format strings if for some reason blocks cause a problem.
* cache the dispatch table on the depth first visitorAaron Patterson2014-11-102-6/+21
| | | | | We know the API for the depth first visitor in advance, so it's OK to calcuate this cache in advance
* oops! that should not have been checked inAaron Patterson2014-11-041-2/+1
|
* Look for `Enumerable` rather than `Array` in predicatesSean Griffin2014-11-021-2/+2
| | | | | It's not quite duck typed, but it will allow us to pass in our own objects with additional logic (like type casting).
* Revert "Revert "Merge pull request #300 from jpcody/master""Sean Griffin2014-10-311-4/+5
| | | | | | This reverts commit 9b92af7098b2728ced578ab9a7679176d20f120f. beta2 is out, and we've fixed the issue that this caused in Rails
* Revert "Merge pull request #300 from jpcody/master"Sean Griffin2014-10-301-5/+4
| | | | | This reverts commit 36836fa5e7c084c0dce2818577e6fd0cf815f786, reversing changes made to 53bc8426648cc93695525e8f12102cd416b2d772.
* Dry up building quoted nodes in predicationSean Griffin2014-10-271-15/+23
| | | | | Given that we are going to remove casting from Arel in the near future, having a single place nodes in predications will help.
* Deprecate passing ranges to `#in` and `#not_in`Sean Griffin2014-10-251-35/+49
| | | | | | | The goal of these methods should be to generate in nodes, not handle every possible permutation of more than one value. The `#between` and `#not_between` methods have been extracted, which better represent the semantics of handling ranges in SQL.
* Refactor `#in` and `#not_in`Sean Griffin2014-10-251-16/+20
| | | | | | | These methods duplicate a lot of logic from the other predications. We can just use those methods directly, and only build nodes with the same name in our method directly. We've already had one bug that came from building nodes directly, rather than using the proper predicate.
* Merge pull request #331 from sgrif/sg-in-should-not-break-queriesSean Griffin2014-10-241-1/+1
|\ | | | | `#not_in` with a range should respect proper precedence
| * `#not_in` with a range should respect proper precedenceSean Griffin2014-10-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, doing ```ruby relation[:id].not_eq(4).and(relation[:id].not_in(1..3)) ``` will generate ```sql "id" != 4 AND "id" < 1 OR "id" > 3 ``` Which would incorrectly include records with an id of 4, as the OR statement has higher precidence than the AND statement. The `or` method on `Node` properly groups the statement in parenthesis.
* | Binary nodes should not generate the same hash as nodes of other classesSean Griffin2014-10-241-1/+1
|/
* Completes 08e6491 in reusing `maybe_visit`claudiob2014-10-231-3/+3
| | | | | | | | | :sweat: I don't know why the tests did not fail, but to keep the same syntax as before, `collector =` is required. Maybe `visit` changes `collector` in-place, so the result is the same, but since I'm not sure about the side effects, I think this PR is needed to. Sorry! :sweat:
* Reuse `maybe_visit` methodclaudiob2014-10-232-18/+4
| | | | | This commit simply removes duplicated code by reusing the existing `maybe_visit` method.
* {Matches,DoesNotMatch} support the ESCAPE clauseTamir Duberstein2014-09-255-20/+46
|
* move the dispatch table to be per-instanceAaron Patterson2014-09-226-19/+37
| | | | | | | visitors are not shared among threads, so any mutations to the cache should be OK. The cache is also pre-populated on construction, but we should pull that out so we can share the cache among visitors in the future.
* connections should cache these values, so remove the cache in arelAaron Patterson2014-09-221-4/+3
|
* Merge pull request #167 from pparidans/informix-v9-supportRafael Mendonça França2014-09-171-1/+1
|\ | | | | Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT'
| * Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT'Pierre Paridans2014-09-161-1/+1
| | | | | | | | Still supported in versions 10+
* | Merge pull request #137 from dimko/visit_setRafael Mendonça França2014-09-173-0/+3
|\ \ | |/ |/| Added a visitor for Set objects
| * added a visitor for Set objectsDimko2012-09-183-0/+3
| |
* | Remove unused @alias, being referenced in hashing.Vipul A M2014-09-161-1/+1
| |
* | Wrap group_by sql with a subquery for limiting rows in Oracle.Chris Dinger2014-09-161-1/+1
| | | | | | | | Fixes #128
* | `Extract#as` should not mutate the receiverTamir Duberstein2014-09-132-18/+4
| | | | | | | | Fixes https://github.com/rails/rails/issues/16913
* | Merge pull request #306 from mxhold/masterRafael Mendonça França2014-09-121-0/+9
|\ \ | | | | | | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifier
| * | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifierMax Holder2014-08-301-0/+9
| | |
* | | Merge pull request #304 from bigxiang/fix_lt_and_lteq_errorRafael Mendonça França2014-09-121-6/+6
|\ \ \ | | | | | | | | Fix lt & lteq don't accept most of values.
| * | | Fix lt & lteq don't accept most of values.bigxiang2014-08-231-6/+6
| | | |
* | | | Merge pull request #277 from sergey-alekseev/wrap-nested-gropings-only-onceRafael Mendonça França2014-09-121-2/+6
|\ \ \ \ | |_|/ / |/| | | Wrap nested Nodes::Grouping in brackets only once
| * | | Wrap nested Nodes::Grouping in brackets only onceSergey Alekseev2014-05-261-2/+6
| | | |
* | | | Remove default aliases from aggregate functionsJoshua Cody2014-07-311-14/+8
| | | |
* | | | Allow for alias omission in aggregate expressionsJoshua Cody2014-07-261-8/+15
| |/ / |/| |
* | | Windowing: Calling #rows or #range should assign framing only once.Alexander Staubo2014-06-222-2/+12
| | |
* | | Windowing support for PARTITION BY clause.Alexander Staubo2014-06-203-2/+21
| | |
* | | Modify Visitors::Dot's API to use collectorsJiri Pospisil2014-06-142-3/+5
| | |
* | | Collectors: Introduce PlainString and make use of it in SQLStringJiri Pospisil2014-06-142-14/+21
| | |
* | | Merge pull request #290 from mekishizufu/fix_select_manager_as_subqueryRafael Mendonça França2014-06-131-1/+1
|\ \ \ | | | | | | | | Support passing of SelectManager to attribute methods
| * | | No need to check for SelectStatement as it's a descendant of NodeJiri Pospisil2014-06-121-1/+1
| | | |
| * | | Make sure Arel::SelectManager is not mistaken for an attributeJiri Pospisil2014-06-121-1/+1
| | | |
* | | | Make sure visit_Arel_Nodes_With works with collectorsJiri Pospisil2014-06-121-2/+3
|/ / /
* | | Merge pull request #284 from Octember/masterRafael Mendonça França2014-06-061-18/+22
|\ \ \ | | | | | | | | Cleaned up some edge cases with infinity in predications.rb
| * | | Cleaned up some edge cases with infinity, the logic seems more intuitive nowNoah Lindner2014-06-011-18/+22
| | | |
* | | | Merge pull request #281 from vipulnsward/remove-warningRafael Mendonça França2014-06-021-5/+1
|\ \ \ \ | | | | | | | | | | - Remove four year old deprecation
| * | | | - Remove four year old deprecationVipul A M2014-06-011-5/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 23:59:57 +0000